All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] inode_dio_begin comment fixed.
@ 2021-11-17 11:13 rohitsd1409
  2021-11-17 13:13 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: rohitsd1409 @ 2021-11-17 11:13 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel

inode_dio_begin and inode_dio_end have same comment "This is called once
we have finished processing ...". This comment is applicable only for
inode_dio_end and someone copy pasted it for inode_dio_begin also.
Hence, updated the comment for inode_dio_begin by adding correct
explanation.
---
 include/linux/fs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 1cb616fc1105..2fb075da88a4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3282,8 +3282,7 @@ void inode_dio_wait(struct inode *inode);
  * inode_dio_begin - signal start of a direct I/O requests
  * @inode: inode the direct I/O happens on
  *
- * This is called once we've finished processing a direct I/O request,
- * and is used to wake up callers waiting for direct I/O to be quiesced.
+ * This is called once we've started processing a direct I/O request.
  */
 static inline void inode_dio_begin(struct inode *inode)
 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] inode_dio_begin comment fixed.
  2021-11-17 11:13 [PATCH] inode_dio_begin comment fixed rohitsd1409
@ 2021-11-17 13:13 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2021-11-17 13:13 UTC (permalink / raw)
  To: rohitsd1409; +Cc: viro, linux-fsdevel

On Wed, Nov 17, 2021 at 04:43:26PM +0530, rohitsd1409 wrote:
> +++ b/include/linux/fs.h
> @@ -3282,8 +3282,7 @@ void inode_dio_wait(struct inode *inode);
>   * inode_dio_begin - signal start of a direct I/O requests
>   * @inode: inode the direct I/O happens on
>   *
> - * This is called once we've finished processing a direct I/O request,
> - * and is used to wake up callers waiting for direct I/O to be quiesced.
> + * This is called once we've started processing a direct I/O request.
>   */

 * This is called before we start processing a direct I/O request so
 * that inode_dio_wait() will wait for this to finish.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-17 13:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 11:13 [PATCH] inode_dio_begin comment fixed rohitsd1409
2021-11-17 13:13 ` Matthew Wilcox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.