From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Qi, Yadong" <yadong.qi@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>,
"Chen, Luhai" <luhai.chen@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Christoph Hellwig <hch@infradead.org>,
"Wang, Kai Z" <kai.z.wang@intel.com>,
"hreitz@redhat.com" <hreitz@redhat.com>,
"fam@euphon.net" <fam@euphon.net>
Subject: Re: [PATCH 1/2] block:hdev: support BLKSECDISCARD
Date: Wed, 17 Nov 2021 10:32:23 +0000 [thread overview]
Message-ID: <YZTaN4nZHke5pQ1f@stefanha-x1.localdomain> (raw)
In-Reply-To: <YZSY44T08a2yePpr@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, Nov 16, 2021 at 09:53:39PM -0800, Christoph Hellwig wrote:
> On Tue, Nov 16, 2021 at 10:58:30AM +0000, Stefan Hajnoczi wrote:
> > Question for Jens and Christoph:
> >
> > Is there a way for userspace to detect whether a Linux block device
> > supports SECDISCARD?
>
> I don't know of one.
>
> > If not, then maybe a new sysfs attribute can be added:
>
> This looks correct, but if we start looking into SECDISCARD seriously
> I'd like to split the max_sectors settings for it from discard as that
> is currently a bit of a mess. If we then expose the secure erase max
> sectors in sysfs that would also be a good indicator.
That is probably better because userspace would the queue limits
information too. Thanks!
> What is the use case for exposing secure erase in qemu? The whole
> concept for a LBA based secure erase is generally not a very smart
> idea for flash based media..
Yadong, please see Christoph's question above.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-17 10:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 4:51 [PATCH 0/2] support BLKSECDISCARD yadong.qi
2021-11-15 4:51 ` [PATCH 1/2] block:hdev: " yadong.qi
2021-11-15 12:40 ` Kevin Wolf
2021-11-16 1:54 ` Qi, Yadong
2021-11-15 14:12 ` Stefan Hajnoczi
2021-11-16 2:03 ` Qi, Yadong
2021-11-16 10:58 ` Stefan Hajnoczi
2021-11-17 5:53 ` Christoph Hellwig
2021-11-17 10:32 ` Stefan Hajnoczi [this message]
2021-11-18 1:13 ` Qi, Yadong
2021-11-15 4:52 ` [PATCH 2/2] virtio-blk: " yadong.qi
2021-11-15 10:00 ` Stefano Garzarella
2021-11-16 1:26 ` Qi, Yadong
2021-11-15 10:57 ` Michael S. Tsirkin
2021-11-16 1:33 ` Qi, Yadong
2021-11-15 14:26 ` Stefan Hajnoczi
2021-11-16 2:13 ` Qi, Yadong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZTaN4nZHke5pQ1f@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=axboe@kernel.dk \
--cc=fam@euphon.net \
--cc=hch@infradead.org \
--cc=hreitz@redhat.com \
--cc=kai.z.wang@intel.com \
--cc=kwolf@redhat.com \
--cc=luhai.chen@intel.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yadong.qi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.