All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Saravana Kannan <saravanak@google.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] of: property: fw_devlink: Fixup behaviour when 'node_not_dev' is set
Date: Thu, 18 Nov 2021 08:14:21 -0600	[thread overview]
Message-ID: <YZZfvU2SQp5A09vF@robh.at.kernel.org> (raw)
In-Reply-To: <20210902090221.820254-1-ulf.hansson@linaro.org>

On Thu, 02 Sep 2021 11:02:21 +0200, Ulf Hansson wrote:
> In the struct supplier_bindings the member 'node_not_dev' is described as
> "The consumer node containing the property is never a device.", but that is
> inconsistent with the behaviour of the code in of_link_property(), as it
> calls of_get_compat_node() that starts parsing for a compatible property
> from the node it gets passed to it. The proper behaviour is to start at the
> node's parent, so let's do that.
> 
> While at it, let's take the opportunity to update the description of the
> 'node_not_dev' flag, as to clarify its purpose.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/of/property.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 

Applied, thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Saravana Kannan <saravanak@google.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] of: property: fw_devlink: Fixup behaviour when 'node_not_dev' is set
Date: Thu, 18 Nov 2021 08:14:21 -0600	[thread overview]
Message-ID: <YZZfvU2SQp5A09vF@robh.at.kernel.org> (raw)
In-Reply-To: <20210902090221.820254-1-ulf.hansson@linaro.org>

On Thu, 02 Sep 2021 11:02:21 +0200, Ulf Hansson wrote:
> In the struct supplier_bindings the member 'node_not_dev' is described as
> "The consumer node containing the property is never a device.", but that is
> inconsistent with the behaviour of the code in of_link_property(), as it
> calls of_get_compat_node() that starts parsing for a compatible property
> from the node it gets passed to it. The proper behaviour is to start at the
> node's parent, so let's do that.
> 
> While at it, let's take the opportunity to update the description of the
> 'node_not_dev' flag, as to clarify its purpose.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/of/property.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-18 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02  9:02 [PATCH] of: property: fw_devlink: Fixup behaviour when 'node_not_dev' is set Ulf Hansson
2021-09-02  9:02 ` Ulf Hansson
2021-09-02 17:09 ` Saravana Kannan
2021-09-02 17:09   ` Saravana Kannan
2021-11-18 14:02 ` Ulf Hansson
2021-11-18 14:02   ` Ulf Hansson
2021-11-18 14:14 ` Rob Herring [this message]
2021-11-18 14:14   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZZfvU2SQp5A09vF@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.