All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: jae.hyun.yoo@intel.com
Cc: Rob Herring <robh+dt@kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>, Corey Minyard <minyard@acm.org>,
	devicetree@vger.kernel.org,
	Haiyue Wang <haiyue.wang@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	openipmi-developer@lists.sourceforge.net,
	Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	linux-aspeed@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>,
	Cedric Le Goater <clg@kaod.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property
Date: Thu, 18 Nov 2021 19:07:49 -0600	[thread overview]
Message-ID: <YZb45WLaOzRtW9+g@robh.at.kernel.org> (raw)
In-Reply-To: <20211108190200.290957-3-jae.hyun.yoo@intel.com>

On Mon, 08 Nov 2021 11:01:56 -0800, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> 
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
> 
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds 'clocks' property as one of
> required properties to enable the LCLK by the LPC IBT driver.
> 
> Note: dtsi change in this patch series should be applied along with,
> and dtbs should be re-compiled after applying this series since
> it's adding a new required property otherwise the driver will not
> be probed correctly.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> ---
> v2 -> v3:
>  * Made commit message more descriptive.
> 
> v1 -> v2:
>  * Added 'clocks' property into ibt bindings using
>    'aspeed,ast2400-ibt-bmc.txt' because it's not merged into
>    'aspeed-lpc.yaml' yet. The bindings merging could be done using a
>    separate patch later.
> 
>  .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt         | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: jae.hyun.yoo@intel.com
Cc: Rob Herring <robh+dt@kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>, Corey Minyard <minyard@acm.org>,
	devicetree@vger.kernel.org,
	Haiyue Wang <haiyue.wang@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	openipmi-developer@lists.sourceforge.net,
	Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	linux-aspeed@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>,
	Cedric Le Goater <clg@kaod.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property
Date: Thu, 18 Nov 2021 19:07:49 -0600	[thread overview]
Message-ID: <YZb45WLaOzRtW9+g@robh.at.kernel.org> (raw)
In-Reply-To: <20211108190200.290957-3-jae.hyun.yoo@intel.com>

On Mon, 08 Nov 2021 11:01:56 -0800, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> 
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
> 
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds 'clocks' property as one of
> required properties to enable the LCLK by the LPC IBT driver.
> 
> Note: dtsi change in this patch series should be applied along with,
> and dtbs should be re-compiled after applying this series since
> it's adding a new required property otherwise the driver will not
> be probed correctly.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> ---
> v2 -> v3:
>  * Made commit message more descriptive.
> 
> v1 -> v2:
>  * Added 'clocks' property into ibt bindings using
>    'aspeed,ast2400-ibt-bmc.txt' because it's not merged into
>    'aspeed-lpc.yaml' yet. The bindings merging could be done using a
>    separate patch later.
> 
>  .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt         | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-19  1:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 19:01 [PATCH v3 0/6] Add LCLK control into Aspeed LPC sub drivers jae.hyun.yoo
2021-11-08 19:01 ` jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 1/6] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo
2021-11-08 19:01   ` jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-08 19:01   ` jae.hyun.yoo
2021-11-19  1:07   ` Rob Herring [this message]
2021-11-19  1:07     ` Rob Herring
2021-11-08 19:01 ` [PATCH v3 3/6] ipmi: bt: add clock control logic jae.hyun.yoo
2021-11-08 19:01   ` jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 4/6] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo
2021-11-08 19:01   ` jae.hyun.yoo
2021-11-08 19:01 ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property jae.hyun.yoo
2021-11-08 19:01   ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed, kcs-bmc: " jae.hyun.yoo
2021-11-19  1:08   ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: " Rob Herring
2021-11-19  1:08     ` Rob Herring
2021-11-08 19:02 ` [PATCH v3 6/6] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo
2021-11-08 19:02   ` jae.hyun.yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZb45WLaOzRtW9+g@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@aj.id.au \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=clg@kaod.org \
    --cc=devicetree@vger.kernel.org \
    --cc=haiyue.wang@linux.intel.com \
    --cc=jae.hyun.yoo@intel.com \
    --cc=jae.hyun.yoo@linux.intel.com \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.