From: Joerg Roedel <joro@8bytes.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, will@kernel.org,
robin.murphy@arm.com, jean-philippe@linaro.org,
zhukeqian1@huawei.com, alex.williamson@redhat.com,
jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com,
kevin.tian@intel.com, ashok.raj@intel.com, maz@kernel.org,
peter.maydell@linaro.org, vivek.gautam@arm.com,
shameerali.kolothum.thodi@huawei.com, wangxingang5@huawei.com,
jiangkunkun@huawei.com, yuzenghui@huawei.com,
nicoleotsuka@gmail.com, chenxiang66@hisilicon.com,
sumitg@nvidia.com, nicolinc@nvidia.com, vdumpa@nvidia.com,
zhangfei.gao@linaro.org, zhangfei.gao@gmail.com,
lushenming@huawei.com, vsethi@nvidia.com
Subject: Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API
Date: Mon, 6 Dec 2021 11:48:23 +0100 [thread overview]
Message-ID: <Ya3qd6mT/DpceSm8@8bytes.org> (raw)
In-Reply-To: <20211027104428.1059740-2-eric.auger@redhat.com>
On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote:
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
This Signed-of-by chain looks dubious, you are the author but the last
one in the chain?
> +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain,
> + void __user *uinfo)
> +{
[...]
> + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 &&
> + pasid_table_data.argsz <
> + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3))
> + return -EINVAL;
This check looks like it belongs in driver specific code.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org,
vivek.gautam@arm.com, kvmarm@lists.cs.columbia.edu,
eric.auger.pro@gmail.com, jean-philippe@linaro.org,
ashok.raj@intel.com, maz@kernel.org, vsethi@nvidia.com,
zhangfei.gao@linaro.org, kevin.tian@intel.com, will@kernel.org,
alex.williamson@redhat.com, wangxingang5@huawei.com,
linux-kernel@vger.kernel.org, lushenming@huawei.com,
iommu@lists.linux-foundation.org, robin.murphy@arm.com
Subject: Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API
Date: Mon, 6 Dec 2021 11:48:23 +0100 [thread overview]
Message-ID: <Ya3qd6mT/DpceSm8@8bytes.org> (raw)
In-Reply-To: <20211027104428.1059740-2-eric.auger@redhat.com>
On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote:
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
This Signed-of-by chain looks dubious, you are the author but the last
one in the chain?
> +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain,
> + void __user *uinfo)
> +{
[...]
> + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 &&
> + pasid_table_data.argsz <
> + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3))
> + return -EINVAL;
This check looks like it belongs in driver specific code.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: kvm@vger.kernel.org, vivek.gautam@arm.com, vdumpa@nvidia.com,
kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com,
jean-philippe@linaro.org, yi.l.liu@intel.com,
ashok.raj@intel.com, maz@kernel.org, vsethi@nvidia.com,
nicolinc@nvidia.com, zhangfei.gao@linaro.org, sumitg@nvidia.com,
kevin.tian@intel.com, jacob.jun.pan@linux.intel.com,
will@kernel.org, nicoleotsuka@gmail.com,
alex.williamson@redhat.com, wangxingang5@huawei.com,
chenxiang66@hisilicon.com, linux-kernel@vger.kernel.org,
lushenming@huawei.com, iommu@lists.linux-foundation.org,
robin.murphy@arm.com
Subject: Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API
Date: Mon, 6 Dec 2021 11:48:23 +0100 [thread overview]
Message-ID: <Ya3qd6mT/DpceSm8@8bytes.org> (raw)
In-Reply-To: <20211027104428.1059740-2-eric.auger@redhat.com>
On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote:
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
This Signed-of-by chain looks dubious, you are the author but the last
one in the chain?
> +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain,
> + void __user *uinfo)
> +{
[...]
> + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 &&
> + pasid_table_data.argsz <
> + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3))
> + return -EINVAL;
This check looks like it belongs in driver specific code.
Regards,
Joerg
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-12-06 10:49 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 10:44 [RFC v16 0/9] SMMUv3 Nested Stage Setup (IOMMU part) Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-12-06 10:48 ` Joerg Roedel [this message]
2021-12-06 10:48 ` Joerg Roedel
2021-12-06 10:48 ` Joerg Roedel
2021-12-07 10:22 ` Eric Auger
2021-12-07 10:22 ` Eric Auger
2021-12-07 10:22 ` Eric Auger
2021-12-08 2:44 ` Lu Baolu
2021-12-08 2:44 ` Lu Baolu
2021-12-08 2:44 ` Lu Baolu
2021-12-08 7:33 ` Eric Auger
2021-12-08 7:33 ` Eric Auger
2021-12-08 7:33 ` Eric Auger
2021-12-08 12:56 ` Jason Gunthorpe
2021-12-08 12:56 ` Jason Gunthorpe
2021-12-08 12:56 ` Jason Gunthorpe via iommu
2021-12-08 17:20 ` Jean-Philippe Brucker
2021-12-08 17:20 ` Jean-Philippe Brucker
2021-12-08 17:20 ` Jean-Philippe Brucker
2021-12-08 18:31 ` Jason Gunthorpe
2021-12-08 18:31 ` Jason Gunthorpe
2021-12-08 18:31 ` Jason Gunthorpe via iommu
2021-12-09 2:58 ` Tian, Kevin
2021-12-09 2:58 ` Tian, Kevin
2021-12-09 2:58 ` Tian, Kevin
[not found] ` <BN9PR11MB527624080CB9302481B74C7A8C709@BN9PR11MB5276.namprd11.prod.outlook.com>
2021-12-09 3:59 ` Tian, Kevin
2021-12-09 3:59 ` Tian, Kevin
2021-12-09 3:59 ` Tian, Kevin
2021-12-09 16:08 ` Jason Gunthorpe
2021-12-09 16:08 ` Jason Gunthorpe
2021-12-09 16:08 ` Jason Gunthorpe via iommu
2021-12-10 8:56 ` Tian, Kevin
2021-12-10 8:56 ` Tian, Kevin
2021-12-10 13:23 ` Jason Gunthorpe
2021-12-10 13:23 ` Jason Gunthorpe
2021-12-11 3:57 ` Tian, Kevin
2021-12-11 3:57 ` Tian, Kevin
2021-12-16 20:48 ` Jason Gunthorpe
2021-12-16 20:48 ` Jason Gunthorpe
2022-01-04 2:42 ` Tian, Kevin
2022-01-04 2:42 ` Tian, Kevin
2021-12-11 5:18 ` Tian, Kevin
2021-12-11 5:18 ` Tian, Kevin
2021-12-09 7:50 ` Eric Auger
2021-12-09 7:50 ` Eric Auger
2021-12-09 7:50 ` Eric Auger
2021-12-09 15:40 ` Jason Gunthorpe
2021-12-09 15:40 ` Jason Gunthorpe
2021-12-09 15:40 ` Jason Gunthorpe via iommu
2021-12-09 16:37 ` Eric Auger
2021-12-09 16:37 ` Eric Auger
2021-12-09 16:37 ` Eric Auger
2021-12-09 3:21 ` Tian, Kevin
2021-12-09 3:21 ` Tian, Kevin
2021-12-09 3:21 ` Tian, Kevin
2021-12-09 9:44 ` Eric Auger
2021-12-09 9:44 ` Eric Auger
2021-12-09 9:44 ` Eric Auger
2021-12-09 8:31 ` Eric Auger
2021-12-09 8:31 ` Eric Auger
2021-12-09 8:31 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 2/9] iommu: Introduce iommu_get_nesting Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 22:15 ` kernel test robot
2021-10-28 3:22 ` kernel test robot
2021-10-27 10:44 ` [RFC v16 3/9] iommu/smmuv3: Allow s1 and s2 configs to coexist Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 4/9] iommu/smmuv3: Get prepared for nested stage support Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 5/9] iommu/smmuv3: Implement attach/detach_pasid_table Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 6/9] iommu/smmuv3: Allow stage 1 invalidation with unmanaged ASIDs Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 7/9] iommu/smmuv3: Implement cache_invalidate Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` [RFC v16 8/9] iommu/smmuv3: report additional recoverable faults Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 21:05 ` kernel test robot
2021-10-27 22:41 ` kernel test robot
2021-10-27 22:41 ` kernel test robot
2021-10-27 10:44 ` [RFC v16 9/9] iommu/smmuv3: Disallow nested mode in presence of HW MSI regions Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-10-27 10:44 ` Eric Auger
2021-12-03 12:27 ` [RFC v16 0/9] SMMUv3 Nested Stage Setup (IOMMU part) Zhangfei Gao
2021-12-03 12:27 ` Zhangfei Gao
2021-12-03 12:27 ` Zhangfei Gao
2021-12-07 10:27 ` Eric Auger
2021-12-07 10:27 ` Eric Auger
2021-12-07 10:27 ` Eric Auger
2021-12-07 10:35 ` Zhangfei Gao
2021-12-07 10:35 ` Zhangfei Gao
2021-12-07 10:35 ` Zhangfei Gao
2021-12-07 11:06 ` Eric Auger
2021-12-07 11:06 ` Eric Auger
2021-12-07 11:06 ` Eric Auger
2021-12-08 13:33 ` Shameerali Kolothum Thodi
2021-12-08 13:33 ` Shameerali Kolothum Thodi
2021-12-08 13:33 ` Shameerali Kolothum Thodi via iommu
2021-12-03 13:13 ` Sumit Gupta
2021-12-03 13:13 ` Sumit Gupta
2021-12-03 13:13 ` Sumit Gupta via iommu
2021-12-07 10:28 ` Eric Auger
2021-12-07 10:28 ` Eric Auger
2021-12-07 10:28 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya3qd6mT/DpceSm8@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jiangkunkun@huawei.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=lushenming@huawei.com \
--cc=maz@kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sumitg@nvidia.com \
--cc=vdumpa@nvidia.com \
--cc=vivek.gautam@arm.com \
--cc=vsethi@nvidia.com \
--cc=wangxingang5@huawei.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=yuzenghui@huawei.com \
--cc=zhangfei.gao@gmail.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.