[PATCH] net/mlx5: Remove the repeated declaration

[PATCH] net/mlx5: Remove the repeated declaration

[Shaokun Zhang]

Function 'mlx5_esw_vport_match_metadata_supported' and
'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
the repeated declaration and blank line.

Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
index 42f8ee2e5d9f..844e673ff73c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
@@ -339,9 +339,6 @@ void mlx5_esw_match_metadata_free(struct mlx5_eswitch *esw, u32 metadata);
 
 int mlx5_esw_qos_modify_vport_rate(struct mlx5_eswitch *esw, u16 vport_num, u32 rate_mbps);
 
-bool mlx5_esw_vport_match_metadata_supported(const struct mlx5_eswitch *esw);
-int mlx5_esw_offloads_vport_metadata_set(struct mlx5_eswitch *esw, bool enable);
-
 /* E-Switch API */
 int mlx5_eswitch_init(struct mlx5_core_dev *dev);
 void mlx5_eswitch_cleanup(struct mlx5_eswitch *esw);
-- 
2.33.0

Re: [PATCH] net/mlx5: Remove the repeated declaration

[Leon Romanovsky]

On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> Function 'mlx5_esw_vport_match_metadata_supported' and
> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> the repeated declaration and blank line.
> 
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
>  1 file changed, 3 deletions(-)
> 

Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH] net/mlx5: Remove the repeated declaration

[Shaokun Zhang]

Hi Leon,

On 2021/12/7 20:40, Leon Romanovsky wrote:
> On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
>> Function 'mlx5_esw_vport_match_metadata_supported' and
>> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
>> the repeated declaration and blank line.
>>
>> Cc: Saeed Mahameed <saeedm@nvidia.com>
>> Cc: Leon Romanovsky <leon@kernel.org>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
>>  1 file changed, 3 deletions(-)
>>
> 
> Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> 

Shall we need this tag since it is trivial cleanup patch?

> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Thanks your reply.

> .
> 

Re: [PATCH] net/mlx5: Remove the repeated declaration

[Leon Romanovsky]

On Wed, Dec 08, 2021 at 09:27:37AM +0800, Shaokun Zhang wrote:
> Hi Leon,
> 
> On 2021/12/7 20:40, Leon Romanovsky wrote:
> > On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> >> Function 'mlx5_esw_vport_match_metadata_supported' and
> >> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> >> the repeated declaration and blank line.
> >>
> >> Cc: Saeed Mahameed <saeedm@nvidia.com>
> >> Cc: Leon Romanovsky <leon@kernel.org>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> >> ---
> >>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
> >>  1 file changed, 3 deletions(-)
> >>
> > 
> > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> > 
> 
> Shall we need this tag since it is trivial cleanup patch?

I don't know about netdev policy about Fixes line.

IMHO, it should be always when the bug is fixed.

Thansk

> 
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> 
> Thanks your reply.
> 
> > .
> > 

Re: [PATCH] net/mlx5: Remove the repeated declaration

[Jakub Kicinski]

On Wed, 8 Dec 2021 10:59:45 +0200 Leon Romanovsky wrote:
> > > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> > 
> > Shall we need this tag since it is trivial cleanup patch?  
> 
> I don't know about netdev policy about Fixes line.
> 
> IMHO, it should be always when the bug is fixed.

This is not a bug, tho. Bugs bother users.

Re: [PATCH] net/mlx5: Remove the repeated declaration

[Saeed Mahameed]

On Tue, 2021-12-07 at 20:35 +0800, Shaokun Zhang wrote:
> Function 'mlx5_esw_vport_match_metadata_supported' and
> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> the repeated declaration and blank line.
> 
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

Applied to net-next-mlx5.
Thanks !