From: Mark Brown <broonie@kernel.org>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
alexandre.belloni@bootlin.com, thomas.petazzoni@bootlin.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: soc-core: add the driver component name to the component struc
Date: Tue, 7 Dec 2021 13:08:33 +0000 [thread overview]
Message-ID: <Ya9c0d/X0z1QUVN6@sirena.org.uk> (raw)
In-Reply-To: <20211207094732.3be5befb@kmaincent-XPS-13-7390>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Tue, Dec 07, 2021 at 09:47:32AM +0100, Köry Maincent wrote:
> Mark Brown <broonie@kernel.org> wrote:
> > Why is one device registering multiple components in the first place?
> Because the sound components are more and more complex. Why they shouldn't?
In what way are they more complex?
> It seems to be already the case:
> sound/soc/codecs/cros_ec_codec.c
> sound/soc/fsl/fsl_easrc.c
> sound/soc/mediatek/mt*/mt*-afe-pcm.c
> sound/soc/sunxi/sun4i-codec.c
> sound/soc/soc-utils.c
Quite a few (I think all?) of these are quite old and and are the result
of refactoring from pre-component code rather than modern drivers, it's
likely there is no concrete reason for them to behave as they do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: alsa-devel@alsa-project.org, alexandre.belloni@bootlin.com,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] ASoC: soc-core: add the driver component name to the component struc
Date: Tue, 7 Dec 2021 13:08:33 +0000 [thread overview]
Message-ID: <Ya9c0d/X0z1QUVN6@sirena.org.uk> (raw)
In-Reply-To: <20211207094732.3be5befb@kmaincent-XPS-13-7390>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Tue, Dec 07, 2021 at 09:47:32AM +0100, Köry Maincent wrote:
> Mark Brown <broonie@kernel.org> wrote:
> > Why is one device registering multiple components in the first place?
> Because the sound components are more and more complex. Why they shouldn't?
In what way are they more complex?
> It seems to be already the case:
> sound/soc/codecs/cros_ec_codec.c
> sound/soc/fsl/fsl_easrc.c
> sound/soc/mediatek/mt*/mt*-afe-pcm.c
> sound/soc/sunxi/sun4i-codec.c
> sound/soc/soc-utils.c
Quite a few (I think all?) of these are quite old and and are the result
of refactoring from pre-component code rather than modern drivers, it's
likely there is no concrete reason for them to behave as they do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-07 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 9:59 [PATCH] ASoC: soc-core: add the driver component name to the component struc Kory Maincent
2021-12-06 9:59 ` Kory Maincent
2021-12-06 19:33 ` Mark Brown
2021-12-06 19:33 ` Mark Brown
2021-12-07 8:47 ` Köry Maincent
2021-12-07 8:47 ` Köry Maincent
2021-12-07 13:08 ` Mark Brown [this message]
2021-12-07 13:08 ` Mark Brown
2021-12-07 15:16 ` Köry Maincent
2021-12-07 15:16 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9c0d/X0z1QUVN6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=kory.maincent@bootlin.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.