From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/3] doc: Add LTP-003 and LTP-004 static and tst API prefix rules
Date: Mon, 29 Nov 2021 11:33:36 +0100 [thread overview]
Message-ID: <YaSsgBZnShdzXkp7@pevik> (raw)
In-Reply-To: <YaSov/lABpoDlsXN@yuki>
> Hi!
> > BTW It'd be nice to have some check for shell library (maybe shellcheck would be
> > able to do it).
> Actually the check is in the shell library script.
I'm avare only about the check in tst_run() which check that tests are not using
variables starting with TST or _tst_ prefix, which is important.
My remark was about "LTP-003: Externally visible library symbols have the tst_
prefix", which is slightly different think. Not sure if can be scripted, thus
feel free to ignore it.
I have more remarks on shell checking, but post it as a separate thread.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-29 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 12:43 [LTP] [PATCH 0/3] tools/sparse: Add static check Richard Palethorpe via ltp
2021-11-23 12:43 ` [LTP] [PATCH 1/3] " Richard Palethorpe via ltp
2021-11-24 7:12 ` Petr Vorel
2021-11-30 8:24 ` Richard Palethorpe
2021-11-30 10:19 ` Cyril Hrubis
2021-11-30 10:23 ` Cyril Hrubis
2021-11-30 10:33 ` Richard Palethorpe
2021-11-30 10:51 ` Cyril Hrubis
2021-11-30 11:43 ` Cyril Hrubis
2021-11-24 10:00 ` Richard Palethorpe
2021-11-29 10:16 ` Cyril Hrubis
2021-11-23 12:43 ` [LTP] [PATCH 2/3] doc: Add LTP-003 and LTP-004 static and tst API prefix rules Richard Palethorpe via ltp
2021-11-24 7:18 ` Petr Vorel
2021-11-29 10:17 ` Cyril Hrubis
2021-11-29 10:33 ` Petr Vorel [this message]
2021-11-29 10:44 ` Cyril Hrubis
2021-11-23 12:43 ` [LTP] [PATCH 3/3] statx: Add missing static keyword to tcase variable Richard Palethorpe via ltp
2021-11-24 7:19 ` Petr Vorel
2021-11-29 10:16 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaSsgBZnShdzXkp7@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.