From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: chrubis@suze.cz, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] tools/sparse: Add static check
Date: Tue, 30 Nov 2021 11:51:44 +0100 [thread overview]
Message-ID: <YaYCQKX+ns1F5ldR@yuki> (raw)
In-Reply-To: <87mtllly6e.fsf@suse.de>
Hi!
> >> > Thanks! pushed. Please pull and try it out.
> >>
> >> Looks like it fails on fuzzy sync since it uses tst_ but it's in an
> >> header.
> >>
> >> These definitions should be static inline and changing them so fixes the
> >> warnings. It looks like static inline functions does not make it into
> >> the symbol test at all.
>
> Ah, I vaguely remember now that "static inline" is the correct way to
> include functions in header files. Otherwise they shouldn't be in header
> files. We have LTO now as well so possibly Fuzzy sync shouldn't be all
> in the header, but that's another matter.
If I recall correctly LTO is currently broken on ARM and even if that
was working we still have to support 10 years old compilers anyways...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-11-30 10:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 12:43 [LTP] [PATCH 0/3] tools/sparse: Add static check Richard Palethorpe via ltp
2021-11-23 12:43 ` [LTP] [PATCH 1/3] " Richard Palethorpe via ltp
2021-11-24 7:12 ` Petr Vorel
2021-11-30 8:24 ` Richard Palethorpe
2021-11-30 10:19 ` Cyril Hrubis
2021-11-30 10:23 ` Cyril Hrubis
2021-11-30 10:33 ` Richard Palethorpe
2021-11-30 10:51 ` Cyril Hrubis [this message]
2021-11-30 11:43 ` Cyril Hrubis
2021-11-24 10:00 ` Richard Palethorpe
2021-11-29 10:16 ` Cyril Hrubis
2021-11-23 12:43 ` [LTP] [PATCH 2/3] doc: Add LTP-003 and LTP-004 static and tst API prefix rules Richard Palethorpe via ltp
2021-11-24 7:18 ` Petr Vorel
2021-11-29 10:17 ` Cyril Hrubis
2021-11-29 10:33 ` Petr Vorel
2021-11-29 10:44 ` Cyril Hrubis
2021-11-23 12:43 ` [LTP] [PATCH 3/3] statx: Add missing static keyword to tcase variable Richard Palethorpe via ltp
2021-11-24 7:19 ` Petr Vorel
2021-11-29 10:16 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaYCQKX+ns1F5ldR@yuki \
--to=chrubis@suse.cz \
--cc=chrubis@suze.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.