From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> To: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: linux-media@vger.kernel.org, nicolas.dufresne@collabora.com, mchehab@kernel.org, robh+dt@kernel.org, mripard@kernel.org, wens@csie.org, p.zabel@pengutronix.de, andrzej.p@collabora.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 5/9] media: hantro: move postproc enablement for old cores Date: Tue, 30 Nov 2021 09:20:03 -0300 [thread overview] Message-ID: <YaYW8yLNrXvWkopx@eze-laptop> (raw) In-Reply-To: <20211129182633.480021-6-jernej.skrabec@gmail.com> On Mon, Nov 29, 2021 at 07:26:29PM +0100, Jernej Skrabec wrote: > Older G2 cores, like that in Allwinner H6, seem to have issue with > latching postproc register values if this is first thing done in job. > Moving that to the end solves the issue. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Thanks! > --- > drivers/staging/media/hantro/hantro.h | 2 ++ > drivers/staging/media/hantro/hantro_drv.c | 9 ++++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro.h b/drivers/staging/media/hantro/hantro.h > index 83ed25d9657b..06d0f3597694 100644 > --- a/drivers/staging/media/hantro/hantro.h > +++ b/drivers/staging/media/hantro/hantro.h > @@ -75,6 +75,7 @@ struct hantro_irq { > * @num_regs: number of register range names in the array > * @double_buffer: core needs double buffering > * @legacy_regs: core uses legacy register set > + * @late_postproc: postproc must be set up at the end of the job > */ > struct hantro_variant { > unsigned int enc_offset; > @@ -98,6 +99,7 @@ struct hantro_variant { > int num_regs; > unsigned int double_buffer : 1; > unsigned int legacy_regs : 1; > + unsigned int late_postproc : 1; > }; > > /** > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c > index 770f4ce71d29..33bf78be145b 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++ b/drivers/staging/media/hantro/hantro_drv.c > @@ -130,7 +130,7 @@ void hantro_start_prepare_run(struct hantro_ctx *ctx) > v4l2_ctrl_request_setup(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > > - if (!ctx->is_encoder) { > + if (!ctx->is_encoder && !ctx->dev->variant->late_postproc) { > if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > hantro_postproc_enable(ctx); > else > @@ -142,6 +142,13 @@ void hantro_end_prepare_run(struct hantro_ctx *ctx) > { > struct vb2_v4l2_buffer *src_buf; > > + if (!ctx->is_encoder && ctx->dev->variant->late_postproc) { > + if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > + hantro_postproc_enable(ctx); > + else > + hantro_postproc_disable(ctx); > + } > + > src_buf = hantro_get_src_buf(ctx); > v4l2_ctrl_request_complete(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > -- > 2.34.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> To: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: linux-media@vger.kernel.org, nicolas.dufresne@collabora.com, mchehab@kernel.org, robh+dt@kernel.org, mripard@kernel.org, wens@csie.org, p.zabel@pengutronix.de, andrzej.p@collabora.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 5/9] media: hantro: move postproc enablement for old cores Date: Tue, 30 Nov 2021 09:20:03 -0300 [thread overview] Message-ID: <YaYW8yLNrXvWkopx@eze-laptop> (raw) In-Reply-To: <20211129182633.480021-6-jernej.skrabec@gmail.com> On Mon, Nov 29, 2021 at 07:26:29PM +0100, Jernej Skrabec wrote: > Older G2 cores, like that in Allwinner H6, seem to have issue with > latching postproc register values if this is first thing done in job. > Moving that to the end solves the issue. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Thanks! > --- > drivers/staging/media/hantro/hantro.h | 2 ++ > drivers/staging/media/hantro/hantro_drv.c | 9 ++++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro.h b/drivers/staging/media/hantro/hantro.h > index 83ed25d9657b..06d0f3597694 100644 > --- a/drivers/staging/media/hantro/hantro.h > +++ b/drivers/staging/media/hantro/hantro.h > @@ -75,6 +75,7 @@ struct hantro_irq { > * @num_regs: number of register range names in the array > * @double_buffer: core needs double buffering > * @legacy_regs: core uses legacy register set > + * @late_postproc: postproc must be set up at the end of the job > */ > struct hantro_variant { > unsigned int enc_offset; > @@ -98,6 +99,7 @@ struct hantro_variant { > int num_regs; > unsigned int double_buffer : 1; > unsigned int legacy_regs : 1; > + unsigned int late_postproc : 1; > }; > > /** > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c > index 770f4ce71d29..33bf78be145b 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++ b/drivers/staging/media/hantro/hantro_drv.c > @@ -130,7 +130,7 @@ void hantro_start_prepare_run(struct hantro_ctx *ctx) > v4l2_ctrl_request_setup(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > > - if (!ctx->is_encoder) { > + if (!ctx->is_encoder && !ctx->dev->variant->late_postproc) { > if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > hantro_postproc_enable(ctx); > else > @@ -142,6 +142,13 @@ void hantro_end_prepare_run(struct hantro_ctx *ctx) > { > struct vb2_v4l2_buffer *src_buf; > > + if (!ctx->is_encoder && ctx->dev->variant->late_postproc) { > + if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > + hantro_postproc_enable(ctx); > + else > + hantro_postproc_disable(ctx); > + } > + > src_buf = hantro_get_src_buf(ctx); > v4l2_ctrl_request_complete(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 12:20 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-29 18:26 [PATCH v2 0/9] media: hantro: add Allwinner H6 support Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-29 18:26 ` [PATCH v2 1/9] media: hantro: Fix probe func error path Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-30 10:26 ` Andrzej Pietrasiewicz 2021-11-30 10:26 ` Andrzej Pietrasiewicz 2021-11-30 12:11 ` Ezequiel Garcia 2021-11-30 12:11 ` Ezequiel Garcia 2021-11-29 18:26 ` [PATCH v2 2/9] media: hantro: add support for reset lines Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-30 10:42 ` Andrzej Pietrasiewicz 2021-11-30 10:42 ` Andrzej Pietrasiewicz 2021-11-30 12:15 ` Ezequiel Garcia 2021-11-30 12:15 ` Ezequiel Garcia 2021-11-29 18:26 ` [PATCH v2 3/9] media: hantro: vp9: use double buffering if needed Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-29 18:26 ` [PATCH v2 4/9] media: hantro: vp9: add support for legacy register set Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-29 18:26 ` [PATCH v2 5/9] media: hantro: move postproc enablement for old cores Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-30 10:44 ` Andrzej Pietrasiewicz 2021-11-30 10:44 ` Andrzej Pietrasiewicz 2021-11-30 12:20 ` Ezequiel Garcia [this message] 2021-11-30 12:20 ` Ezequiel Garcia 2021-11-29 18:26 ` [PATCH v2 6/9] media: hantro: Convert imx8m_vpu_g2_irq to helper Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-30 10:45 ` Andrzej Pietrasiewicz 2021-11-30 10:45 ` Andrzej Pietrasiewicz 2021-11-30 12:20 ` Ezequiel Garcia 2021-11-30 12:20 ` Ezequiel Garcia 2021-11-29 18:26 ` [PATCH v2 7/9] media: dt-bindings: allwinner: document H6 Hantro G2 binding Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-12-07 21:14 ` Rob Herring 2021-12-07 21:14 ` Rob Herring 2021-11-29 18:26 ` [PATCH v2 8/9] media: hantro: Add support for Allwinner H6 Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-11-30 11:08 ` Andrzej Pietrasiewicz 2021-11-30 11:08 ` Andrzej Pietrasiewicz 2021-11-30 12:24 ` Ezequiel Garcia 2021-11-30 12:24 ` Ezequiel Garcia 2021-11-29 18:26 ` [PATCH v2 9/9] arm64: dts: allwinner: h6: Add Hantro G2 node Jernej Skrabec 2021-11-29 18:26 ` Jernej Skrabec 2021-12-16 7:48 ` (subset) " Maxime Ripard 2021-12-16 7:48 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YaYW8yLNrXvWkopx@eze-laptop \ --to=ezequiel@vanguardiasur.com.ar \ --cc=andrzej.p@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=linux-sunxi@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=nicolas.dufresne@collabora.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.