* [PATCH v2 1/1] usb: dwc3: drd: Add support for usb-conn-gpio based usb-role-switch
@ 2021-11-25 14:15 Alexander Stein
2021-12-03 11:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2021-11-25 14:15 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman; +Cc: Alexander Stein, linux-usb
usb-conn-gpio devices are a subnode of the USB interface controller, which
needs to be populated.
This allows having a non-type-c connector providing dual-role.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Added missing variable declaration
drivers/usb/dwc3/drd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index d7f76835137f..8b5ac689b8da 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -9,6 +9,7 @@
#include <linux/extcon.h>
#include <linux/of_graph.h>
+#include "linux/of_platform.h"
#include <linux/platform_device.h>
#include <linux/property.h>
@@ -542,6 +543,7 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc)
{
struct usb_role_switch_desc dwc3_role_switch = {NULL};
u32 mode;
+ int ret;
dwc->role_switch_default_mode = usb_get_role_switch_default_mode(dwc->dev);
if (dwc->role_switch_default_mode == USB_DR_MODE_HOST) {
@@ -559,6 +561,13 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc)
if (IS_ERR(dwc->role_sw))
return PTR_ERR(dwc->role_sw);
+ /* populate connector entry */
+ ret = devm_of_platform_populate(dwc->dev);
+ if (ret) {
+ dev_err(dwc->dev, "DWC3 platform devices creation failed: %i\n", ret);
+ return ret;
+ }
+
dwc3_set_mode(dwc, mode);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] usb: dwc3: drd: Add support for usb-conn-gpio based usb-role-switch
2021-11-25 14:15 [PATCH v2 1/1] usb: dwc3: drd: Add support for usb-conn-gpio based usb-role-switch Alexander Stein
@ 2021-12-03 11:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-03 11:02 UTC (permalink / raw)
To: Alexander Stein; +Cc: Felipe Balbi, linux-usb
On Thu, Nov 25, 2021 at 03:15:16PM +0100, Alexander Stein wrote:
> usb-conn-gpio devices are a subnode of the USB interface controller, which
> needs to be populated.
> This allows having a non-type-c connector providing dual-role.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Added missing variable declaration
>
> drivers/usb/dwc3/drd.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
> index d7f76835137f..8b5ac689b8da 100644
> --- a/drivers/usb/dwc3/drd.c
> +++ b/drivers/usb/dwc3/drd.c
> @@ -9,6 +9,7 @@
>
> #include <linux/extcon.h>
> #include <linux/of_graph.h>
> +#include "linux/of_platform.h"
> #include <linux/platform_device.h>
> #include <linux/property.h>
>
> @@ -542,6 +543,7 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc)
> {
> struct usb_role_switch_desc dwc3_role_switch = {NULL};
> u32 mode;
> + int ret;
>
> dwc->role_switch_default_mode = usb_get_role_switch_default_mode(dwc->dev);
> if (dwc->role_switch_default_mode == USB_DR_MODE_HOST) {
> @@ -559,6 +561,13 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc)
> if (IS_ERR(dwc->role_sw))
> return PTR_ERR(dwc->role_sw);
>
> + /* populate connector entry */
> + ret = devm_of_platform_populate(dwc->dev);
> + if (ret) {
> + dev_err(dwc->dev, "DWC3 platform devices creation failed: %i\n", ret);
> + return ret;
> + }
You do not have to unwind what usb_role_switch_register() did here if
there is an error?
And will ALL systems always succeed at the call to
devm_of_platform_populate()? Or will this break older systems that are
running today? What was this tested with?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 14:15 [PATCH v2 1/1] usb: dwc3: drd: Add support for usb-conn-gpio based usb-role-switch Alexander Stein
2021-12-03 11:02 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.