From: Marco Elver <elver@google.com> To: andrey.konovalov@linux.dev Cc: Alexander Potapenko <glider@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Peter Collingbourne <pcc@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, kasan-dev@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH 23/31] kasan, arm64: allow KASAN_VMALLOC with SW_TAGS Date: Fri, 3 Dec 2021 13:37:56 +0100 [thread overview] Message-ID: <YaoPpPAKi0/OZB2f@elver.google.com> (raw) In-Reply-To: <f90dfb0c02598aab3ad1b5b6ea4a4104b14e099d.1638308023.git.andreyknvl@google.com> On Tue, Nov 30, 2021 at 11:07PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > vmalloc support for SW_TAGS KASAN is now complete. > > Allow enabling CONFIG_KASAN_VMALLOC. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> This change is small enough that I would have expected the lib/Kconfig.kasan change to appear in "kasan, vmalloc: add vmalloc support to SW_TAGS" because that sounds like it would fully unlock core KASAN support. However, the arm64 change could be in its own patch, since there may be conflicts with arm64 tree or during backports, and only dropping that may be ok. I've been backporting too many patches lately, that I feel that would help. > --- > arch/arm64/Kconfig | 1 + > lib/Kconfig.kasan | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c4207cf9bb17..c05d7a06276f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -206,6 +206,7 @@ config ARM64 > select IRQ_DOMAIN > select IRQ_FORCED_THREADING > select KASAN_VMALLOC if KASAN_GENERIC > + select KASAN_VMALLOC if KASAN_SW_TAGS > select MODULES_USE_ELF_RELA > select NEED_DMA_MAP_STATE > select NEED_SG_DMA_LENGTH > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index cdc842d090db..3f144a87f8a3 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -179,7 +179,7 @@ config KASAN_TAGS_IDENTIFY > > config KASAN_VMALLOC > bool "Back mappings in vmalloc space with real shadow memory" > - depends on KASAN_GENERIC && HAVE_ARCH_KASAN_VMALLOC > + depends on (KASAN_GENERIC || KASAN_SW_TAGS) && HAVE_ARCH_KASAN_VMALLOC > help > By default, the shadow region for vmalloc space is the read-only > zero page. This means that KASAN cannot detect errors involving > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Marco Elver <elver@google.com> To: andrey.konovalov@linux.dev Cc: Alexander Potapenko <glider@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Peter Collingbourne <pcc@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, kasan-dev@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH 23/31] kasan, arm64: allow KASAN_VMALLOC with SW_TAGS Date: Fri, 3 Dec 2021 13:37:56 +0100 [thread overview] Message-ID: <YaoPpPAKi0/OZB2f@elver.google.com> (raw) In-Reply-To: <f90dfb0c02598aab3ad1b5b6ea4a4104b14e099d.1638308023.git.andreyknvl@google.com> On Tue, Nov 30, 2021 at 11:07PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > vmalloc support for SW_TAGS KASAN is now complete. > > Allow enabling CONFIG_KASAN_VMALLOC. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> This change is small enough that I would have expected the lib/Kconfig.kasan change to appear in "kasan, vmalloc: add vmalloc support to SW_TAGS" because that sounds like it would fully unlock core KASAN support. However, the arm64 change could be in its own patch, since there may be conflicts with arm64 tree or during backports, and only dropping that may be ok. I've been backporting too many patches lately, that I feel that would help. > --- > arch/arm64/Kconfig | 1 + > lib/Kconfig.kasan | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c4207cf9bb17..c05d7a06276f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -206,6 +206,7 @@ config ARM64 > select IRQ_DOMAIN > select IRQ_FORCED_THREADING > select KASAN_VMALLOC if KASAN_GENERIC > + select KASAN_VMALLOC if KASAN_SW_TAGS > select MODULES_USE_ELF_RELA > select NEED_DMA_MAP_STATE > select NEED_SG_DMA_LENGTH > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index cdc842d090db..3f144a87f8a3 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -179,7 +179,7 @@ config KASAN_TAGS_IDENTIFY > > config KASAN_VMALLOC > bool "Back mappings in vmalloc space with real shadow memory" > - depends on KASAN_GENERIC && HAVE_ARCH_KASAN_VMALLOC > + depends on (KASAN_GENERIC || KASAN_SW_TAGS) && HAVE_ARCH_KASAN_VMALLOC > help > By default, the shadow region for vmalloc space is the read-only > zero page. This means that KASAN cannot detect errors involving > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-03 12:38 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 21:39 [PATCH 00/31] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:39 ` [PATCH 01/31] kasan, page_alloc: deduplicate should_skip_kasan_poison andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:39 ` [PATCH 02/31] kasan, page_alloc: move tag_clear_highpage out of kernel_init_free_pages andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-02 15:24 ` Alexander Potapenko 2021-12-02 15:24 ` Alexander Potapenko 2021-11-30 21:39 ` [PATCH 03/31] kasan, page_alloc: merge kasan_free_pages into free_pages_prepare andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-02 15:32 ` Alexander Potapenko 2021-12-02 15:32 ` Alexander Potapenko 2021-11-30 21:39 ` [PATCH 04/31] kasan, page_alloc: simplify kasan_poison_pages call site andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-12-01 14:09 ` Marco Elver 2021-12-01 14:09 ` Marco Elver 2021-12-06 21:07 ` Andrey Konovalov 2021-12-06 21:07 ` Andrey Konovalov 2021-11-30 21:39 ` [PATCH 05/31] kasan, page_alloc: init memory of skipped pages on free andrey.konovalov 2021-11-30 21:39 ` andrey.konovalov 2021-11-30 21:41 ` [PATCH 06/31] mm: clarify __GFP_ZEROTAGS comment andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-11-30 21:41 ` [PATCH 07/31] kasan: only apply __GFP_ZEROTAGS when memory is zeroed andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-12-02 15:40 ` Alexander Potapenko 2021-12-02 15:40 ` Alexander Potapenko 2021-11-30 21:41 ` [PATCH 08/31] kasan, page_alloc: refactor init checks in post_alloc_hook andrey.konovalov 2021-11-30 21:41 ` andrey.konovalov 2021-12-02 16:13 ` Alexander Potapenko 2021-12-02 16:13 ` Alexander Potapenko 2021-12-06 21:09 ` Andrey Konovalov 2021-12-06 21:09 ` Andrey Konovalov 2021-12-16 10:59 ` Alexander Potapenko 2021-12-16 10:59 ` Alexander Potapenko 2021-11-30 21:42 ` [PATCH 09/31] kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook andrey.konovalov 2021-11-30 21:42 ` andrey.konovalov 2021-11-30 21:52 ` [PATCH 10/31] kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook andrey.konovalov 2021-11-30 21:52 ` andrey.konovalov 2021-11-30 22:05 ` [PATCH 11/31] kasan, page_alloc: move SetPageSkipKASanPoison " andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov 2021-11-30 22:05 ` [PATCH 12/31] kasan, page_alloc: move kernel_init_free_pages " andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov 2021-11-30 22:05 ` [PATCH 13/31] kasan, page_alloc: simplify kasan_unpoison_pages call site andrey.konovalov 2021-11-30 22:05 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 14/31] kasan: clean up metadata byte definitions andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 15/31] kasan: define KASAN_VMALLOC_INVALID for SW_TAGS andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 16/31] kasan, x86, arm64, s390: rename functions for modules shadow andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:06 ` [PATCH 17/31] kasan, vmalloc: drop outdated VM_KASAN comment andrey.konovalov 2021-11-30 22:06 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 18/31] kasan: reorder vmalloc hooks andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 20/31] kasan, vmalloc: reset tags in vmalloc functions andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-02 14:17 ` Marco Elver 2021-12-02 14:17 ` Marco Elver 2021-12-06 21:08 ` Andrey Konovalov 2021-12-06 21:08 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 19/31] kasan: add wrappers for vmalloc hooks andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 21/31] kasan, fork: don't tag stacks allocated with vmalloc andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-02 14:27 ` Marco Elver 2021-12-02 14:27 ` Marco Elver 2021-12-06 21:08 ` Andrey Konovalov 2021-12-06 21:08 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 22/31] kasan, vmalloc: add vmalloc support to SW_TAGS andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-11-30 22:07 ` [PATCH 23/31] kasan, arm64: allow KASAN_VMALLOC with SW_TAGS andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-03 12:37 ` Marco Elver [this message] 2021-12-03 12:37 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-11-30 22:07 ` [PATCH 24/31] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged andrey.konovalov 2021-11-30 22:07 ` andrey.konovalov 2021-12-03 12:42 ` Marco Elver 2021-12-03 12:42 ` Marco Elver 2021-12-06 21:12 ` Andrey Konovalov 2021-12-06 21:12 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 25/31] kasan, vmalloc: don't unpoison VM_ALLOC pages before mapping andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 26/31] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 27/31] kasan, vmalloc: add vmalloc support to HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-03 12:41 ` Marco Elver 2021-12-03 12:41 ` Marco Elver 2021-12-06 21:12 ` Andrey Konovalov 2021-12-06 21:12 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 28/31] kasan: add kasan.vmalloc command line flag andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-03 12:09 ` Marco Elver 2021-12-03 12:09 ` Marco Elver 2021-12-06 21:09 ` Andrey Konovalov 2021-12-06 21:09 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 29/31] kasan, arm64: allow KASAN_VMALLOC with HW_TAGS andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-12-01 11:35 ` Marco Elver 2021-12-01 11:35 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-12-03 12:40 ` Marco Elver 2021-12-03 12:40 ` Marco Elver 2021-12-06 21:10 ` Andrey Konovalov 2021-12-06 21:10 ` Andrey Konovalov 2021-11-30 22:08 ` [PATCH 30/31] kasan: documentation updates andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov 2021-11-30 22:08 ` [PATCH 31/31] kasan: improve vmalloc tests andrey.konovalov 2021-11-30 22:08 ` andrey.konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YaoPpPAKi0/OZB2f@elver.google.com \ --to=elver@google.com \ --cc=akpm@linux-foundation.org \ --cc=andrey.konovalov@linux.dev \ --cc=andreyknvl@gmail.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=pcc@google.com \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.