* f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
@ 2021-12-18 21:25 Chuck Lever III
2021-12-19 8:57 ` Leon Romanovsky
2021-12-19 9:51 ` Maor Gottlieb
0 siblings, 2 replies; 4+ messages in thread
From: Chuck Lever III @ 2021-12-18 21:25 UTC (permalink / raw)
To: linux-rdma
NFS/RDMA with an NFS client using mlx5-based hardware triggers a
system deadlock (no error messages) on the client. I bisected to
f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in
dereg MR flow").
--
Chuck Lever
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
2021-12-18 21:25 f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow") Chuck Lever III
@ 2021-12-19 8:57 ` Leon Romanovsky
2021-12-19 9:51 ` Maor Gottlieb
1 sibling, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2021-12-19 8:57 UTC (permalink / raw)
To: Chuck Lever III; +Cc: linux-rdma
On Sat, Dec 18, 2021 at 09:25:18PM +0000, Chuck Lever III wrote:
> NFS/RDMA with an NFS client using mlx5-based hardware triggers a
> system deadlock (no error messages) on the client. I bisected to
> f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in
> dereg MR flow").
Thanks for the report. We started to look on it, but the vacation season
makes it is slower than usual.
Thanks
>
> --
> Chuck Lever
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
2021-12-18 21:25 f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow") Chuck Lever III
2021-12-19 8:57 ` Leon Romanovsky
@ 2021-12-19 9:51 ` Maor Gottlieb
2021-12-19 18:19 ` Chuck Lever III
1 sibling, 1 reply; 4+ messages in thread
From: Maor Gottlieb @ 2021-12-19 9:51 UTC (permalink / raw)
To: Chuck Lever III, linux-rdma
On 12/18/2021 11:25 PM, Chuck Lever III wrote:
> NFS/RDMA with an NFS client using mlx5-based hardware triggers a
> system deadlock (no error messages) on the client. I bisected to
> f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in
> dereg MR flow").
>
> --
> Chuck Lever
Hi Chuck,
I found some bug in the cited commit. Can you please test if the below
patch fixes this deadlock ?
diff --git a/drivers/infiniband/hw/mlx5/mr.c
b/drivers/infiniband/hw/mlx5/mr.c
index 157d862fb864..3cb4e34fe199 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -1978,7 +1978,7 @@ int mlx5_ib_dereg_mr(struct ib_mr *ibmr, struct
ib_udata *udata)
return rc;
}
- if (mr->umem) {
+ if (udata && mr->umem) {
bool is_odp = is_odp_mr(mr);
if (!is_odp)
>
>
>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
2021-12-19 9:51 ` Maor Gottlieb
@ 2021-12-19 18:19 ` Chuck Lever III
0 siblings, 0 replies; 4+ messages in thread
From: Chuck Lever III @ 2021-12-19 18:19 UTC (permalink / raw)
To: Maor Gottlieb; +Cc: linux-rdma
Hello Maor-
> On Dec 19, 2021, at 4:51 AM, Maor Gottlieb <maorg@nvidia.com> wrote:
>
>
> On 12/18/2021 11:25 PM, Chuck Lever III wrote:
>> NFS/RDMA with an NFS client using mlx5-based hardware triggers a
>> system deadlock (no error messages) on the client. I bisected to
>> f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in
>> dereg MR flow").
>>
>> --
>> Chuck Lever
>
> Hi Chuck,
>
> I found some bug in the cited commit. Can you please test if the below patch fixes this deadlock ?
>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 157d862fb864..3cb4e34fe199 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -1978,7 +1978,7 @@ int mlx5_ib_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)
> return rc;
> }
>
> - if (mr->umem) {
> + if (udata && mr->umem) {
> bool is_odp = is_odp_mr(mr);
>
> if (!is_odp)
After applying this one-liner, I am not able to reproduce the
NFS client system deadlock.
Tested-by: Chuck Lever <chuck.lever@oracle.com>
--
Chuck Lever
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-19 18:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-18 21:25 f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow") Chuck Lever III
2021-12-19 8:57 ` Leon Romanovsky
2021-12-19 9:51 ` Maor Gottlieb
2021-12-19 18:19 ` Chuck Lever III
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.