Re: [LTP] [PATCH v2 3/3] lib: Add support for debugging .all_filesystems

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +| 'LTP_SINGLE_FS_TYPE'  | Testing only specified filesystem instead all
                                         ^   ^
					 |   "specifies"
					 there should be comma or dash here

> +                          supported (for tests with '.all_filesystems').
>  | 'LTP_DEV_FS_TYPE'     | Filesystem used for testing (default: 'ext2').
>  | 'LTP_TIMEOUT_MUL'     | Multiply timeout, must be number >= 1 (> 1 is useful for
>                            slow machines to avoid unexpected timeout).
> diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c
> index fc072cadfd..23e5ce8775 100644
> --- a/lib/tst_supported_fs_types.c
> +++ b/lib/tst_supported_fs_types.c
> @@ -139,8 +139,17 @@ const char **tst_get_supported_fs_types(const char *const *skiplist)
>  	unsigned int i, j = 0;
>  	int skip_fuse;
>  	enum tst_fs_impl sup;
> +	const char *only_fs;
>  
>  	skip_fuse = tst_fs_in_skiplist("fuse", skiplist);
> +	only_fs = getenv("LTP_SINGLE_FS_TYPE");
> +
> +	if (only_fs) {
> +		tst_res(TINFO, "WARNING: testing only %s", only_fs);
> +		if (tst_fs_is_supported(only_fs))
> +			fs_types[0] = only_fs;
> +		return fs_types;
> +	}
>  
>  	for (i = 0; fs_type_whitelist[i]; i++) {
>  		if (tst_fs_in_skiplist(fs_type_whitelist[i], skiplist)) {
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index f92ff858e9..ce2b8239d7 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -483,6 +483,7 @@ static void print_help(void)
>  	fprintf(stderr, "LTP_COLORIZE_OUTPUT  Force colorized output behaviour (y/1 always, n/0: never)\n");
>  	fprintf(stderr, "LTP_DEV              Path to the block device to be used (for .needs_device)\n");
>  	fprintf(stderr, "LTP_DEV_FS_TYPE      Filesystem used for testing (default: %s)\n", DEFAULT_FS_TYPE);
> +	fprintf(stderr, "LTP_SINGLE_FS_TYPE   Testing only specified filesystem instead all supported (for .all_filesystems)\n");
>  	fprintf(stderr, "LTP_TIMEOUT_MUL      Multiply timeout (must be number >= 1)\n");
>  	fprintf(stderr, "LTP_VIRT_OVERRIDE    Overrides virtual machine detection (values: \"\"|kvm|microsoft|xen|zvm\n");
>  	fprintf(stderr, "TMPDIR               Base directory for template directory (for .needs_tmpdir, default: %s)\n", TEMPDIR);

Other than that the rest looks fine, for the patchset:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp