From: Li Wang <liwang@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 3/3] lib: Add support for debugging .all_filesystems
Date: Wed, 15 Dec 2021 15:49:54 +0800 [thread overview]
Message-ID: <CAEemH2eXMWXt5GeY8EXaoPbS66-fju71iY+hJERNKMip+DqxLA@mail.gmail.com> (raw)
In-Reply-To: <YbjKV7yUJS+njaCY@pevik>
[-- Attachment #1.1: Type: text/plain, Size: 1085 bytes --]
On Wed, Dec 15, 2021 at 12:46 AM Petr Vorel <pvorel@suse.cz> wrote:
> Hi Cyril, Li,
>
> > Hi!
> > > +| 'LTP_SINGLE_FS_TYPE' | Testing only specified filesystem instead
> all
> > ^ ^
> > | "specifies"
> > there should be comma or dash here
>
> I meant "specific", i.e. Testing only specific filesystem instead all
> supported,
>
+1
> but "Testing only - specifies filesystem instead all supported" makes more
> sense.
>
Hmm, I think it also makes sense to people who care about the
only one filesystem on their product. So this should _NOT_ be limit
for test/debug, because it can help to reduce testing time for specific
requirements.
Let's just provide a variable and leave the usage to users:).
>
> > Other than that the rest looks fine, for the patchset:
> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
> Thanks! Waiting for Li and others for input before merging it.
>
Good work.
Reviewed-by: Li Wang <liwang@redhat.com>
--
Regards,
Li Wang
[-- Attachment #1.2: Type: text/html, Size: 2803 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-15 7:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 14:43 [LTP] [PATCH v2 0/3] Add support for debugging .all_filesystems Petr Vorel
2021-12-14 14:43 ` [LTP] [PATCH v2 1/3] lib: Introduce tst_defaults.h Petr Vorel
2021-12-14 14:43 ` [LTP] [PATCH v2 2/3] tst_test: Print environment variables on -h Petr Vorel
2021-12-14 16:44 ` Tim.Bird
2021-12-14 16:47 ` Petr Vorel
2021-12-14 16:57 ` Petr Vorel
2021-12-14 17:53 ` Tim.Bird
2021-12-14 18:54 ` Petr Vorel
2021-12-15 7:36 ` Li Wang
2021-12-15 9:49 ` Cyril Hrubis
2021-12-14 14:43 ` [LTP] [PATCH v2 3/3] lib: Add support for debugging .all_filesystems Petr Vorel
2021-12-14 16:03 ` Cyril Hrubis
2021-12-14 16:46 ` Petr Vorel
2021-12-15 7:49 ` Li Wang [this message]
2021-12-15 9:28 ` Petr Vorel
2021-12-15 9:30 ` Cyril Hrubis
2021-12-15 9:49 ` Li Wang
2021-12-15 9:54 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEemH2eXMWXt5GeY8EXaoPbS66-fju71iY+hJERNKMip+DqxLA@mail.gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.