All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Brian Starkey <brian.starkey@arm.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	liviu.dudau@arm.com, airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	nd@arm.com
Subject: Re: [PATCH] drm: mali-dp: potential dereference of null pointer
Date: Mon, 20 Dec 2021 10:40:47 +0100	[thread overview]
Message-ID: <YcBPn6ZTLbobErXj@phenom.ffwll.local> (raw)
In-Reply-To: <20211214110202.unexcdiya3qhsvzc@000377403353>

On Tue, Dec 14, 2021 at 11:02:02AM +0000, Brian Starkey wrote:
> Hi,
> 
> On Tue, Dec 14, 2021 at 06:08:37PM +0800, Jiasheng Jiang wrote:
> > The return value of kzalloc() needs to be checked.
> > To avoid use of null pointer '&state->base' in case of the
> > failure of alloc.
> > 
> > Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> > ---
> 
> You can add my r-b to this one too. Thanks!

Are you (or someone else from arm) also pushing these? Otherwise they'll
get lost.
-Daniel

> 
> >  drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> > index 494075ddbef6..b5928b52e279 100644
> > --- a/drivers/gpu/drm/arm/malidp_crtc.c
> > +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> > @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
> >  	if (crtc->state)
> >  		malidp_crtc_destroy_state(crtc, crtc->state);
> >  
> > -	__drm_atomic_helper_crtc_reset(crtc, &state->base);
> > +	if (state)
> > +		__drm_atomic_helper_crtc_reset(crtc, &state->base);
> > +	else
> > +		__drm_atomic_helper_crtc_reset(crtc, NULL);
> >  }
> >  
> >  static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
> > -- 
> > 2.25.1
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Brian Starkey <brian.starkey@arm.com>
Cc: airlied@linux.ie, Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	liviu.dudau@arm.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, nd@arm.com
Subject: Re: [PATCH] drm: mali-dp: potential dereference of null pointer
Date: Mon, 20 Dec 2021 10:40:47 +0100	[thread overview]
Message-ID: <YcBPn6ZTLbobErXj@phenom.ffwll.local> (raw)
In-Reply-To: <20211214110202.unexcdiya3qhsvzc@000377403353>

On Tue, Dec 14, 2021 at 11:02:02AM +0000, Brian Starkey wrote:
> Hi,
> 
> On Tue, Dec 14, 2021 at 06:08:37PM +0800, Jiasheng Jiang wrote:
> > The return value of kzalloc() needs to be checked.
> > To avoid use of null pointer '&state->base' in case of the
> > failure of alloc.
> > 
> > Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> > ---
> 
> You can add my r-b to this one too. Thanks!

Are you (or someone else from arm) also pushing these? Otherwise they'll
get lost.
-Daniel

> 
> >  drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> > index 494075ddbef6..b5928b52e279 100644
> > --- a/drivers/gpu/drm/arm/malidp_crtc.c
> > +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> > @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
> >  	if (crtc->state)
> >  		malidp_crtc_destroy_state(crtc, crtc->state);
> >  
> > -	__drm_atomic_helper_crtc_reset(crtc, &state->base);
> > +	if (state)
> > +		__drm_atomic_helper_crtc_reset(crtc, &state->base);
> > +	else
> > +		__drm_atomic_helper_crtc_reset(crtc, NULL);
> >  }
> >  
> >  static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
> > -- 
> > 2.25.1
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2021-12-20  9:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 10:08 [PATCH] drm: mali-dp: potential dereference of null pointer Jiasheng Jiang
2021-12-14 10:08 ` Jiasheng Jiang
2021-12-14 11:02 ` Brian Starkey
2021-12-14 11:02   ` Brian Starkey
2021-12-20  9:40   ` Daniel Vetter [this message]
2021-12-20  9:40     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcBPn6ZTLbobErXj@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=brian.starkey@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jiasheng@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.