* [PATCH v2] USB: host: Check for null res pointer
@ 2021-12-20 15:15 Jiasheng Jiang
2021-12-20 15:29 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2021-12-20 15:15 UTC (permalink / raw)
To: ok, gregkh; +Cc: linux-usb, linux-kernel, Jiasheng Jiang
The return value of platform_get_resource() needs to be checked.
To avoid use of error pointer in case of the failure of alloc.
Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v1 -> v2
*Change 1. Just skip the use of null pointer instead of directly return.
---
drivers/usb/host/isp116x-hcd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 8835f6bd528e..8c7f0991c21b 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev)
iounmap(isp116x->data_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- release_mem_region(res->start, 2);
+ if (res)
+ release_mem_region(res->start, 2);
iounmap(isp116x->addr_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, 2);
+ if (res)
+ release_mem_region(res->start, 2);
usb_put_hcd(hcd);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] USB: host: Check for null res pointer
2021-12-20 15:15 [PATCH v2] USB: host: Check for null res pointer Jiasheng Jiang
@ 2021-12-20 15:29 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-12-20 15:29 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: ok, linux-usb, linux-kernel
On Mon, Dec 20, 2021 at 11:15:24PM +0800, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.
Should be all one sentence, right?
>
> Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
What driver is this? That needs to be in the subject line at the very
least.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] USB: host: Check for null res pointer
@ 2021-12-20 8:10 Jiasheng Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2021-12-20 8:10 UTC (permalink / raw)
To: ok, gregkh; +Cc: linux-usb, linux-kernel, Jiasheng Jiang
The return value of platform_get_resource() needs to be checked.
To avoid use of error pointer in case that there is no suitable resource.
Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v1 -> v2
*Change 1. Correct the commit message.
---
drivers/usb/host/isp116x-hcd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 8835f6bd528e..addd2b43a14c 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1541,9 +1541,15 @@ static int isp116x_remove(struct platform_device *pdev)
iounmap(isp116x->data_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+ if (!res)
+ return -EINVAL;
+
release_mem_region(res->start, 2);
iounmap(isp116x->addr_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -EINVAL;
+
release_mem_region(res->start, 2);
usb_put_hcd(hcd);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 15:15 [PATCH v2] USB: host: Check for null res pointer Jiasheng Jiang
2021-12-20 15:29 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-12-20 8:10 Jiasheng Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.