From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH v4 01/34] component: Introduce struct aggregate_device
Date: Tue, 21 Dec 2021 10:28:10 +0100 [thread overview]
Message-ID: <YcGeKpy/oecKlKZg@kroah.com> (raw)
In-Reply-To: <20211202222732.2453851-2-swboyd@chromium.org>
On Thu, Dec 02, 2021 at 02:26:59PM -0800, Stephen Boyd wrote:
> Replace 'struct master' with 'struct aggregate_device' and then rename
> 'master' to 'adev' everywhere in the code. While we're here, put a
> struct device inside the aggregate device so that we can register it
> with a bus_type in the next patch.
Do not do a "while we are here" type change please. Do the
rename/replace first, and then make the other change.
> The diff is large but that's because this is mostly a rename, where
> sometimes 'master' is replaced with 'adev' and other times it is
> replaced with 'parent' to indicate that the struct device that was being
> used is actually the parent of the aggregate device and driver.
The diff is 15 lines, how is that "large"?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Saravana Kannan <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Russell King <rmk+kernel@arm.linux.org.uk>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v4 01/34] component: Introduce struct aggregate_device
Date: Tue, 21 Dec 2021 10:28:10 +0100 [thread overview]
Message-ID: <YcGeKpy/oecKlKZg@kroah.com> (raw)
In-Reply-To: <20211202222732.2453851-2-swboyd@chromium.org>
On Thu, Dec 02, 2021 at 02:26:59PM -0800, Stephen Boyd wrote:
> Replace 'struct master' with 'struct aggregate_device' and then rename
> 'master' to 'adev' everywhere in the code. While we're here, put a
> struct device inside the aggregate device so that we can register it
> with a bus_type in the next patch.
Do not do a "while we are here" type change please. Do the
rename/replace first, and then make the other change.
> The diff is large but that's because this is mostly a rename, where
> sometimes 'master' is replaced with 'adev' and other times it is
> replaced with 'parent' to indicate that the struct device that was being
> used is actually the parent of the aggregate device and driver.
The diff is 15 lines, how is that "large"?
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-21 9:28 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 22:26 [PATCH v4 00/34] component: Make into an aggregate bus Stephen Boyd
2021-12-02 22:26 ` Stephen Boyd
2021-12-02 22:26 ` [PATCH v4 01/34] component: Introduce struct aggregate_device Stephen Boyd
2021-12-02 22:26 ` Stephen Boyd
2021-12-21 9:28 ` Greg Kroah-Hartman [this message]
2021-12-21 9:28 ` Greg Kroah-Hartman
2022-01-06 2:11 ` Stephen Boyd
2022-01-06 2:11 ` Stephen Boyd
2021-12-21 9:29 ` Greg Kroah-Hartman
2021-12-21 9:29 ` Greg Kroah-Hartman
2022-01-06 2:17 ` Stephen Boyd
2022-01-06 2:17 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 02/34] component: Remove most references to 'master' Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 03/34] component: Introduce the aggregate bus_type Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 04/34] component: Move struct aggregate_device out to header file Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 05/34] component: Add {bind,unbind}_component() ops that take aggregate device Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 05/34] component: Add {bind, unbind}_component() " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 06/34] drm/of: Add a drm_of_aggregate_probe() API Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 07/34] drm/msm: Migrate to aggregate driver Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 08/34] drm/komeda: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 09/34] drm/arm/hdlcd: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 10/34] drm/malidp: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 11/34] drm/armada: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 12/34] drm/etnaviv: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 13/34] drm/kirin: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 14/34] drm/exynos: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 15/34] drm/imx: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 16/34] drm/ingenic: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 17/34] drm/mcde: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 18/34] drm/mediatek: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 19/34] drm/meson: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 20/34] drm/omap: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 21/34] drm/rockchip: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 22/34] drm/sti: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 23/34] drm/sun4i: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 24/34] drm/tilcdc: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 25/34] drm/vc4: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 26/34] iommu/mtk: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 27/34] mei: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 28/34] power: supply: ab8500: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-03 1:50 ` Linus Walleij
2021-12-03 1:50 ` Linus Walleij
2021-12-02 22:27 ` [PATCH v4 29/34] fbdev: omap2: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 30/34] sound: hdac: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 31/34] ASoC: codecs: wcd938x: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 32/34] mei: pxp: " Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 33/34] component: Get rid of drm_of_component_probe() Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 34/34] component: Remove component_master_ops and friends Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd
2021-12-03 1:51 ` [PATCH v4 00/34] component: Make into an aggregate bus Linus Walleij
2021-12-03 1:51 ` Linus Walleij
2021-12-07 18:22 ` Daniel Vetter
2021-12-07 18:22 ` Daniel Vetter
2021-12-13 21:43 ` Stephen Boyd
2021-12-13 21:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGeKpy/oecKlKZg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=saravanak@google.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.