* [PATCH] ima: silence measurement list hexdump during kexec
@ 2021-12-22 19:16 Bruno Meneguele
2021-12-22 22:13 ` Mimi Zohar
0 siblings, 1 reply; 3+ messages in thread
From: Bruno Meneguele @ 2021-12-22 19:16 UTC (permalink / raw)
To: zohar; +Cc: linux-integrity, linux-kernel, Bruno Meneguele
The measurement list is dumped during a soft reset (kexec) through the call
to "print_hex_dump(KERN_DEBUG, ...)", which ignores the DEBUG build flag.
Instead, use "print_hex_dump_debug(...)", honoring the build flag.
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
---
security/integrity/ima/ima_kexec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
index f799cc278a9a..13753136f03f 100644
--- a/security/integrity/ima/ima_kexec.c
+++ b/security/integrity/ima/ima_kexec.c
@@ -61,9 +61,9 @@ static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer,
}
memcpy(file.buf, &khdr, sizeof(khdr));
- print_hex_dump(KERN_DEBUG, "ima dump: ", DUMP_PREFIX_NONE,
- 16, 1, file.buf,
- file.count < 100 ? file.count : 100, true);
+ print_hex_dump_debug("ima dump: ", DUMP_PREFIX_NONE, 16, 1,
+ file.buf, file.count < 100 ? file.count : 100,
+ true);
*buffer_size = file.count;
*buffer = file.buf;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ima: silence measurement list hexdump during kexec
2021-12-22 19:16 [PATCH] ima: silence measurement list hexdump during kexec Bruno Meneguele
@ 2021-12-22 22:13 ` Mimi Zohar
2021-12-24 13:14 ` Bruno Meneguele
0 siblings, 1 reply; 3+ messages in thread
From: Mimi Zohar @ 2021-12-22 22:13 UTC (permalink / raw)
To: Bruno Meneguele; +Cc: linux-integrity, linux-kernel
Hi Bruno,
On Wed, 2021-12-22 at 16:16 -0300, Bruno Meneguele wrote:
> The measurement list is dumped during a soft reset (kexec) through the call
> to "print_hex_dump(KERN_DEBUG, ...)", which ignores the DEBUG build flag.
> Instead, use "print_hex_dump_debug(...)", honoring the build flag.
>
> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
The patch description needs to at least explain why using
print_hex_dump() isn't sufficent. Look at how print_hex_dump() is
defined. Based on whether CONFIG_DYNAMIC_DEBUG is enabled, different
functions are used.
Mimi
> ---
> security/integrity/ima/ima_kexec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
> index f799cc278a9a..13753136f03f 100644
> --- a/security/integrity/ima/ima_kexec.c
> +++ b/security/integrity/ima/ima_kexec.c
> @@ -61,9 +61,9 @@ static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer,
> }
> memcpy(file.buf, &khdr, sizeof(khdr));
>
> - print_hex_dump(KERN_DEBUG, "ima dump: ", DUMP_PREFIX_NONE,
> - 16, 1, file.buf,
> - file.count < 100 ? file.count : 100, true);
> + print_hex_dump_debug("ima dump: ", DUMP_PREFIX_NONE, 16, 1,
> + file.buf, file.count < 100 ? file.count : 100,
> + true);
>
> *buffer_size = file.count;
> *buffer = file.buf;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ima: silence measurement list hexdump during kexec
2021-12-22 22:13 ` Mimi Zohar
@ 2021-12-24 13:14 ` Bruno Meneguele
0 siblings, 0 replies; 3+ messages in thread
From: Bruno Meneguele @ 2021-12-24 13:14 UTC (permalink / raw)
To: Mimi Zohar; +Cc: linux-integrity, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
On Wed, Dec 22, 2021 at 05:13:56PM -0500, Mimi Zohar wrote:
> Hi Bruno,
>
> On Wed, 2021-12-22 at 16:16 -0300, Bruno Meneguele wrote:
> > The measurement list is dumped during a soft reset (kexec) through the call
> > to "print_hex_dump(KERN_DEBUG, ...)", which ignores the DEBUG build flag.
> > Instead, use "print_hex_dump_debug(...)", honoring the build flag.
> >
> > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
>
> The patch description needs to at least explain why using
> print_hex_dump() isn't sufficent. Look at how print_hex_dump() is
> defined. Based on whether CONFIG_DYNAMIC_DEBUG is enabled, different
> functions are used.
Sending the v2 in a sec :)
Thanks Mimi
>
> Mimi
>
> > ---
> > security/integrity/ima/ima_kexec.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
> > index f799cc278a9a..13753136f03f 100644
> > --- a/security/integrity/ima/ima_kexec.c
> > +++ b/security/integrity/ima/ima_kexec.c
> > @@ -61,9 +61,9 @@ static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer,
> > }
> > memcpy(file.buf, &khdr, sizeof(khdr));
> >
> > - print_hex_dump(KERN_DEBUG, "ima dump: ", DUMP_PREFIX_NONE,
> > - 16, 1, file.buf,
> > - file.count < 100 ? file.count : 100, true);
> > + print_hex_dump_debug("ima dump: ", DUMP_PREFIX_NONE, 16, 1,
> > + file.buf, file.count < 100 ? file.count : 100,
> > + true);
> >
> > *buffer_size = file.count;
> > *buffer = file.buf;
>
>
--
bmeneg
PGP Key: http://bmeneg.com/pubkey.txt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-24 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 19:16 [PATCH] ima: silence measurement list hexdump during kexec Bruno Meneguele
2021-12-22 22:13 ` Mimi Zohar
2021-12-24 13:14 ` Bruno Meneguele
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.