From: Zev Weiss <zev@bewilderbeest.net>
To: Joel Stanley <joel@jms.id.au>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Neil Horman <neil.horman@privafy.com>,
Anthony Jenkins <anthony.jenkins@privafy.com>
Subject: Re: [PATCH] ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC
Date: Tue, 11 Jan 2022 17:14:38 -0800 [thread overview]
Message-ID: <Yd4rfi/iICQ5EjGh@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CACPK8XeHyoo0D1vQm=L8m284kC5n-O+FEMp1HN+ROWJfx7qjhQ@mail.gmail.com>
On Tue, Jan 11, 2022 at 02:59:28AM PST, Joel Stanley wrote:
>On Wed, 5 Jan 2022 at 23:10, Zev Weiss <zev@bewilderbeest.net> wrote:
>>
>> This is a half-width, single-socket Epyc server board with an AST2500
>> BMC. This device tree is sufficient for basic OpenBMC functionality,
>> but we'll need to add a few more devices (as driver support becomes
>> available) before it's fully usable.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>
>Reviewed-by: Joel Stanley <joel@jms.id.au>
>
Thanks!
>Have you considered using the openbmc gpio naming scheme for the
>gpio-line-names?
>
I looked at it, but decided not to for a few reasons:
- For systems that are in the early stages of a porting effort (like
this one currently is), I'm still referring to hardware schematics
fairly often, and using the same identifiers in software that are
used in the schematics simplifies things by avoiding an extra
translation step between the two.
- Most of the GPIO-related userspace components (that I'm dealing with
anyway, e.g. x86-power-control and host-error-monitor) already have
their own GPIO line-name configuration/remapping mechanisms that need
to be set up anyway.
- There's a solid mix of GPIOs that would be covered by the naming
guidelines and others that aren't; having a mix of the two styles
seems a bit awkward to me.
That said, I sympathize with the motivation behind it and I'm not
vehemently opposed on the whole, so if there's a strong preference to
follow that scheme I could probably be talked into changing it.
Zev
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Arnd Bergmann <arnd@arndb.de>, Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Neil Horman <neil.horman@privafy.com>,
Olof Johansson <olof@lixom.net>,
Anthony Jenkins <anthony.jenkins@privafy.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC
Date: Tue, 11 Jan 2022 17:14:38 -0800 [thread overview]
Message-ID: <Yd4rfi/iICQ5EjGh@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CACPK8XeHyoo0D1vQm=L8m284kC5n-O+FEMp1HN+ROWJfx7qjhQ@mail.gmail.com>
On Tue, Jan 11, 2022 at 02:59:28AM PST, Joel Stanley wrote:
>On Wed, 5 Jan 2022 at 23:10, Zev Weiss <zev@bewilderbeest.net> wrote:
>>
>> This is a half-width, single-socket Epyc server board with an AST2500
>> BMC. This device tree is sufficient for basic OpenBMC functionality,
>> but we'll need to add a few more devices (as driver support becomes
>> available) before it's fully usable.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>
>Reviewed-by: Joel Stanley <joel@jms.id.au>
>
Thanks!
>Have you considered using the openbmc gpio naming scheme for the
>gpio-line-names?
>
I looked at it, but decided not to for a few reasons:
- For systems that are in the early stages of a porting effort (like
this one currently is), I'm still referring to hardware schematics
fairly often, and using the same identifiers in software that are
used in the schematics simplifies things by avoiding an extra
translation step between the two.
- Most of the GPIO-related userspace components (that I'm dealing with
anyway, e.g. x86-power-control and host-error-monitor) already have
their own GPIO line-name configuration/remapping mechanisms that need
to be set up anyway.
- There's a solid mix of GPIOs that would be covered by the naming
guidelines and others that aren't; having a mix of the two styles
seems a bit awkward to me.
That said, I sympathize with the motivation behind it and I'm not
vehemently opposed on the whole, so if there's a strong preference to
follow that scheme I could probably be talked into changing it.
Zev
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: Joel Stanley <joel@jms.id.au>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Neil Horman <neil.horman@privafy.com>,
Anthony Jenkins <anthony.jenkins@privafy.com>
Subject: Re: [PATCH] ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC
Date: Tue, 11 Jan 2022 17:14:38 -0800 [thread overview]
Message-ID: <Yd4rfi/iICQ5EjGh@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CACPK8XeHyoo0D1vQm=L8m284kC5n-O+FEMp1HN+ROWJfx7qjhQ@mail.gmail.com>
On Tue, Jan 11, 2022 at 02:59:28AM PST, Joel Stanley wrote:
>On Wed, 5 Jan 2022 at 23:10, Zev Weiss <zev@bewilderbeest.net> wrote:
>>
>> This is a half-width, single-socket Epyc server board with an AST2500
>> BMC. This device tree is sufficient for basic OpenBMC functionality,
>> but we'll need to add a few more devices (as driver support becomes
>> available) before it's fully usable.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>
>Reviewed-by: Joel Stanley <joel@jms.id.au>
>
Thanks!
>Have you considered using the openbmc gpio naming scheme for the
>gpio-line-names?
>
I looked at it, but decided not to for a few reasons:
- For systems that are in the early stages of a porting effort (like
this one currently is), I'm still referring to hardware schematics
fairly often, and using the same identifiers in software that are
used in the schematics simplifies things by avoiding an extra
translation step between the two.
- Most of the GPIO-related userspace components (that I'm dealing with
anyway, e.g. x86-power-control and host-error-monitor) already have
their own GPIO line-name configuration/remapping mechanisms that need
to be set up anyway.
- There's a solid mix of GPIOs that would be covered by the naming
guidelines and others that aren't; having a mix of the two styles
seems a bit awkward to me.
That said, I sympathize with the motivation behind it and I'm not
vehemently opposed on the whole, so if there's a strong preference to
follow that scheme I could probably be talked into changing it.
Zev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-12 1:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 10:17 [PATCH] ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC Zev Weiss
2022-01-05 10:17 ` Zev Weiss
2022-01-05 10:17 ` Zev Weiss
2022-01-11 10:59 ` Joel Stanley
2022-01-11 10:59 ` Joel Stanley
2022-01-11 10:59 ` Joel Stanley
2022-01-12 1:14 ` Zev Weiss [this message]
2022-01-12 1:14 ` Zev Weiss
2022-01-12 1:14 ` Zev Weiss
2022-02-28 5:00 ` Joel Stanley
2022-02-28 5:00 ` Joel Stanley
2022-02-28 5:00 ` Joel Stanley
2022-01-12 1:28 Milton Miller II
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd4rfi/iICQ5EjGh@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=andrew@aj.id.au \
--cc=anthony.jenkins@privafy.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.horman@privafy.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.