From: Mark Brown <broonie@kernel.org>
To: Daniel Beer <daniel.beer@igorinstitute.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Liu <andy-liu@ti.com>,
Derek Simkowiak <derek.simkowiak@igorinstitute.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier
Date: Wed, 12 Jan 2022 20:26:22 +0000 [thread overview]
Message-ID: <Yd85bjKEX9JnoOlI@sirena.org.uk> (raw)
In-Reply-To: <20220111192806.GA10345@nyquist.nev>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Wed, Jan 12, 2022 at 08:28:06AM +1300, Daniel Beer wrote:
> The blob of register writes we get given from PPC3 contains a whole lot
> of explicit page and book changes, and there's not an easy way to tell
> regmap about this, as far as I know. Do you think it's acceptable to
> stick with explicit paging for this reason, or is there a way to make
> this work with regmap's paging?
That's probably fine. It's *really* hard to get enthusiastic about this
system design TBH, just injecting a stream of unverified register writes
is going to make the driver very fragile against changes but I'm not
sure you're going to much better there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Beer <daniel.beer@igorinstitute.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Andy Liu <andy-liu@ti.com>, Rob Herring <robh+dt@kernel.org>,
Derek Simkowiak <derek.simkowiak@igorinstitute.com>
Subject: Re: [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier
Date: Wed, 12 Jan 2022 20:26:22 +0000 [thread overview]
Message-ID: <Yd85bjKEX9JnoOlI@sirena.org.uk> (raw)
In-Reply-To: <20220111192806.GA10345@nyquist.nev>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Wed, Jan 12, 2022 at 08:28:06AM +1300, Daniel Beer wrote:
> The blob of register writes we get given from PPC3 contains a whole lot
> of explicit page and book changes, and there's not an easy way to tell
> regmap about this, as far as I know. Do you think it's acceptable to
> stick with explicit paging for this reason, or is there a way to make
> this work with regmap's paging?
That's probably fine. It's *really* hard to get enthusiastic about this
system design TBH, just injecting a stream of unverified register writes
is going to make the driver very fragile against changes but I'm not
sure you're going to much better there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-12 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 23:53 [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier Daniel Beer
2022-01-10 23:53 ` Daniel Beer
2022-01-11 17:13 ` Mark Brown
2022-01-11 17:13 ` Mark Brown
2022-01-11 19:28 ` Daniel Beer
2022-01-11 19:28 ` Daniel Beer
2022-01-12 20:26 ` Mark Brown [this message]
2022-01-12 20:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd85bjKEX9JnoOlI@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy-liu@ti.com \
--cc=daniel.beer@igorinstitute.com \
--cc=derek.simkowiak@igorinstitute.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.