All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Henry Kleynhans <henry.kleynhans@gmail.com>
Cc: Henry Kleynhans <hkleynhans@fb.com>,
	qemu-devel@nongnu.org, henry.kleynhans@fb.com
Subject: Re: [PATCH 1/2] [crypto] Load all certificates in X509 CA file
Date: Tue, 4 Jan 2022 18:30:04 +0000	[thread overview]
Message-ID: <YdSSLEA2njdoNEZg@redhat.com> (raw)
In-Reply-To: <20211222150600.37677-1-henry.kleynhans@gmail.com>

On Wed, Dec 22, 2021 at 03:05:59PM +0000, Henry Kleynhans wrote:
> From: Henry Kleynhans <hkleynhans@fb.com>
> 
> Some CA files may contain multiple intermediaries and roots of trust.
> These may not fit into the hard-coded limit of 16.
> 
> Extend the validation code to allocate enough space to load all of the
> certificates present in the CA file and ensure they are cleaned up.
> 
> Signed-off-by: Henry Kleynhans <hkleynhans@fb.com>
> ---
>  crypto/tlscredsx509.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      parent reply	other threads:[~2022-01-04 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 15:05 [PATCH 1/2] [crypto] Load all certificates in X509 CA file Henry Kleynhans
2021-12-22 15:06 ` [PATCH 2/2] [crypto] Only verify CA certs in chain of trust Henry Kleynhans
2021-12-22 15:54   ` Henry Kleynhans
2022-01-04 18:42     ` Daniel P. Berrangé
2022-01-04 18:44   ` Daniel P. Berrangé
2022-01-04 18:30 ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdSSLEA2njdoNEZg@redhat.com \
    --to=berrange@redhat.com \
    --cc=henry.kleynhans@fb.com \
    --cc=henry.kleynhans@gmail.com \
    --cc=hkleynhans@fb.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.