From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Henry Kleynhans <hkleynhans@fb.com>
Cc: Henry Kleynhans <henry.kleynhans@gmail.com>,
"henry.kleynhans@fb.com" <henry.kleynhans@fb.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] [crypto] Only verify CA certs in chain of trust
Date: Tue, 4 Jan 2022 18:42:13 +0000 [thread overview]
Message-ID: <YdSVBbt0gqvoYvpj@redhat.com> (raw)
In-Reply-To: <BY5PR15MB3572B35B9EEFE823B9F1270FB87D9@BY5PR15MB3572.namprd15.prod.outlook.com>
On Wed, Dec 22, 2021 at 03:54:08PM +0000, Henry Kleynhans wrote:
> Hi Daniel,
>
> This patch tightens the CA verification code to only check the
> issuer chain of the client cert. I think this will still not
> catch expired/invalid certs if the client and server certs have
> different issuer chains; so maybe this too is not quite the
> correct fix. Let me know what you think.
Different issuer chains is not going to be very common/typical.
So what you've done in this patch is at least pretty decent for
the common case, so will catch most user's mistakes. Let me have
a think about whether we can do anything better without making
the code too painful
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-01-04 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 15:05 [PATCH 1/2] [crypto] Load all certificates in X509 CA file Henry Kleynhans
2021-12-22 15:06 ` [PATCH 2/2] [crypto] Only verify CA certs in chain of trust Henry Kleynhans
2021-12-22 15:54 ` Henry Kleynhans
2022-01-04 18:42 ` Daniel P. Berrangé [this message]
2022-01-04 18:44 ` Daniel P. Berrangé
2022-01-04 18:30 ` [PATCH 1/2] [crypto] Load all certificates in X509 CA file Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdSVBbt0gqvoYvpj@redhat.com \
--to=berrange@redhat.com \
--cc=henry.kleynhans@fb.com \
--cc=henry.kleynhans@gmail.com \
--cc=hkleynhans@fb.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.