* [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
@ 2021-12-23 18:17 Florian Fainelli
2021-12-23 19:31 ` Andrew Lunn
2021-12-26 3:29 ` Linus Walleij
0 siblings, 2 replies; 6+ messages in thread
From: Florian Fainelli @ 2021-12-23 18:17 UTC (permalink / raw)
To: devicetree
Cc: Arnd Bergmann, Olof Johansson, Arınç ÜNAL,
Florian Fainelli, Stephen Rothwell, Linus Walleij, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
Rob Herring, open list:NETWORKING DRIVERS, open list
The 'ports' node is not supposed to have a 'reg' property at all, in
fact, doing so will lead to dtc issuing warnings looking like these:
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
Fix the example by remove the stray 'reg' property.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/dsa/realtek-smi.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
index 7959ec237983..a8d0f1febe32 100644
--- a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
+++ b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
@@ -84,7 +84,6 @@ switch {
ports {
#address-cells = <1>;
#size-cells = <0>;
- reg = <0>;
port@0 {
reg = <0>;
label = "lan0";
@@ -174,7 +173,7 @@ switch {
ports {
#address-cells = <1>;
#size-cells = <0>;
- reg = <0>;
+
port@0 {
reg = <0>;
label = "swp0";
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
2021-12-23 18:17 [PATCH] dt-bindings: net: dsa: Fix realtek-smi example Florian Fainelli
@ 2021-12-23 19:31 ` Andrew Lunn
2021-12-26 3:29 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2021-12-23 19:31 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Arnd Bergmann, Olof Johansson,
Arınç ÜNAL, Stephen Rothwell, Linus Walleij,
Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
Rob Herring, open list:NETWORKING DRIVERS, open list
On Thu, Dec 23, 2021 at 10:17:41AM -0800, Florian Fainelli wrote:
> The 'ports' node is not supposed to have a 'reg' property at all, in
> fact, doing so will lead to dtc issuing warnings looking like these:
>
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
>
> Fix the example by remove the stray 'reg' property.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
2021-12-23 18:17 [PATCH] dt-bindings: net: dsa: Fix realtek-smi example Florian Fainelli
2021-12-23 19:31 ` Andrew Lunn
@ 2021-12-26 3:29 ` Linus Walleij
2021-12-27 11:24 ` Luiz Angelo Daros de Luca
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2021-12-26 3:29 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Arnd Bergmann, Olof Johansson,
Arınç ÜNAL, Stephen Rothwell, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
Rob Herring, open list:NETWORKING DRIVERS, open list
On Thu, Dec 23, 2021 at 7:17 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> The 'ports' node is not supposed to have a 'reg' property at all, in
> fact, doing so will lead to dtc issuing warnings looking like these:
>
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
>
> Fix the example by remove the stray 'reg' property.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Ooops thanks for fixing this! (Wouldn't happen if we converted
it to YAML...)
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
2021-12-26 3:29 ` Linus Walleij
@ 2021-12-27 11:24 ` Luiz Angelo Daros de Luca
2022-01-04 20:19 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Angelo Daros de Luca @ 2021-12-27 11:24 UTC (permalink / raw)
To: Linus Walleij
Cc: Florian Fainelli, devicetree, Arnd Bergmann, Olof Johansson,
Arınç ÜNAL, Stephen Rothwell, Andrew Lunn,
Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
Rob Herring, open list:NETWORKING DRIVERS, open list
> Ooops thanks for fixing this! (Wouldn't happen if we converted
> it to YAML...)
I'm working on it. I might post it in a couple of days.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
2021-12-27 11:24 ` Luiz Angelo Daros de Luca
@ 2022-01-04 20:19 ` Rob Herring
2022-01-05 0:12 ` Luiz Angelo Daros de Luca
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-01-04 20:19 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: Linus Walleij, Florian Fainelli, devicetree, Arnd Bergmann,
Olof Johansson, Arınç ÜNAL, Stephen Rothwell,
Andrew Lunn, Vivien Didelot, Vladimir Oltean, David S. Miller,
Jakub Kicinski, open list:NETWORKING DRIVERS, open list
On Mon, Dec 27, 2021 at 08:24:05AM -0300, Luiz Angelo Daros de Luca wrote:
> > Ooops thanks for fixing this! (Wouldn't happen if we converted
> > it to YAML...)
>
> I'm working on it. I might post it in a couple of days.
Then just fix this in the conversion.
>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Yours,
> > Linus Walleij
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example
2022-01-04 20:19 ` Rob Herring
@ 2022-01-05 0:12 ` Luiz Angelo Daros de Luca
0 siblings, 0 replies; 6+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-01-05 0:12 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Florian Fainelli, devicetree, Arnd Bergmann,
Olof Johansson, Arınç ÜNAL, Stephen Rothwell,
Andrew Lunn, Vivien Didelot, Vladimir Oltean, David S. Miller,
Jakub Kicinski, open list:NETWORKING DRIVERS, open list
> Then just fix this in the conversion.
Hi Rob,
I'm not sure if I got your suggestion. Should I post the new patch
in-reply to this thread?
It is related but something completely different.
I sent YAML conversion v1 a little while ago.
https://lore.kernel.org/netdev/20211228072645.32341-1-luizluca@gmail.com/
I'll send v2 soon. I'll mention it in this thread when I do it.
Best,
Luiz
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-05 0:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 18:17 [PATCH] dt-bindings: net: dsa: Fix realtek-smi example Florian Fainelli
2021-12-23 19:31 ` Andrew Lunn
2021-12-26 3:29 ` Linus Walleij
2021-12-27 11:24 ` Luiz Angelo Daros de Luca
2022-01-04 20:19 ` Rob Herring
2022-01-05 0:12 ` Luiz Angelo Daros de Luca
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.