From: Mike Snitzer <snitzer@redhat.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-kernel@vger.kernel.org, Alasdair Kergon <agk@redhat.com>, dm-devel@redhat.com Subject: Re: dm sysfs: use default_groups in kobj_type Date: Thu, 6 Jan 2022 09:25:11 -0500 [thread overview] Message-ID: <Ydb7xzmOC8VN8miQ@redhat.com> (raw) In-Reply-To: <20220106100231.3278554-1-gregkh@linuxfoundation.org> On Thu, Jan 06 2022 at 5:02P -0500, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the dm sysfs code to use default_groups field which has > been the preferred way since aa30f47cf666 ("kobject: Add support for > default attribute groups to kobj_type") so that we can soon get rid of > the obsolete default_attrs field. > > Cc: Alasdair Kergon <agk@redhat.com> > Cc: Mike Snitzer <snitzer@redhat.com> > Cc: dm-devel@redhat.com > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/md/dm-sysfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/dm-sysfs.c b/drivers/md/dm-sysfs.c > index a05fcd50e1b9..e28c92478536 100644 > --- a/drivers/md/dm-sysfs.c > +++ b/drivers/md/dm-sysfs.c > @@ -112,6 +112,7 @@ static struct attribute *dm_attrs[] = { > &dm_attr_rq_based_seq_io_merge_deadline.attr, > NULL, > }; > +ATTRIBUTE_GROUPS(dm); Bit strange to pass "dm" but then have ATTRIBUTE_GROUPS assume dm_attrs defined. Feels like it'll invite janitors sending patches, that they never compile, to remove dm_attrs. > > static const struct sysfs_ops dm_sysfs_ops = { > .show = dm_attr_show, > @@ -120,7 +121,7 @@ static const struct sysfs_ops dm_sysfs_ops = { > > static struct kobj_type dm_ktype = { > .sysfs_ops = &dm_sysfs_ops, > - .default_attrs = dm_attrs, > + .default_groups = dm_groups, > .release = dm_kobject_release, > }; > > -- > 2.34.1 > But I've picked this patch up for 5.17. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Alasdair Kergon <agk@redhat.com> Subject: Re: [dm-devel] dm sysfs: use default_groups in kobj_type Date: Thu, 6 Jan 2022 09:25:11 -0500 [thread overview] Message-ID: <Ydb7xzmOC8VN8miQ@redhat.com> (raw) In-Reply-To: <20220106100231.3278554-1-gregkh@linuxfoundation.org> On Thu, Jan 06 2022 at 5:02P -0500, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the dm sysfs code to use default_groups field which has > been the preferred way since aa30f47cf666 ("kobject: Add support for > default attribute groups to kobj_type") so that we can soon get rid of > the obsolete default_attrs field. > > Cc: Alasdair Kergon <agk@redhat.com> > Cc: Mike Snitzer <snitzer@redhat.com> > Cc: dm-devel@redhat.com > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/md/dm-sysfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/dm-sysfs.c b/drivers/md/dm-sysfs.c > index a05fcd50e1b9..e28c92478536 100644 > --- a/drivers/md/dm-sysfs.c > +++ b/drivers/md/dm-sysfs.c > @@ -112,6 +112,7 @@ static struct attribute *dm_attrs[] = { > &dm_attr_rq_based_seq_io_merge_deadline.attr, > NULL, > }; > +ATTRIBUTE_GROUPS(dm); Bit strange to pass "dm" but then have ATTRIBUTE_GROUPS assume dm_attrs defined. Feels like it'll invite janitors sending patches, that they never compile, to remove dm_attrs. > > static const struct sysfs_ops dm_sysfs_ops = { > .show = dm_attr_show, > @@ -120,7 +121,7 @@ static const struct sysfs_ops dm_sysfs_ops = { > > static struct kobj_type dm_ktype = { > .sysfs_ops = &dm_sysfs_ops, > - .default_attrs = dm_attrs, > + .default_groups = dm_groups, > .release = dm_kobject_release, > }; > > -- > 2.34.1 > But I've picked this patch up for 5.17. Thanks. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-01-06 14:25 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-06 10:02 [PATCH] dm sysfs: use default_groups in kobj_type Greg Kroah-Hartman 2022-01-06 10:02 ` [dm-devel] " Greg Kroah-Hartman 2022-01-06 14:25 ` Mike Snitzer [this message] 2022-01-06 14:25 ` [dm-devel] " Mike Snitzer 2022-01-06 15:04 ` Greg Kroah-Hartman 2022-01-06 15:04 ` [dm-devel] " Greg Kroah-Hartman 2022-01-06 15:20 ` Mike Snitzer 2022-01-06 15:20 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Ydb7xzmOC8VN8miQ@redhat.com \ --to=snitzer@redhat.com \ --cc=agk@redhat.com \ --cc=dm-devel@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.