All of lore.kernel.org
 help / color / mirror / Atom feed
* [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'?
@ 2022-01-08 19:04 ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-08 19:04 UTC (permalink / raw)
  To: Lama Kayal; +Cc: kbuild-all, netdev, Saeed Mahameed, Gal Pressman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   82192cb497f9eca6c0d44dbc173e68d59ea2f3c9
commit: 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e [59/127] net/mlx5e: Expose FEC counters via ethtool
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220109/202201090211.3kpW0hGj-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch --no-tags net-next master
        git checkout 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
>> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
         |                                                ^~~~
         |                                                out
   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: note: each undeclared identifier is reported only once for each function it appears in


vim +1235 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

  1220	
  1221	static void fec_set_block_stats(struct mlx5e_priv *priv,
  1222					struct ethtool_fec_stats *fec_stats)
  1223	{
  1224		struct mlx5_core_dev *mdev = priv->mdev;
  1225		u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
  1226		u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
  1227		int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
  1228		int mode = fec_active_mode(mdev);
  1229	
  1230		if (mode == MLX5E_FEC_NOFEC)
  1231			return;
  1232	
  1233		MLX5_SET(ppcnt_reg, in, local_port, 1);
  1234		MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> 1235		if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
  1236			return;
  1237	
  1238		switch (mode) {
  1239		case MLX5E_FEC_RS_528_514:
  1240		case MLX5E_FEC_RS_544_514:
  1241		case MLX5E_FEC_LLRS_272_257_1:
  1242			fec_set_rs_stats(fec_stats, out);
  1243			return;
  1244		case MLX5E_FEC_FIRECODE:
  1245			fec_set_fc_stats(fec_stats, out, fec_num_lanes(mdev));
  1246		}
  1247	}
  1248	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'?
@ 2022-01-08 19:04 ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-01-08 19:04 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3050 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   82192cb497f9eca6c0d44dbc173e68d59ea2f3c9
commit: 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e [59/127] net/mlx5e: Expose FEC counters via ethtool
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220109/202201090211.3kpW0hGj-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch --no-tags net-next master
        git checkout 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
>> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
         |                                                ^~~~
         |                                                out
   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: note: each undeclared identifier is reported only once for each function it appears in


vim +1235 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

  1220	
  1221	static void fec_set_block_stats(struct mlx5e_priv *priv,
  1222					struct ethtool_fec_stats *fec_stats)
  1223	{
  1224		struct mlx5_core_dev *mdev = priv->mdev;
  1225		u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
  1226		u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
  1227		int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
  1228		int mode = fec_active_mode(mdev);
  1229	
  1230		if (mode == MLX5E_FEC_NOFEC)
  1231			return;
  1232	
  1233		MLX5_SET(ppcnt_reg, in, local_port, 1);
  1234		MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> 1235		if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
  1236			return;
  1237	
  1238		switch (mode) {
  1239		case MLX5E_FEC_RS_528_514:
  1240		case MLX5E_FEC_RS_544_514:
  1241		case MLX5E_FEC_LLRS_272_257_1:
  1242			fec_set_rs_stats(fec_stats, out);
  1243			return;
  1244		case MLX5E_FEC_FIRECODE:
  1245			fec_set_fc_stats(fec_stats, out, fec_num_lanes(mdev));
  1246		}
  1247	}
  1248	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'?
  2022-01-08 19:04 ` kernel test robot
@ 2022-01-09  9:35   ` Leon Romanovsky
  -1 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2022-01-09  9:35 UTC (permalink / raw)
  To: kernel test robot
  Cc: Lama Kayal, kbuild-all, netdev, Saeed Mahameed, Gal Pressman

On Sun, Jan 09, 2022 at 03:04:48AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   82192cb497f9eca6c0d44dbc173e68d59ea2f3c9
> commit: 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e [59/127] net/mlx5e: Expose FEC counters via ethtool
> config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220109/202201090211.3kpW0hGj-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
>         git fetch --no-tags net-next master
>         git checkout 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> >> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
>     1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
>          |                                                ^~~~
>          |                                                out
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: note: each undeclared identifier is reported only once for each function it appears in
> 
> 
> vim +1235 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> 
>   1220	
>   1221	static void fec_set_block_stats(struct mlx5e_priv *priv,
>   1222					struct ethtool_fec_stats *fec_stats)
>   1223	{
>   1224		struct mlx5_core_dev *mdev = priv->mdev;
>   1225		u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1226		u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1227		int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
>   1228		int mode = fec_active_mode(mdev);
>   1229	
>   1230		if (mode == MLX5E_FEC_NOFEC)
>   1231			return;
>   1232	
>   1233		MLX5_SET(ppcnt_reg, in, local_port, 1);
>   1234		MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> > 1235		if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))

Obviously, this should be "out" and not "outl".

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 7e7c0c1019f6..26e326fe503c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1232,7 +1232,7 @@ static void fec_set_block_stats(struct mlx5e_priv *priv,

        MLX5_SET(ppcnt_reg, in, local_port, 1);
        MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
-       if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
+       if (mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_PPCNT, 0, 0))
                return;

        switch (mode) {


>   1236			return;
>   1237	
>   1238		switch (mode) {
>   1239		case MLX5E_FEC_RS_528_514:
>   1240		case MLX5E_FEC_RS_544_514:
>   1241		case MLX5E_FEC_LLRS_272_257_1:
>   1242			fec_set_rs_stats(fec_stats, out);
>   1243			return;
>   1244		case MLX5E_FEC_FIRECODE:
>   1245			fec_set_fc_stats(fec_stats, out, fec_num_lanes(mdev));
>   1246		}
>   1247	}
>   1248	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'?
@ 2022-01-09  9:35   ` Leon Romanovsky
  0 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2022-01-09  9:35 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3997 bytes --]

On Sun, Jan 09, 2022 at 03:04:48AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   82192cb497f9eca6c0d44dbc173e68d59ea2f3c9
> commit: 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e [59/127] net/mlx5e: Expose FEC counters via ethtool
> config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220109/202201090211.3kpW0hGj-lkp(a)intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
>         git fetch --no-tags net-next master
>         git checkout 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> >> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
>     1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
>          |                                                ^~~~
>          |                                                out
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: note: each undeclared identifier is reported only once for each function it appears in
> 
> 
> vim +1235 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> 
>   1220	
>   1221	static void fec_set_block_stats(struct mlx5e_priv *priv,
>   1222					struct ethtool_fec_stats *fec_stats)
>   1223	{
>   1224		struct mlx5_core_dev *mdev = priv->mdev;
>   1225		u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1226		u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1227		int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
>   1228		int mode = fec_active_mode(mdev);
>   1229	
>   1230		if (mode == MLX5E_FEC_NOFEC)
>   1231			return;
>   1232	
>   1233		MLX5_SET(ppcnt_reg, in, local_port, 1);
>   1234		MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> > 1235		if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))

Obviously, this should be "out" and not "outl".

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 7e7c0c1019f6..26e326fe503c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1232,7 +1232,7 @@ static void fec_set_block_stats(struct mlx5e_priv *priv,

        MLX5_SET(ppcnt_reg, in, local_port, 1);
        MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
-       if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
+       if (mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_PPCNT, 0, 0))
                return;

        switch (mode) {


>   1236			return;
>   1237	
>   1238		switch (mode) {
>   1239		case MLX5E_FEC_RS_528_514:
>   1240		case MLX5E_FEC_RS_544_514:
>   1241		case MLX5E_FEC_LLRS_272_257_1:
>   1242			fec_set_rs_stats(fec_stats, out);
>   1243			return;
>   1244		case MLX5E_FEC_FIRECODE:
>   1245			fec_set_fc_stats(fec_stats, out, fec_num_lanes(mdev));
>   1246		}
>   1247	}
>   1248	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats()
  2022-01-09  9:35   ` Leon Romanovsky
  (?)
@ 2022-01-09 21:33   ` Jakub Kicinski
  2022-01-10  0:50     ` patchwork-bot+netdevbpf
  2022-01-10 20:33     ` Saeed Mahameed
  -1 siblings, 2 replies; 8+ messages in thread
From: Jakub Kicinski @ 2022-01-09 21:33 UTC (permalink / raw)
  To: davem
  Cc: netdev, saeedm, leonro, Jakub Kicinski, kernel test robot,
	Leon Romanovsky

Build bot reports:

drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
         |                                                ^~~~
         |                                                out

Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 7e7c0c1019f6..26e326fe503c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1232,7 +1232,7 @@ static void fec_set_block_stats(struct mlx5e_priv *priv,
 
 	MLX5_SET(ppcnt_reg, in, local_port, 1);
 	MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
-	if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
+	if (mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_PPCNT, 0, 0))
 		return;
 
 	switch (mode) {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats()
  2022-01-09 21:33   ` [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats() Jakub Kicinski
@ 2022-01-10  0:50     ` patchwork-bot+netdevbpf
  2022-01-10 20:33     ` Saeed Mahameed
  1 sibling, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-10  0:50 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: davem, netdev, saeedm, leonro, lkp, leon

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun,  9 Jan 2022 13:33:21 -0800 you wrote:
> Build bot reports:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
>     1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
>          |                                                ^~~~
>          |                                                out
> 
> [...]

Here is the summary with links:
  - [net-next] net/mlx5e: Fix build error in fec_set_block_stats()
    https://git.kernel.org/netdev/net-next/c/342402c42690

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats()
  2022-01-09 21:33   ` [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats() Jakub Kicinski
  2022-01-10  0:50     ` patchwork-bot+netdevbpf
@ 2022-01-10 20:33     ` Saeed Mahameed
  2022-01-10 20:42       ` Jakub Kicinski
  1 sibling, 1 reply; 8+ messages in thread
From: Saeed Mahameed @ 2022-01-10 20:33 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, saeedm, leonro, kernel test robot, Leon Romanovsky

On Sun, Jan 09, 2022 at 01:33:21PM -0800, Jakub Kicinski wrote:
>Build bot reports:
>
>drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
>drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
>    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
>         |                                                ^~~~
>         |                                                out
>
>Reported-by: kernel test robot <lkp@intel.com>
>Suggested-by: Leon Romanovsky <leon@kernel.org>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Thanks For handling ! I have no clue how this happened.
I will check and improve my process, I Know I've manually changed a patch
before submission, but i am sure i did it through my normal process.

Interestingly the series passed netdev/build_allmodconfig_warn.      
https://patchwork.kernel.org/project/netdevbpf/patch/20220107002956.74849-9-saeed@kernel.org/



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats()
  2022-01-10 20:33     ` Saeed Mahameed
@ 2022-01-10 20:42       ` Jakub Kicinski
  0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2022-01-10 20:42 UTC (permalink / raw)
  To: Saeed Mahameed
  Cc: davem, netdev, saeedm, leonro, kernel test robot, Leon Romanovsky

On Mon, 10 Jan 2022 12:33:54 -0800 Saeed Mahameed wrote:
> On Sun, Jan 09, 2022 at 01:33:21PM -0800, Jakub Kicinski wrote:
> >Build bot reports:
> >
> >drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> >drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
> >    1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
> >         |                                                ^~~~
> >         |                                                out
> >
> >Reported-by: kernel test robot <lkp@intel.com>
> >Suggested-by: Leon Romanovsky <leon@kernel.org>
> >Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> Thanks For handling ! I have no clue how this happened.
> I will check and improve my process, I Know I've manually changed a patch
> before submission, but i am sure i did it through my normal process.
> 
> Interestingly the series passed netdev/build_allmodconfig_warn.      
> https://patchwork.kernel.org/project/netdevbpf/patch/20220107002956.74849-9-saeed@kernel.org/

And it built just fine for me as well with allmodconfig.

LMK if you figure out why, that's really strange.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-01-10 20:42 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-08 19:04 [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'? kernel test robot
2022-01-08 19:04 ` kernel test robot
2022-01-09  9:35 ` Leon Romanovsky
2022-01-09  9:35   ` Leon Romanovsky
2022-01-09 21:33   ` [PATCH net-next] net/mlx5e: Fix build error in fec_set_block_stats() Jakub Kicinski
2022-01-10  0:50     ` patchwork-bot+netdevbpf
2022-01-10 20:33     ` Saeed Mahameed
2022-01-10 20:42       ` Jakub Kicinski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.