* [PATCH 1/1] RDMA/irdma: Remove the redundant return
@ 2022-01-10 7:37 yanjun.zhu
2022-01-09 18:44 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: yanjun.zhu @ 2022-01-10 7:37 UTC (permalink / raw)
To: mustafa.ismail, shiraz.saleem, jgg, linux-rdma, yanjun.zhu
From: Zhu Yanjun <yanjun.zhu@linux.dev>
The type of the function i40iw_remove is void. So remove
the unnecessary return.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c
index d219f64b2c3d..43e962b97d6a 100644
--- a/drivers/infiniband/hw/irdma/i40iw_if.c
+++ b/drivers/infiniband/hw/irdma/i40iw_if.c
@@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev)
aux_dev);
struct i40e_info *cdev_info = i40e_adev->ldev;
- return i40e_client_device_unregister(cdev_info);
+ i40e_client_device_unregister(cdev_info);
}
static const struct auxiliary_device_id i40iw_auxiliary_id_table[] = {
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] RDMA/irdma: Remove the redundant return
2022-01-10 7:37 [PATCH 1/1] RDMA/irdma: Remove the redundant return yanjun.zhu
@ 2022-01-09 18:44 ` Leon Romanovsky
2022-01-10 12:54 ` Jason Gunthorpe
2022-01-10 13:25 ` Saleem, Shiraz
2022-01-10 16:49 ` Jason Gunthorpe
2 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2022-01-09 18:44 UTC (permalink / raw)
To: yanjun.zhu; +Cc: mustafa.ismail, shiraz.saleem, jgg, linux-rdma
On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The type of the function i40iw_remove is void. So remove
> the unnecessary return.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c
> index d219f64b2c3d..43e962b97d6a 100644
> --- a/drivers/infiniband/hw/irdma/i40iw_if.c
> +++ b/drivers/infiniband/hw/irdma/i40iw_if.c
> @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev)
> aux_dev);
> struct i40e_info *cdev_info = i40e_adev->ldev;
>
> - return i40e_client_device_unregister(cdev_info);
> + i40e_client_device_unregister(cdev_info);
I'm surprised that compiler didn't warn about extra parameter to return.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: Remove the redundant return
2022-01-09 18:44 ` Leon Romanovsky
@ 2022-01-10 12:54 ` Jason Gunthorpe
2022-01-10 13:03 ` Leon Romanovsky
0 siblings, 1 reply; 6+ messages in thread
From: Jason Gunthorpe @ 2022-01-10 12:54 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: yanjun.zhu, mustafa.ismail, shiraz.saleem, linux-rdma
On Sun, Jan 09, 2022 at 08:44:55PM +0200, Leon Romanovsky wrote:
> On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote:
> > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> >
> > The type of the function i40iw_remove is void. So remove
> > the unnecessary return.
> >
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c
> > index d219f64b2c3d..43e962b97d6a 100644
> > +++ b/drivers/infiniband/hw/irdma/i40iw_if.c
> > @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev)
> > aux_dev);
> > struct i40e_info *cdev_info = i40e_adev->ldev;
> >
> > - return i40e_client_device_unregister(cdev_info);
> > + i40e_client_device_unregister(cdev_info);
>
> I'm surprised that compiler didn't warn about extra parameter to return.
It is odd, but valid, C to return void like this..
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: Remove the redundant return
2022-01-10 12:54 ` Jason Gunthorpe
@ 2022-01-10 13:03 ` Leon Romanovsky
0 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2022-01-10 13:03 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: yanjun.zhu, mustafa.ismail, shiraz.saleem, linux-rdma
On Mon, Jan 10, 2022 at 08:54:07AM -0400, Jason Gunthorpe wrote:
> On Sun, Jan 09, 2022 at 08:44:55PM +0200, Leon Romanovsky wrote:
> > On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote:
> > > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> > >
> > > The type of the function i40iw_remove is void. So remove
> > > the unnecessary return.
> > >
> > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> > > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c
> > > index d219f64b2c3d..43e962b97d6a 100644
> > > +++ b/drivers/infiniband/hw/irdma/i40iw_if.c
> > > @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev)
> > > aux_dev);
> > > struct i40e_info *cdev_info = i40e_adev->ldev;
> > >
> > > - return i40e_client_device_unregister(cdev_info);
> > > + i40e_client_device_unregister(cdev_info);
> >
> > I'm surprised that compiler didn't warn about extra parameter to return.
>
> It is odd, but valid, C to return void like this..
Any idea where such C expression can be useful?
Thanks
>
> Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] RDMA/irdma: Remove the redundant return
2022-01-10 7:37 [PATCH 1/1] RDMA/irdma: Remove the redundant return yanjun.zhu
2022-01-09 18:44 ` Leon Romanovsky
@ 2022-01-10 13:25 ` Saleem, Shiraz
2022-01-10 16:49 ` Jason Gunthorpe
2 siblings, 0 replies; 6+ messages in thread
From: Saleem, Shiraz @ 2022-01-10 13:25 UTC (permalink / raw)
To: yanjun.zhu, Ismail, Mustafa, jgg, linux-rdma
> Subject: [PATCH 1/1] RDMA/irdma: Remove the redundant return
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The type of the function i40iw_remove is void. So remove the unnecessary return.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: Remove the redundant return
2022-01-10 7:37 [PATCH 1/1] RDMA/irdma: Remove the redundant return yanjun.zhu
2022-01-09 18:44 ` Leon Romanovsky
2022-01-10 13:25 ` Saleem, Shiraz
@ 2022-01-10 16:49 ` Jason Gunthorpe
2 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2022-01-10 16:49 UTC (permalink / raw)
To: yanjun.zhu; +Cc: mustafa.ismail, shiraz.saleem, linux-rdma
On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The type of the function i40iw_remove is void. So remove
> the unnecessary return.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/i40iw_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-10 16:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 7:37 [PATCH 1/1] RDMA/irdma: Remove the redundant return yanjun.zhu
2022-01-09 18:44 ` Leon Romanovsky
2022-01-10 12:54 ` Jason Gunthorpe
2022-01-10 13:03 ` Leon Romanovsky
2022-01-10 13:25 ` Saleem, Shiraz
2022-01-10 16:49 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.