All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Joakim Zhang <qiangqing.zhang@nxp.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable.
Date: Mon, 24 Jan 2022 10:28:23 +0100	[thread overview]
Message-ID: <Ye5xN6sQvsfX1lmn@localhost> (raw)
In-Reply-To: <20220121152820.GA15600@hoboy.vegasvil.org>

On Fri, Jan 21, 2022 at 07:28:20AM -0800, Richard Cochran wrote:
> On Fri, Jan 21, 2022 at 02:50:36PM +0000, Vladimir Oltean wrote:
> > So as I mentioned earlier, the use case would be hardware performance
> > testing and diagnosing. You may consider that as not that important, but
> > this is basically what I had to do for several months, and even wrote
> > a program for that, that collects packet timestamps at all possible points.
> 
> This is not possible without making a brand new CMSG to accommodate
> time stamps from all the various layers.

FWIW, scm_timestamping has three fields and the middle one no longer
seems to be used. If a new socket/timestamping option enabled all
three (SW, MAC, PHY) timestamps in the cmsg, I think that would be a
nice feature.

There are applications that receive both SW and HW timestamps in order
to fall back to SW when a HW timestamp glitched or is missing. This
could be extended to three levels with MAC and PHY timestamps.

> That is completely out of scope for this series.
> 
> The only practical use case of this series is to switch from PHY back to MAC.

From an admin point of view, it makes sense to me to have an option to
disable PHY timestamps for the whole device if there are issues with
it. For debugging and applications, it would be nice to have an option
to get all of them at the same time.

-- 
Miroslav Lichvar


  parent reply	other threads:[~2022-01-24  9:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 23:25 [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable Richard Cochran
2022-01-03 23:53 ` Russell King (Oracle)
2022-01-04  1:42   ` Richard Cochran
2022-04-04 15:05     ` Michael Walle
2022-04-04 15:20       ` Andrew Lunn
2022-04-04 17:12         ` Michael Walle
2022-04-05  5:59           ` Richard Cochran
2022-04-05  8:48             ` Michael Walle
2022-04-05 15:46               ` Richard Cochran
2022-04-05  9:01           ` Kurt Kanzenbach
2022-04-05  9:19             ` Michael Walle
2022-04-05 11:19               ` Kurt Kanzenbach
2022-04-05 13:15                 ` Grygorii Strashko
2022-04-05 13:29                   ` Andrew Lunn
2022-04-05 15:48                     ` Richard Cochran
2022-04-06 11:18                       ` Grygorii Strashko
2022-01-04  6:29 ` kernel test robot
2022-01-04  6:50 ` kernel test robot
2022-01-20 16:48 ` Vladimir Oltean
2022-01-21  3:38   ` Andrew Lunn
2022-01-21  4:05     ` Richard Cochran
2022-01-21 14:50       ` Vladimir Oltean
2022-01-21 15:28         ` Richard Cochran
2022-01-21 16:23           ` Vladimir Oltean
2022-01-22  2:08             ` Richard Cochran
2022-01-24  9:28           ` Miroslav Lichvar [this message]
2022-01-24 15:37             ` Richard Cochran
2022-01-25 15:37               ` Vladimir Oltean
2022-01-21 11:05   ` Kurt Kanzenbach
2022-01-21 15:31     ` Richard Cochran
2022-01-10 15:46 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye5xN6sQvsfX1lmn@localhost \
    --to=mlichvar@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    --cc=richardcochran@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.