* [PATCH] generic/273: use _get_file_block_size
@ 2022-01-24 18:37 Darrick J. Wong
2022-01-24 23:21 ` Leah Rumancik
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2022-01-24 18:37 UTC (permalink / raw)
To: Leah Rumancik, Eryu Guan; +Cc: fstests, xfs
From: Darrick J. Wong <djwong@kernel.org>
This test calculates the amount of free space on a filesystem and uses
the block size to spread the work of filling the free space among a
bunch of threads. Unfortunately, the test /should/ be using the
allocation unit size, not the fs block size, which is why this test
fails on configurations such as XFS realtime with a 28k extent size.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
NOTE: This patch seems to fix the "porter not complete" problems on
5.16, but not on 5.17-rc1. However, 5.17-rc1 is totally broken (~72%
failure rate) so I don't think I can count that as a serious QA effort.
---
tests/generic/273 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/generic/273 b/tests/generic/273
index b5458a77..f86dae9b 100755
--- a/tests/generic/273
+++ b/tests/generic/273
@@ -87,8 +87,8 @@ _do_workload()
{
_pids=""
_pid=1
- block_size=$(_get_block_size $SCRATCH_MNT)
-
+ block_size=$(_get_file_block_size $SCRATCH_MNT)
+
_threads_set
_file_create $block_size
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/273: use _get_file_block_size
2022-01-24 18:37 [PATCH] generic/273: use _get_file_block_size Darrick J. Wong
@ 2022-01-24 23:21 ` Leah Rumancik
0 siblings, 0 replies; 2+ messages in thread
From: Leah Rumancik @ 2022-01-24 23:21 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eryu Guan, fstests, xfs
Applied and confirmed this fixes generic/273 for realtime 28k
extent sizes for me.
Reviewed-by: Leah Rumancik <leah.rumancik@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-25 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 18:37 [PATCH] generic/273: use _get_file_block_size Darrick J. Wong
2022-01-24 23:21 ` Leah Rumancik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.