All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
@ 2021-12-21 11:16 Abel Vesa
  2021-12-21 13:43 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Abel Vesa @ 2021-12-21 11:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland
  Cc: linux-serial, devicetree, Linux Kernel Mailing List, Abel Vesa

Add i.MX8DXL lpuart compatible to the bindings documentation.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---

This is a resend of the following, but as a separate patch.

https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/

 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index 6e04e3848261..1f482e166467 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -30,6 +30,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart
 
   reg:
     maxItems: 1
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
  2021-12-21 11:16 [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible Abel Vesa
@ 2021-12-21 13:43 ` Rob Herring
  2022-01-14 15:29   ` Abel Vesa
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-12-21 13:43 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Greg Kroah-Hartman, Mark Rutland, open list:SERIAL DRIVERS,
	devicetree, Linux Kernel Mailing List

On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> Add i.MX8DXL lpuart compatible to the bindings documentation.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>
> This is a resend of the following, but as a separate patch.
>
> https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/
>
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index 6e04e3848261..1f482e166467 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -30,6 +30,10 @@ properties:
>        - items:
>            - const: fsl,imx8qm-lpuart
>            - const: fsl,imx8qxp-lpuart
> +      - items:
> +          - const: fsl,imx8dxl-lpuart
> +          - const: fsl,imx8qxp-lpuart
> +          - const: fsl,imx7ulp-lpuart

It doesn't really make sense that imx8qm and imx8dxl are backwards
compatible with imx8qxp, but only imx8qm is backwards compatible to
imx7ulp. Ir only makes sense if some feature/quirk specific to
fsl,imx7ulp-lpuart is gone in imx8qm.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
  2021-12-21 13:43 ` Rob Herring
@ 2022-01-14 15:29   ` Abel Vesa
  0 siblings, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2022-01-14 15:29 UTC (permalink / raw)
  To: Rob Herring
  Cc: Greg Kroah-Hartman, Mark Rutland, open list:SERIAL DRIVERS,
	devicetree, Linux Kernel Mailing List

On 21-12-21 09:43:39, Rob Herring wrote:
> On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@nxp.com> wrote:
> >
> > Add i.MX8DXL lpuart compatible to the bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >
> > This is a resend of the following, but as a separate patch.
> >
> > https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/
> >
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 6e04e3848261..1f482e166467 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -30,6 +30,10 @@ properties:
> >        - items:
> >            - const: fsl,imx8qm-lpuart
> >            - const: fsl,imx8qxp-lpuart
> > +      - items:
> > +          - const: fsl,imx8dxl-lpuart
> > +          - const: fsl,imx8qxp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
> It doesn't really make sense that imx8qm and imx8dxl are backwards
> compatible with imx8qxp, but only imx8qm is backwards compatible to
> imx7ulp. Ir only makes sense if some feature/quirk specific to
> fsl,imx7ulp-lpuart is gone in imx8qm.
> 

Actually, I'll just drop the imx7ulp from the imx8dxl dts nodes and then
from this patch.

The imx7ulp compatible is not needed anymore because the following
commit:

b4b844930f27bf7019 ("tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"

got reverted by:

4e9679738a918d8a48 ('Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"')

Will resend with proper changes.

> Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-14 15:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 11:16 [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible Abel Vesa
2021-12-21 13:43 ` Rob Herring
2022-01-14 15:29   ` Abel Vesa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.