* [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731
@ 2022-01-17 5:45 ` Julian Braha
0 siblings, 0 replies; 4+ messages in thread
From: Julian Braha @ 2022-01-17 5:45 UTC (permalink / raw)
To: broonie, lgirdwood, perex, tiwai; +Cc: alsa-devel, linux-kernel, fazilyildiran
When SND_SOC_DB1200 is selected,
and SND_SOC_I2C_AND_SPI is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_WM8731
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_I2C_AND_SPI [=n]
Selected by [y]:
- SND_SOC_DB1200 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AU1XPSC [=y]
This is because SND_SOC_DB1200 selects
SND_SOC_WM8731 without selecting or depending on
SND_SOC_I2C_AND_SPI, despite SND_SOC_WM8731
depending on SND_SOC_I2C_AND_SPI.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/au1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig
index 38de7c0efbc7..3dccdfddbf9d 100644
--- a/sound/soc/au1x/Kconfig
+++ b/sound/soc/au1x/Kconfig
@@ -54,6 +54,7 @@ config SND_SOC_DB1000
config SND_SOC_DB1200
tristate "DB1200/DB1300/DB1550 Audio support"
depends on SND_SOC_AU1XPSC
+ depends on SND_SOC_I2C_AND_SPI
select SND_SOC_AU1XPSC_AC97
select SND_SOC_AC97_CODEC
select SND_SOC_WM9712
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731
@ 2022-01-17 5:45 ` Julian Braha
0 siblings, 0 replies; 4+ messages in thread
From: Julian Braha @ 2022-01-17 5:45 UTC (permalink / raw)
To: broonie, lgirdwood, perex, tiwai; +Cc: alsa-devel, fazilyildiran, linux-kernel
When SND_SOC_DB1200 is selected,
and SND_SOC_I2C_AND_SPI is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_WM8731
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_I2C_AND_SPI [=n]
Selected by [y]:
- SND_SOC_DB1200 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AU1XPSC [=y]
This is because SND_SOC_DB1200 selects
SND_SOC_WM8731 without selecting or depending on
SND_SOC_I2C_AND_SPI, despite SND_SOC_WM8731
depending on SND_SOC_I2C_AND_SPI.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/au1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig
index 38de7c0efbc7..3dccdfddbf9d 100644
--- a/sound/soc/au1x/Kconfig
+++ b/sound/soc/au1x/Kconfig
@@ -54,6 +54,7 @@ config SND_SOC_DB1000
config SND_SOC_DB1200
tristate "DB1200/DB1300/DB1550 Audio support"
depends on SND_SOC_AU1XPSC
+ depends on SND_SOC_I2C_AND_SPI
select SND_SOC_AU1XPSC_AC97
select SND_SOC_AC97_CODEC
select SND_SOC_WM9712
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731
2022-01-17 5:45 ` Julian Braha
@ 2022-01-18 17:06 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-01-18 17:06 UTC (permalink / raw)
To: Julian Braha
Cc: lgirdwood, perex, tiwai, alsa-devel, linux-kernel, fazilyildiran
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, Jan 17, 2022 at 12:45:39AM -0500, Julian Braha wrote:
> @@ -54,6 +54,7 @@ config SND_SOC_DB1000
> config SND_SOC_DB1200
> tristate "DB1200/DB1300/DB1550 Audio support"
> depends on SND_SOC_AU1XPSC
> + depends on SND_SOC_I2C_AND_SPI
> select SND_SOC_AU1XPSC_AC97
> select SND_SOC_AC97_CODEC
> select SND_SOC_WM9712
This obviously not sensible, not only is _I2C_AND_SPI a control that
shouldn't be selected by any driver but this machine is AC'97 based so
clearly doesn't need either I2C or SPI support. Whatever is going on
this isn't it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731
@ 2022-01-18 17:06 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-01-18 17:06 UTC (permalink / raw)
To: Julian Braha; +Cc: alsa-devel, lgirdwood, fazilyildiran, linux-kernel, tiwai
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, Jan 17, 2022 at 12:45:39AM -0500, Julian Braha wrote:
> @@ -54,6 +54,7 @@ config SND_SOC_DB1000
> config SND_SOC_DB1200
> tristate "DB1200/DB1300/DB1550 Audio support"
> depends on SND_SOC_AU1XPSC
> + depends on SND_SOC_I2C_AND_SPI
> select SND_SOC_AU1XPSC_AC97
> select SND_SOC_AC97_CODEC
> select SND_SOC_WM9712
This obviously not sensible, not only is _I2C_AND_SPI a control that
shouldn't be selected by any driver but this machine is AC'97 based so
clearly doesn't need either I2C or SPI support. Whatever is going on
this isn't it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-18 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 5:45 [PATCH] ASoC: au1x: fix unmet dependency on SND_SOC_I2C_AND_SPI for SND_SOC_WM8731 Julian Braha
2022-01-17 5:45 ` Julian Braha
2022-01-18 17:06 ` Mark Brown
2022-01-18 17:06 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.