All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: marvell/octeontx: remove redundant initialization of variable c_size
@ 2022-01-30 22:53 Colin Ian King
  2022-02-05  4:34 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-01-30 22:53 UTC (permalink / raw)
  To: Boris Brezillon, Arnaud Ebalard, Srujana Challa, Herbert Xu,
	David S . Miller, linux-crypto
  Cc: kernel-janitors, linux-kernel

Variable c_size is being initialized with a value that is never read, it
is being re-assigned with a different value later on. The initialization
is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/crypto/marvell/octeontx/otx_cptvf_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/marvell/octeontx/otx_cptvf_main.c b/drivers/crypto/marvell/octeontx/otx_cptvf_main.c
index b681bd2dc6ad..36d72e35ebeb 100644
--- a/drivers/crypto/marvell/octeontx/otx_cptvf_main.c
+++ b/drivers/crypto/marvell/octeontx/otx_cptvf_main.c
@@ -204,7 +204,6 @@ static int alloc_command_queues(struct otx_cptvf *cptvf,
 
 	/* per queue initialization */
 	for (i = 0; i < cptvf->num_queues; i++) {
-		c_size = 0;
 		rem_q_size = q_size;
 		first = NULL;
 		last = NULL;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: marvell/octeontx: remove redundant initialization of variable c_size
  2022-01-30 22:53 [PATCH] crypto: marvell/octeontx: remove redundant initialization of variable c_size Colin Ian King
@ 2022-02-05  4:34 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-02-05  4:34 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Boris Brezillon, Arnaud Ebalard, Srujana Challa,
	David S . Miller, linux-crypto, kernel-janitors, linux-kernel

On Sun, Jan 30, 2022 at 10:53:25PM +0000, Colin Ian King wrote:
> Variable c_size is being initialized with a value that is never read, it
> is being re-assigned with a different value later on. The initialization
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/crypto/marvell/octeontx/otx_cptvf_main.c | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-05  4:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 22:53 [PATCH] crypto: marvell/octeontx: remove redundant initialization of variable c_size Colin Ian King
2022-02-05  4:34 ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.