* stable-rc/queue: 5.15 5.16 arm64 builds failed
@ 2022-02-18 14:36 Naresh Kamboju
2022-02-18 14:49 ` Jens Wiklander
0 siblings, 1 reply; 5+ messages in thread
From: Naresh Kamboju @ 2022-02-18 14:36 UTC (permalink / raw)
To: linux-stable, Sumit Garg, Jens Wiklander, Greg Kroah-Hartman,
Sasha Levin
Cc: Lars Persson
While building stable rc queues for arch arm64 on queue/5.15 and
queue/5.16 the following build errors / warnings were noticed.
## Fails
* arm64, build
- gcc-11-defconfig-5e73d44a
Committing details,
optee: use driver internal tee_context for some rpc
commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
build error / warning.
drivers/tee/optee/core.c: In function 'optee_remove':
drivers/tee/optee/core.c:591:9: error: implicit declaration of
function 'teedev_close_context'; did you mean
'tee_client_close_context'? [-Werror=implicit-function-declaration]
591 | teedev_close_context(optee->ctx);
| ^~~~~~~~~~~~~~~~~~~~
| tee_client_close_context
drivers/tee/optee/core.c: In function 'optee_probe':
drivers/tee/optee/core.c:724:15: error: implicit declaration of
function 'teedev_open' [-Werror=implicit-function-declaration]
724 | ctx = teedev_open(optee->teedev);
| ^~~~~~~~~~~
drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
tee_context *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
724 | ctx = teedev_open(optee->teedev);
| ^
drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
undefined [-Wsequence-point]
726 | rc = rc = PTR_ERR(ctx);
| ~~~^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
Linaro LKFT
https://lkft.linaro.org
[1] https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.16/build/v5.16.10-87-gb5b4ed62d295
[2] https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.16/build/v5.16.10-87-gb5b4ed62d295
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable-rc/queue: 5.15 5.16 arm64 builds failed
2022-02-18 14:36 stable-rc/queue: 5.15 5.16 arm64 builds failed Naresh Kamboju
@ 2022-02-18 14:49 ` Jens Wiklander
2022-02-18 14:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Jens Wiklander @ 2022-02-18 14:49 UTC (permalink / raw)
To: Naresh Kamboju
Cc: linux-stable, Sumit Garg, Greg Kroah-Hartman, Sasha Levin, Lars Persson
Hi Naresh,
On Fri, Feb 18, 2022 at 3:36 PM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> While building stable rc queues for arch arm64 on queue/5.15 and
> queue/5.16 the following build errors / warnings were noticed.
>
> ## Fails
> * arm64, build
> - gcc-11-defconfig-5e73d44a
>
> Committing details,
> optee: use driver internal tee_context for some rpc
> commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
>
>
> build error / warning.
> drivers/tee/optee/core.c: In function 'optee_remove':
> drivers/tee/optee/core.c:591:9: error: implicit declaration of
> function 'teedev_close_context'; did you mean
> 'tee_client_close_context'? [-Werror=implicit-function-declaration]
> 591 | teedev_close_context(optee->ctx);
> | ^~~~~~~~~~~~~~~~~~~~
> | tee_client_close_context
> drivers/tee/optee/core.c: In function 'optee_probe':
> drivers/tee/optee/core.c:724:15: error: implicit declaration of
> function 'teedev_open' [-Werror=implicit-function-declaration]
> 724 | ctx = teedev_open(optee->teedev);
> | ^~~~~~~~~~~
> drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
> tee_context *' from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
> 724 | ctx = teedev_open(optee->teedev);
> | ^
> drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
> undefined [-Wsequence-point]
> 726 | rc = rc = PTR_ERR(ctx);
> | ~~~^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
>
It looks like 1e2c3ef0496e ("tee: export teedev_open() and
teedev_close_context()") is missing. I noted the dependency as:
Cc: stable@vger.kernel.org # 1e2c3ef0496e tee: export
teedev_open() and teedev_close_context()
in the commit. Perhaps I've misunderstood how this is supposed to be done.
Thanks,
Jens
> --
> Linaro LKFT
> https://lkft.linaro.org
>
> [1] https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.16/build/v5.16.10-87-gb5b4ed62d295
> [2] https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.16/build/v5.16.10-87-gb5b4ed62d295
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable-rc/queue: 5.15 5.16 arm64 builds failed
2022-02-18 14:49 ` Jens Wiklander
@ 2022-02-18 14:56 ` Greg Kroah-Hartman
2022-02-18 15:09 ` Jens Wiklander
2022-02-18 19:58 ` Sasha Levin
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2022-02-18 14:56 UTC (permalink / raw)
To: Jens Wiklander
Cc: Naresh Kamboju, linux-stable, Sumit Garg, Sasha Levin, Lars Persson
On Fri, Feb 18, 2022 at 03:49:49PM +0100, Jens Wiklander wrote:
> Hi Naresh,
>
> On Fri, Feb 18, 2022 at 3:36 PM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > While building stable rc queues for arch arm64 on queue/5.15 and
> > queue/5.16 the following build errors / warnings were noticed.
> >
> > ## Fails
> > * arm64, build
> > - gcc-11-defconfig-5e73d44a
> >
> > Committing details,
> > optee: use driver internal tee_context for some rpc
> > commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
> >
> >
> > build error / warning.
> > drivers/tee/optee/core.c: In function 'optee_remove':
> > drivers/tee/optee/core.c:591:9: error: implicit declaration of
> > function 'teedev_close_context'; did you mean
> > 'tee_client_close_context'? [-Werror=implicit-function-declaration]
> > 591 | teedev_close_context(optee->ctx);
> > | ^~~~~~~~~~~~~~~~~~~~
> > | tee_client_close_context
> > drivers/tee/optee/core.c: In function 'optee_probe':
> > drivers/tee/optee/core.c:724:15: error: implicit declaration of
> > function 'teedev_open' [-Werror=implicit-function-declaration]
> > 724 | ctx = teedev_open(optee->teedev);
> > | ^~~~~~~~~~~
> > drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
> > tee_context *' from 'int' makes pointer from integer without a cast
> > [-Wint-conversion]
> > 724 | ctx = teedev_open(optee->teedev);
> > | ^
> > drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
> > undefined [-Wsequence-point]
> > 726 | rc = rc = PTR_ERR(ctx);
> > | ~~~^~~~~~~~~~~~~~~~~~~
> > cc1: some warnings being treated as errors
> >
> >
> >
>
> It looks like 1e2c3ef0496e ("tee: export teedev_open() and
> teedev_close_context()") is missing. I noted the dependency as:
> Cc: stable@vger.kernel.org # 1e2c3ef0496e tee: export
> teedev_open() and teedev_close_context()
> in the commit. Perhaps I've misunderstood how this is supposed to be done.
When doing a backport like this, please be explicit as to what I need to
do if it is different than just taking the patch you sent me.
I'll try to fix this up later...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable-rc/queue: 5.15 5.16 arm64 builds failed
2022-02-18 14:56 ` Greg Kroah-Hartman
@ 2022-02-18 15:09 ` Jens Wiklander
2022-02-18 19:58 ` Sasha Levin
1 sibling, 0 replies; 5+ messages in thread
From: Jens Wiklander @ 2022-02-18 15:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Naresh Kamboju, linux-stable, Sumit Garg, Sasha Levin, Lars Persson
On Fri, Feb 18, 2022 at 3:57 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 18, 2022 at 03:49:49PM +0100, Jens Wiklander wrote:
> > Hi Naresh,
> >
> > On Fri, Feb 18, 2022 at 3:36 PM Naresh Kamboju
> > <naresh.kamboju@linaro.org> wrote:
> > >
> > > While building stable rc queues for arch arm64 on queue/5.15 and
> > > queue/5.16 the following build errors / warnings were noticed.
> > >
> > > ## Fails
> > > * arm64, build
> > > - gcc-11-defconfig-5e73d44a
> > >
> > > Committing details,
> > > optee: use driver internal tee_context for some rpc
> > > commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
> > >
> > >
> > > build error / warning.
> > > drivers/tee/optee/core.c: In function 'optee_remove':
> > > drivers/tee/optee/core.c:591:9: error: implicit declaration of
> > > function 'teedev_close_context'; did you mean
> > > 'tee_client_close_context'? [-Werror=implicit-function-declaration]
> > > 591 | teedev_close_context(optee->ctx);
> > > | ^~~~~~~~~~~~~~~~~~~~
> > > | tee_client_close_context
> > > drivers/tee/optee/core.c: In function 'optee_probe':
> > > drivers/tee/optee/core.c:724:15: error: implicit declaration of
> > > function 'teedev_open' [-Werror=implicit-function-declaration]
> > > 724 | ctx = teedev_open(optee->teedev);
> > > | ^~~~~~~~~~~
> > > drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
> > > tee_context *' from 'int' makes pointer from integer without a cast
> > > [-Wint-conversion]
> > > 724 | ctx = teedev_open(optee->teedev);
> > > | ^
> > > drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
> > > undefined [-Wsequence-point]
> > > 726 | rc = rc = PTR_ERR(ctx);
> > > | ~~~^~~~~~~~~~~~~~~~~~~
> > > cc1: some warnings being treated as errors
> > >
> > >
> > >
> >
> > It looks like 1e2c3ef0496e ("tee: export teedev_open() and
> > teedev_close_context()") is missing. I noted the dependency as:
> > Cc: stable@vger.kernel.org # 1e2c3ef0496e tee: export
> > teedev_open() and teedev_close_context()
> > in the commit. Perhaps I've misunderstood how this is supposed to be done.
>
> When doing a backport like this, please be explicit as to what I need to
> do if it is different than just taking the patch you sent me.
OK, I have a couple of backports left so I'll make sure to mention it there.
>
> I'll try to fix this up later...
Thanks, sorry about the trouble.
/Jens
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: stable-rc/queue: 5.15 5.16 arm64 builds failed
2022-02-18 14:56 ` Greg Kroah-Hartman
2022-02-18 15:09 ` Jens Wiklander
@ 2022-02-18 19:58 ` Sasha Levin
1 sibling, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2022-02-18 19:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jens Wiklander, Naresh Kamboju, linux-stable, Sumit Garg, Lars Persson
On Fri, Feb 18, 2022 at 03:56:31PM +0100, Greg Kroah-Hartman wrote:
>On Fri, Feb 18, 2022 at 03:49:49PM +0100, Jens Wiklander wrote:
>> Hi Naresh,
>>
>> On Fri, Feb 18, 2022 at 3:36 PM Naresh Kamboju
>> <naresh.kamboju@linaro.org> wrote:
>> >
>> > While building stable rc queues for arch arm64 on queue/5.15 and
>> > queue/5.16 the following build errors / warnings were noticed.
>> >
>> > ## Fails
>> > * arm64, build
>> > - gcc-11-defconfig-5e73d44a
>> >
>> > Committing details,
>> > optee: use driver internal tee_context for some rpc
>> > commit aceeafefff736057e8f93f19bbfbef26abd94604 upstream.
>> >
>> >
>> > build error / warning.
>> > drivers/tee/optee/core.c: In function 'optee_remove':
>> > drivers/tee/optee/core.c:591:9: error: implicit declaration of
>> > function 'teedev_close_context'; did you mean
>> > 'tee_client_close_context'? [-Werror=implicit-function-declaration]
>> > 591 | teedev_close_context(optee->ctx);
>> > | ^~~~~~~~~~~~~~~~~~~~
>> > | tee_client_close_context
>> > drivers/tee/optee/core.c: In function 'optee_probe':
>> > drivers/tee/optee/core.c:724:15: error: implicit declaration of
>> > function 'teedev_open' [-Werror=implicit-function-declaration]
>> > 724 | ctx = teedev_open(optee->teedev);
>> > | ^~~~~~~~~~~
>> > drivers/tee/optee/core.c:724:13: warning: assignment to 'struct
>> > tee_context *' from 'int' makes pointer from integer without a cast
>> > [-Wint-conversion]
>> > 724 | ctx = teedev_open(optee->teedev);
>> > | ^
>> > drivers/tee/optee/core.c:726:20: warning: operation on 'rc' may be
>> > undefined [-Wsequence-point]
>> > 726 | rc = rc = PTR_ERR(ctx);
>> > | ~~~^~~~~~~~~~~~~~~~~~~
>> > cc1: some warnings being treated as errors
>> >
>> >
>> >
>>
>> It looks like 1e2c3ef0496e ("tee: export teedev_open() and
>> teedev_close_context()") is missing. I noted the dependency as:
>> Cc: stable@vger.kernel.org # 1e2c3ef0496e tee: export
>> teedev_open() and teedev_close_context()
>> in the commit. Perhaps I've misunderstood how this is supposed to be done.
>
>When doing a backport like this, please be explicit as to what I need to
>do if it is different than just taking the patch you sent me.
>
>I'll try to fix this up later...
I've added the missing commit to 5.15 and 5.16.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-18 19:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 14:36 stable-rc/queue: 5.15 5.16 arm64 builds failed Naresh Kamboju
2022-02-18 14:49 ` Jens Wiklander
2022-02-18 14:56 ` Greg Kroah-Hartman
2022-02-18 15:09 ` Jens Wiklander
2022-02-18 19:58 ` Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.