From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, robdclark@gmail.com, seanpaul@chromium.org, swboyd@chromium.org, dianders@chromium.org, krzysztof.kozlowski@canonical.com, thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, quic_kalyant@quicinc.com, quic_abhinavk@quicinc.com, quic_khsieh@quicinc.com, quic_mkrishn@quicinc.com Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD Date: Tue, 8 Feb 2022 15:52:59 -0800 [thread overview] Message-ID: <YgMCW9GrY6SRteOU@ripper> (raw) In-Reply-To: <1644333525-30920-3-git-send-email-quic_sbillaka@quicinc.com> On Tue 08 Feb 07:18 PST 2022, Sankeerth Billakanti wrote: > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > > Changes in v2: > - sort node references alphabetically > - improve readability > - move the pwm pinctrl to pwm node > - move the regulators to root > - define backlight power > - remove dummy regulator node > - cleanup pinctrl definitions > > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 122 ++++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 - > 2 files changed, 122 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..bff2707 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -21,6 +21,34 @@ > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + backlight_power: backlight-power { > + compatible = "regulator-fixed"; > + regulator-name = "backlight_power"; > + > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + gpio = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_bl_power>; > + }; > + > + edp_power: edp-power { > + compatible = "regulator-fixed"; > + regulator-name = "edp_power"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_panel_power>; > + }; > }; > > &apps_rsc { > @@ -76,6 +104,42 @@ ap_ts_pen_1v8: &i2c13 { > }; > }; > > +&edp_out { Sorry for missing this while merging changes in sc7280.dtsi. But it would be really nice if this was labeled mdss_edp_out instead (or possibly defined within the &mdss_edp node). Now you will have &edp_out and &dp_out floating around away from the edp and dp nodes... > + remote-endpoint = <&edp_panel_in>; > +}; > + > +&mdss { > + status = "okay"; > +}; > + > +&mdss_edp { > + status = "okay"; > + > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l10c_0p8>; > +}; > + > +&mdss_edp_phy { > + status = "okay"; > + > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l10c_0p8>; > +}; > + > +&mdss_dp { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&dp_hot_plug_det>; > + data-lanes = <0 1>; > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l1b_0p8>; > +}; > + > +&mdss_mdp { > + status = "okay"; > +}; > + > &nvme_3v3_regulator { > gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; > }; > @@ -84,7 +148,65 @@ ap_ts_pen_1v8: &i2c13 { > pins = "gpio51"; > }; > > +&pm8350c_pwm { This label doesn't exist, so I won't be able to merge this patch. > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_bl_pwm>; > +}; > + > +&pm8350c_gpios { > + edp_bl_power: edp-bl-power { > + pins = "gpio7"; > + function = "normal"; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; > + bias-disable; > + output-low; > + }; > + > + edp_bl_pwm: edp-bl-pwm { > + pins = "gpio8"; > + function = "func1"; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; > + bias-disable; > + output-low; > + }; > +}; > + > +&soc { > + edp_backlight: edp-backlight { > + compatible = "pwm-backlight"; This is not a device on the mmio bus, so it should not love within the &soc. > + > + power-supply = <&backlight_power>; > + pwms = <&pm8350c_pwm 3 65535>; > + }; > + > + edp_panel: edp_panel { Ditto. Regards, Bjorn > + compatible = "sharp,lq140m1jw46"; > + > + power-supply = <&edp_power>; > + backlight = <&edp_backlight>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + edp_panel_in: endpoint { > + remote-endpoint = <&edp_out>; > + }; > + }; > + }; > + }; > +}; > + > &tlmm { > + edp_panel_power: edp-panel-power { > + pins = "gpio80"; > + function = "gpio"; > + bias-pull-down; > + }; > + > tp_int_odl: tp-int-odl { > pins = "gpio7"; > function = "gpio"; > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 3572399..f8fa716 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3012,8 +3012,6 @@ > > mdss_edp: edp@aea0000 { > compatible = "qcom,sc7280-edp"; > - pinctrl-names = "default"; > - pinctrl-0 = <&edp_hot_plug_det>; > > reg = <0 0xaea0000 0 0x200>, > <0 0xaea0200 0 0x200>, > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, dianders@chromium.org, sam@ravnborg.org, krzysztof.kozlowski@canonical.com, airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, quic_abhinavk@quicinc.com, robh+dt@kernel.org, agross@kernel.org, seanpaul@chromium.org, thierry.reding@gmail.com, quic_khsieh@quicinc.com, freedreno@lists.freedesktop.org, quic_mkrishn@quicinc.com Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD Date: Tue, 8 Feb 2022 15:52:59 -0800 [thread overview] Message-ID: <YgMCW9GrY6SRteOU@ripper> (raw) In-Reply-To: <1644333525-30920-3-git-send-email-quic_sbillaka@quicinc.com> On Tue 08 Feb 07:18 PST 2022, Sankeerth Billakanti wrote: > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > > Changes in v2: > - sort node references alphabetically > - improve readability > - move the pwm pinctrl to pwm node > - move the regulators to root > - define backlight power > - remove dummy regulator node > - cleanup pinctrl definitions > > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 122 ++++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 - > 2 files changed, 122 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..bff2707 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -21,6 +21,34 @@ > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + backlight_power: backlight-power { > + compatible = "regulator-fixed"; > + regulator-name = "backlight_power"; > + > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + gpio = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_bl_power>; > + }; > + > + edp_power: edp-power { > + compatible = "regulator-fixed"; > + regulator-name = "edp_power"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_panel_power>; > + }; > }; > > &apps_rsc { > @@ -76,6 +104,42 @@ ap_ts_pen_1v8: &i2c13 { > }; > }; > > +&edp_out { Sorry for missing this while merging changes in sc7280.dtsi. But it would be really nice if this was labeled mdss_edp_out instead (or possibly defined within the &mdss_edp node). Now you will have &edp_out and &dp_out floating around away from the edp and dp nodes... > + remote-endpoint = <&edp_panel_in>; > +}; > + > +&mdss { > + status = "okay"; > +}; > + > +&mdss_edp { > + status = "okay"; > + > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l10c_0p8>; > +}; > + > +&mdss_edp_phy { > + status = "okay"; > + > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l10c_0p8>; > +}; > + > +&mdss_dp { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&dp_hot_plug_det>; > + data-lanes = <0 1>; > + vdda-1p2-supply = <&vreg_l6b_1p2>; > + vdda-0p9-supply = <&vreg_l1b_0p8>; > +}; > + > +&mdss_mdp { > + status = "okay"; > +}; > + > &nvme_3v3_regulator { > gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; > }; > @@ -84,7 +148,65 @@ ap_ts_pen_1v8: &i2c13 { > pins = "gpio51"; > }; > > +&pm8350c_pwm { This label doesn't exist, so I won't be able to merge this patch. > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_bl_pwm>; > +}; > + > +&pm8350c_gpios { > + edp_bl_power: edp-bl-power { > + pins = "gpio7"; > + function = "normal"; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; > + bias-disable; > + output-low; > + }; > + > + edp_bl_pwm: edp-bl-pwm { > + pins = "gpio8"; > + function = "func1"; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; > + bias-disable; > + output-low; > + }; > +}; > + > +&soc { > + edp_backlight: edp-backlight { > + compatible = "pwm-backlight"; This is not a device on the mmio bus, so it should not love within the &soc. > + > + power-supply = <&backlight_power>; > + pwms = <&pm8350c_pwm 3 65535>; > + }; > + > + edp_panel: edp_panel { Ditto. Regards, Bjorn > + compatible = "sharp,lq140m1jw46"; > + > + power-supply = <&edp_power>; > + backlight = <&edp_backlight>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + edp_panel_in: endpoint { > + remote-endpoint = <&edp_out>; > + }; > + }; > + }; > + }; > +}; > + > &tlmm { > + edp_panel_power: edp-panel-power { > + pins = "gpio80"; > + function = "gpio"; > + bias-pull-down; > + }; > + > tp_int_odl: tp-int-odl { > pins = "gpio7"; > function = "gpio"; > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 3572399..f8fa716 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3012,8 +3012,6 @@ > > mdss_edp: edp@aea0000 { > compatible = "qcom,sc7280-edp"; > - pinctrl-names = "default"; > - pinctrl-0 = <&edp_hot_plug_det>; > > reg = <0 0xaea0000 0 0x200>, > <0 0xaea0200 0 0x200>, > -- > 2.7.4 >
next prev parent reply other threads:[~2022-02-08 23:50 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-08 15:18 [PATCH v2 0/4] Add support for the eDP panel on sc7280 CRD Sankeerth Billakanti 2022-02-08 15:18 ` Sankeerth Billakanti 2022-02-08 15:18 ` [PATCH v2 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel Sankeerth Billakanti 2022-02-08 15:18 ` Sankeerth Billakanti 2022-02-08 15:18 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD Sankeerth Billakanti 2022-02-08 15:18 ` Sankeerth Billakanti 2022-02-08 22:23 ` Matthias Kaehlcke 2022-02-08 22:23 ` Matthias Kaehlcke 2022-02-09 7:11 ` Sankeerth Billakanti (QUIC) 2022-02-09 7:11 ` Sankeerth Billakanti (QUIC) 2022-02-08 23:52 ` Bjorn Andersson [this message] 2022-02-08 23:52 ` Bjorn Andersson 2022-02-09 7:15 ` Sankeerth Billakanti (QUIC) 2022-02-09 7:15 ` Sankeerth Billakanti (QUIC) 2022-02-08 15:18 ` [PATCH v2 3/4] drm/panel-edp: Add eDP sharp panel support Sankeerth Billakanti 2022-02-08 15:18 ` Sankeerth Billakanti 2022-02-08 15:18 ` [PATCH v2 4/4] drm/msm/dp: Add driver support to utilize drm panel Sankeerth Billakanti 2022-02-08 15:18 ` Sankeerth Billakanti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YgMCW9GrY6SRteOU@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_kalyant@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_mkrishn@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=seanpaul@chromium.org \ --cc=swboyd@chromium.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.