* [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 14:39 ` DENG Qingfang
0 siblings, 0 replies; 14+ messages in thread
From: DENG Qingfang @ 2022-02-09 14:39 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Matthias Brugger, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL, Hauke Mehrtens
The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:
mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
Remove the check to make it work again.
Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
drivers/net/phy/mediatek-ge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index b7a5ae20edd5..68ee434f9dea 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
static int mt7531_phy_config_init(struct phy_device *phydev)
{
- if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
- return -EINVAL;
-
mtk_gephy_config_init(phydev);
/* PHY link down power saving enable */
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 14:39 ` DENG Qingfang
0 siblings, 0 replies; 14+ messages in thread
From: DENG Qingfang @ 2022-02-09 14:39 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Matthias Brugger, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL, Hauke Mehrtens
The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:
mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
Remove the check to make it work again.
Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
drivers/net/phy/mediatek-ge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index b7a5ae20edd5..68ee434f9dea 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
static int mt7531_phy_config_init(struct phy_device *phydev)
{
- if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
- return -EINVAL;
-
mtk_gephy_config_init(phydev);
/* PHY link down power saving enable */
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 14:39 ` DENG Qingfang
0 siblings, 0 replies; 14+ messages in thread
From: DENG Qingfang @ 2022-02-09 14:39 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Matthias Brugger, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL, Hauke Mehrtens
The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:
mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
Remove the check to make it work again.
Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
drivers/net/phy/mediatek-ge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index b7a5ae20edd5..68ee434f9dea 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
static int mt7531_phy_config_init(struct phy_device *phydev)
{
- if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
- return -EINVAL;
-
mtk_gephy_config_init(phydev);
/* PHY link down power saving enable */
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
2022-02-09 14:39 ` DENG Qingfang
(?)
@ 2022-02-09 14:47 ` Arınç ÜNAL
-1 siblings, 0 replies; 14+ messages in thread
From: Arınç ÜNAL @ 2022-02-09 14:47 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Hauke Mehrtens
On 09/02/2022 17:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
Thanks for submitting this!
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Cheers.
Arınç
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 14:47 ` Arınç ÜNAL
0 siblings, 0 replies; 14+ messages in thread
From: Arınç ÜNAL @ 2022-02-09 14:47 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Hauke Mehrtens
On 09/02/2022 17:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
Thanks for submitting this!
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Cheers.
Arınç
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 14:47 ` Arınç ÜNAL
0 siblings, 0 replies; 14+ messages in thread
From: Arınç ÜNAL @ 2022-02-09 14:47 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Hauke Mehrtens
On 09/02/2022 17:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
Thanks for submitting this!
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Cheers.
Arınç
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
2022-02-09 14:39 ` DENG Qingfang
` (2 preceding siblings ...)
(?)
@ 2022-02-09 15:53 ` Andrew Lunn
2022-02-11 1:24 ` DENG Qingfang
-1 siblings, 1 reply; 14+ messages in thread
From: Andrew Lunn @ 2022-02-09 15:53 UTC (permalink / raw)
To: DENG Qingfang; +Cc: netdev
On Wed, Feb 09, 2022 at 10:39:47PM +0800, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
Is the PHY actually internal? If so PHY_INTERFACE_MODE_INTERNAL would
be correct.
Are you fixing the wrong thing here?
Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
2022-02-09 14:39 ` DENG Qingfang
(?)
@ 2022-02-09 22:11 ` Hauke Mehrtens
-1 siblings, 0 replies; 14+ messages in thread
From: Hauke Mehrtens @ 2022-02-09 22:11 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL
On 2/9/22 15:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 22:11 ` Hauke Mehrtens
0 siblings, 0 replies; 14+ messages in thread
From: Hauke Mehrtens @ 2022-02-09 22:11 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL
On 2/9/22 15:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-09 22:11 ` Hauke Mehrtens
0 siblings, 0 replies; 14+ messages in thread
From: Hauke Mehrtens @ 2022-02-09 22:11 UTC (permalink / raw)
To: DENG Qingfang, Andrew Lunn, Heiner Kallweit, Russell King,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Cc: Arınç ÜNAL
On 2/9/22 15:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/phy/mediatek-ge.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>
> static int mt7531_phy_config_init(struct phy_device *phydev)
> {
> - if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> - return -EINVAL;
> -
> mtk_gephy_config_init(phydev);
>
> /* PHY link down power saving enable */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
2022-02-09 15:53 ` Andrew Lunn
@ 2022-02-11 1:24 ` DENG Qingfang
0 siblings, 0 replies; 14+ messages in thread
From: DENG Qingfang @ 2022-02-11 1:24 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, Landen Chao, Sean Wang
On Wed, Feb 9, 2022 at 11:53 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> Is the PHY actually internal? If so PHY_INTERFACE_MODE_INTERNAL would
> be correct.
I have no idea. Maybe it internally connects to the MAC with GMII.
Add CC to mt7530 maintainers.
>
> Are you fixing the wrong thing here?
>
> Andrew
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
2022-02-09 14:39 ` DENG Qingfang
(?)
@ 2022-02-15 14:30 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-15 14:30 UTC (permalink / raw)
To: DENG Qingfang
Cc: andrew, hkallweit1, linux, davem, kuba, matthias.bgg, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, arinc.unal,
hauke
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 9 Feb 2022 22:39:47 +0800 you wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> [...]
Here is the summary with links:
- [net] net: phy: mediatek: remove PHY mode check on MT7531
https://git.kernel.org/netdev/net/c/525b108e6d95
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-15 14:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-15 14:30 UTC (permalink / raw)
To: DENG Qingfang
Cc: andrew, hkallweit1, linux, davem, kuba, matthias.bgg, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, arinc.unal,
hauke
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 9 Feb 2022 22:39:47 +0800 you wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> [...]
Here is the summary with links:
- [net] net: phy: mediatek: remove PHY mode check on MT7531
https://git.kernel.org/netdev/net/c/525b108e6d95
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
@ 2022-02-15 14:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-15 14:30 UTC (permalink / raw)
To: DENG Qingfang
Cc: andrew, hkallweit1, linux, davem, kuba, matthias.bgg, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, arinc.unal,
hauke
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 9 Feb 2022 22:39:47 +0800 you wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> [...]
Here is the summary with links:
- [net] net: phy: mediatek: remove PHY mode check on MT7531
https://git.kernel.org/netdev/net/c/525b108e6d95
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-02-15 14:31 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 14:39 [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531 DENG Qingfang
2022-02-09 14:39 ` DENG Qingfang
2022-02-09 14:39 ` DENG Qingfang
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 15:53 ` Andrew Lunn
2022-02-11 1:24 ` DENG Qingfang
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-15 14:30 ` patchwork-bot+netdevbpf
2022-02-15 14:30 ` patchwork-bot+netdevbpf
2022-02-15 14:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.