All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/usb: Fix Coding Style Error
@ 2022-02-10 13:08 Husni Faiz
  2022-02-10 13:46 ` Greg KH
  2022-02-10 19:18 ` [PATCH v2] usb: Fix Trailing Whitespace " Husni Faiz
  0 siblings, 2 replies; 5+ messages in thread
From: Husni Faiz @ 2022-02-10 13:08 UTC (permalink / raw)
  To: b-liu, gregkh; +Cc: Husni Faiz, linux-usb, linux-kernel

Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com>


Removed trailing whitespace.

---
 drivers/usb/musb/musb_host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 9ff7d891b4b7..cf25a2b7e3bb 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -563,7 +563,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum)
 	ep->rx_reinit = 0;
 }
 
-static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep, 
+static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
 					struct musb_qh *qh,
 					u32 *length, u8 *mode)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drivers/usb: Fix Coding Style Error
  2022-02-10 13:08 [PATCH] drivers/usb: Fix Coding Style Error Husni Faiz
@ 2022-02-10 13:46 ` Greg KH
  2022-02-10 19:18 ` [PATCH v2] usb: Fix Trailing Whitespace " Husni Faiz
  1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2022-02-10 13:46 UTC (permalink / raw)
  To: Husni Faiz; +Cc: b-liu, linux-usb, linux-kernel

On Thu, Feb 10, 2022 at 06:38:01PM +0530, Husni Faiz wrote:
> Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com>
> 
> 
> Removed trailing whitespace.
> 
> ---
>  drivers/usb/musb/musb_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 9ff7d891b4b7..cf25a2b7e3bb 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -563,7 +563,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum)
>  	ep->rx_reinit = 0;
>  }
>  
> -static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep, 
> +static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
>  					struct musb_qh *qh,
>  					u32 *length, u8 *mode)
>  {
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] usb: Fix Trailing Whitespace Coding Style Error
  2022-02-10 13:08 [PATCH] drivers/usb: Fix Coding Style Error Husni Faiz
  2022-02-10 13:46 ` Greg KH
@ 2022-02-10 19:18 ` Husni Faiz
  2022-02-11  9:55   ` Greg KH
  1 sibling, 1 reply; 5+ messages in thread
From: Husni Faiz @ 2022-02-10 19:18 UTC (permalink / raw)
  To: b-liu, gregkh; +Cc: Husni Faiz, linux-usb, linux-kernel

Removed Trailing whitespace.

Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com>
---
 drivers/usb/musb/musb_host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 9ff7d891b4b7..cf25a2b7e3bb 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -563,7 +563,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum)
 	ep->rx_reinit = 0;
 }
 
-static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep, 
+static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
 					struct musb_qh *qh,
 					u32 *length, u8 *mode)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: Fix Trailing Whitespace Coding Style Error
  2022-02-10 19:18 ` [PATCH v2] usb: Fix Trailing Whitespace " Husni Faiz
@ 2022-02-11  9:55   ` Greg KH
       [not found]     ` <CAFjpAKoLYDeY6FrRAebBkbasgLoxPzvUjQH3hE7iJgSpkNfaRQ@mail.gmail.com>
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-02-11  9:55 UTC (permalink / raw)
  To: Husni Faiz; +Cc: b-liu, linux-usb, linux-kernel

On Fri, Feb 11, 2022 at 12:48:38AM +0530, Husni Faiz wrote:
> Removed Trailing whitespace.
> 
> Signed-off-by: Husni Faiz <ahamedhusni73@gmail.com>
> ---
>  drivers/usb/musb/musb_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 9ff7d891b4b7..cf25a2b7e3bb 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -563,7 +563,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum)
>  	ep->rx_reinit = 0;
>  }
>  
> -static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep, 
> +static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
>  					struct musb_qh *qh,
>  					u32 *length, u8 *mode)
>  {
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: Fix Trailing Whitespace Coding Style Error
       [not found]     ` <CAFjpAKoLYDeY6FrRAebBkbasgLoxPzvUjQH3hE7iJgSpkNfaRQ@mail.gmail.com>
@ 2022-02-12  7:05       ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2022-02-12  7:05 UTC (permalink / raw)
  To: Ahamed Husni; +Cc: b-liu, linux-usb, linux-kernel

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Feb 11, 2022 at 11:48:41PM +0530, Ahamed Husni wrote:
> Hi all,
> 
> In the patch V1 I had added the changelog in the wrong section.
> In the patch V2 I have corrected it and also changed the commit message
> subject line.
> No code changes were made from the patch V1. Should I create a V3 patch
> mentioning this?

Please do, I can not take it like this.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-12  7:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 13:08 [PATCH] drivers/usb: Fix Coding Style Error Husni Faiz
2022-02-10 13:46 ` Greg KH
2022-02-10 19:18 ` [PATCH v2] usb: Fix Trailing Whitespace " Husni Faiz
2022-02-11  9:55   ` Greg KH
     [not found]     ` <CAFjpAKoLYDeY6FrRAebBkbasgLoxPzvUjQH3hE7iJgSpkNfaRQ@mail.gmail.com>
2022-02-12  7:05       ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.