* [PATCH 0/2] i2c: rcar: Add R-Car S4-8 support
@ 2022-02-03 14:33 Geert Uytterhoeven
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
2022-02-03 14:33 ` [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support Geert Uytterhoeven
0 siblings, 2 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-03 14:33 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Hi all,
This patch series adds support for the I2C Bus Interfaces in the R-Car
S4-8 (R8A779F0) SoC, to both DT bindings and driver code. It has been
tested on the Renesas Spider development board.
Thanks for your comments!
Geert Uytterhoeven (2):
dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support
i2c: rcar: Add R-Car Gen4 support
Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml | 6 ++++++
drivers/i2c/busses/i2c-rcar.c | 1 +
2 files changed, 7 insertions(+)
--
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support
2022-02-03 14:33 [PATCH 0/2] i2c: rcar: Add R-Car S4-8 support Geert Uytterhoeven
@ 2022-02-03 14:33 ` Geert Uytterhoeven
2022-02-10 22:15 ` Wolfram Sang
` (2 more replies)
2022-02-03 14:33 ` [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support Geert Uytterhoeven
1 sibling, 3 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-03 14:33 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Document support for the I2C Bus Interfaces in the Renesas R-Car S4-8
(R8A779F0) SoC, including a new family-specific compatible value for the
R-Car Gen4 family.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
index 052aad44e781a561..c30107833a5145f9 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
@@ -49,6 +49,11 @@ properties:
- renesas,i2c-r8a779a0 # R-Car V3U
- const: renesas,rcar-gen3-i2c # R-Car Gen3 and RZ/G2
+ - items:
+ - enum:
+ - renesas,i2c-r8a779f0 # R-Car S4-8
+ - const: renesas,rcar-gen4-i2c # R-Car Gen4
+
reg:
maxItems: 1
@@ -132,6 +137,7 @@ allOf:
enum:
- renesas,rcar-gen2-i2c
- renesas,rcar-gen3-i2c
+ - renesas,rcar-gen4-i2c
then:
required:
- resets
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-03 14:33 [PATCH 0/2] i2c: rcar: Add R-Car S4-8 support Geert Uytterhoeven
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
@ 2022-02-03 14:33 ` Geert Uytterhoeven
2022-02-08 8:08 ` Geert Uytterhoeven
2022-02-11 17:33 ` Wolfram Sang
1 sibling, 2 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-03 14:33 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Add support for the I2C Bus Interface on R-Car Gen4 SoCs (e.g. R-Car
S4-8) by matching on a family-specific compatible value.
While I2C on R-Car Gen4 does support some extra features (Slave Clock
Stretch Select, Fast-mode Plus), for now it is treated the same as I2C
on R-Car Gen3.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/i2c/busses/i2c-rcar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index f71c730f9838d89c..0db3d755906627d7 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -1008,6 +1008,7 @@ static const struct of_device_id rcar_i2c_dt_ids[] = {
{ .compatible = "renesas,rcar-gen1-i2c", .data = (void *)I2C_RCAR_GEN1 },
{ .compatible = "renesas,rcar-gen2-i2c", .data = (void *)I2C_RCAR_GEN2 },
{ .compatible = "renesas,rcar-gen3-i2c", .data = (void *)I2C_RCAR_GEN3 },
+ { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN3 },
{},
};
MODULE_DEVICE_TABLE(of, rcar_i2c_dt_ids);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-03 14:33 ` [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support Geert Uytterhoeven
@ 2022-02-08 8:08 ` Geert Uytterhoeven
2022-02-08 12:35 ` Wolfram Sang
2022-02-11 17:33 ` Wolfram Sang
1 sibling, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-08 8:08 UTC (permalink / raw)
To: Wolfram Sang
Cc: Rob Herring, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Thu, Feb 3, 2022 at 3:33 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Add support for the I2C Bus Interface on R-Car Gen4 SoCs (e.g. R-Car
> S4-8) by matching on a family-specific compatible value.
>
> While I2C on R-Car Gen4 does support some extra features (Slave Clock
> Stretch Select, Fast-mode Plus), for now it is treated the same as I2C
Correction: R-Car S4 does not support Fast-mode Plus, so there will be
a v2 of this patch, eventually.
> on R-Car Gen3.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-08 8:08 ` Geert Uytterhoeven
@ 2022-02-08 12:35 ` Wolfram Sang
2022-02-08 14:30 ` Geert Uytterhoeven
0 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2022-02-08 12:35 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
> > While I2C on R-Car Gen4 does support some extra features (Slave Clock
> > Stretch Select, Fast-mode Plus), for now it is treated the same as I2C
>
> Correction: R-Car S4 does not support Fast-mode Plus, so there will be
> a v2 of this patch, eventually.
But why? Unless we implement slave clock stretching, we can still keep
it at Gen3 level. Which does also not have FM+.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-08 12:35 ` Wolfram Sang
@ 2022-02-08 14:30 ` Geert Uytterhoeven
2022-02-08 14:43 ` Wolfram Sang
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-08 14:30 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Wolfram,
On Tue, Feb 8, 2022 at 1:35 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > While I2C on R-Car Gen4 does support some extra features (Slave Clock
> > > Stretch Select, Fast-mode Plus), for now it is treated the same as I2C
> >
> > Correction: R-Car S4 does not support Fast-mode Plus, so there will be
> > a v2 of this patch, eventually.
>
> But why? Unless we implement slave clock stretching, we can still keep
> it at Gen3 level. Which does also not have FM+.
Don't we want to introduce a family-specific compatible value for
R-Car Gen4? At least the SCSS seems to be a new R-Car Gen4 feature
common to R-Car S4 and R-Car V3U (yes, the latter is advertised as
the first member of the R-Car Gen4 family, so I intend to move it
over to renesas,rcar-gen4-* where it makes sense).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-08 14:30 ` Geert Uytterhoeven
@ 2022-02-08 14:43 ` Wolfram Sang
2022-02-08 14:50 ` Geert Uytterhoeven
0 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2022-02-08 14:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
> Don't we want to introduce a family-specific compatible value for
> R-Car Gen4? At least the SCSS seems to be a new R-Car Gen4 feature
> common to R-Car S4 and R-Car V3U (yes, the latter is advertised as
> the first member of the R-Car Gen4 family, so I intend to move it
> over to renesas,rcar-gen4-* where it makes sense).
Yeah, sure we want the family compatible. But for now it can point to
I2C_RCAR_GEN3, so the patch can stay as is. That is what I was wondering
about why a v2 was needed. If we add SCSS, we can update the family
compatible data for Gen4 to I2C_RCAR_GEN4. Unless I miss something.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-08 14:43 ` Wolfram Sang
@ 2022-02-08 14:50 ` Geert Uytterhoeven
2022-02-10 22:16 ` Wolfram Sang
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2022-02-08 14:50 UTC (permalink / raw)
To: Wolfram Sang, Geert Uytterhoeven, Rob Herring, Linux-Renesas,
Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Wolfram,
On Tue, Feb 8, 2022 at 3:43 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > Don't we want to introduce a family-specific compatible value for
> > R-Car Gen4? At least the SCSS seems to be a new R-Car Gen4 feature
> > common to R-Car S4 and R-Car V3U (yes, the latter is advertised as
> > the first member of the R-Car Gen4 family, so I intend to move it
> > over to renesas,rcar-gen4-* where it makes sense).
>
> Yeah, sure we want the family compatible. But for now it can point to
> I2C_RCAR_GEN3, so the patch can stay as is. That is what I was wondering
> about why a v2 was needed. If we add SCSS, we can update the family
> compatible data for Gen4 to I2C_RCAR_GEN4. Unless I miss something.
Ah, there's the source of the confusion! ;-)
There's a need for a v2 because the patch description says R-Car S4
supports FM+, which is false.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
@ 2022-02-10 22:15 ` Wolfram Sang
2022-02-11 14:11 ` Rob Herring
2022-02-11 17:33 ` Wolfram Sang
2 siblings, 0 replies; 13+ messages in thread
From: Wolfram Sang @ 2022-02-10 22:15 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Rob Herring, linux-renesas-soc, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Thu, Feb 03, 2022 at 03:33:16PM +0100, Geert Uytterhoeven wrote:
> Document support for the I2C Bus Interfaces in the Renesas R-Car S4-8
> (R8A779F0) SoC, including a new family-specific compatible value for the
> R-Car Gen4 family.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-08 14:50 ` Geert Uytterhoeven
@ 2022-02-10 22:16 ` Wolfram Sang
0 siblings, 0 replies; 13+ messages in thread
From: Wolfram Sang @ 2022-02-10 22:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On Tue, Feb 08, 2022 at 03:50:02PM +0100, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Tue, Feb 8, 2022 at 3:43 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > > Don't we want to introduce a family-specific compatible value for
> > > R-Car Gen4? At least the SCSS seems to be a new R-Car Gen4 feature
> > > common to R-Car S4 and R-Car V3U (yes, the latter is advertised as
> > > the first member of the R-Car Gen4 family, so I intend to move it
> > > over to renesas,rcar-gen4-* where it makes sense).
> >
> > Yeah, sure we want the family compatible. But for now it can point to
> > I2C_RCAR_GEN3, so the patch can stay as is. That is what I was wondering
> > about why a v2 was needed. If we add SCSS, we can update the family
> > compatible data for Gen4 to I2C_RCAR_GEN4. Unless I miss something.
>
> Ah, there's the source of the confusion! ;-)
>
> There's a need for a v2 because the patch description says R-Car S4
> supports FM+, which is false.
Now we got it! :)
Well, I can simply remove FM+ from the message when applying?
Anyway, with the above fixed:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
2022-02-10 22:15 ` Wolfram Sang
@ 2022-02-11 14:11 ` Rob Herring
2022-02-11 17:33 ` Wolfram Sang
2 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2022-02-11 14:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-renesas-soc, Wolfram Sang, linux-i2c, Rob Herring, devicetree
On Thu, 03 Feb 2022 15:33:16 +0100, Geert Uytterhoeven wrote:
> Document support for the I2C Bus Interfaces in the Renesas R-Car S4-8
> (R8A779F0) SoC, including a new family-specific compatible value for the
> R-Car Gen4 family.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
2022-02-10 22:15 ` Wolfram Sang
2022-02-11 14:11 ` Rob Herring
@ 2022-02-11 17:33 ` Wolfram Sang
2 siblings, 0 replies; 13+ messages in thread
From: Wolfram Sang @ 2022-02-11 17:33 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Rob Herring, linux-renesas-soc, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Thu, Feb 03, 2022 at 03:33:16PM +0100, Geert Uytterhoeven wrote:
> Document support for the I2C Bus Interfaces in the Renesas R-Car S4-8
> (R8A779F0) SoC, including a new family-specific compatible value for the
> R-Car Gen4 family.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support
2022-02-03 14:33 ` [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support Geert Uytterhoeven
2022-02-08 8:08 ` Geert Uytterhoeven
@ 2022-02-11 17:33 ` Wolfram Sang
1 sibling, 0 replies; 13+ messages in thread
From: Wolfram Sang @ 2022-02-11 17:33 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Rob Herring, linux-renesas-soc, linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Thu, Feb 03, 2022 at 03:33:17PM +0100, Geert Uytterhoeven wrote:
> Add support for the I2C Bus Interface on R-Car Gen4 SoCs (e.g. R-Car
> S4-8) by matching on a family-specific compatible value.
>
> While I2C on R-Car Gen4 does support some extra features (Slave Clock
> Stretch Select, Fast-mode Plus), for now it is treated the same as I2C
> on R-Car Gen3.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixed commit message and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-02-11 17:33 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 14:33 [PATCH 0/2] i2c: rcar: Add R-Car S4-8 support Geert Uytterhoeven
2022-02-03 14:33 ` [PATCH 1/2] dt-bindings: i2c: renesas,rcar-i2c: Add r8a779f0 support Geert Uytterhoeven
2022-02-10 22:15 ` Wolfram Sang
2022-02-11 14:11 ` Rob Herring
2022-02-11 17:33 ` Wolfram Sang
2022-02-03 14:33 ` [PATCH 2/2] i2c: rcar: Add R-Car Gen4 support Geert Uytterhoeven
2022-02-08 8:08 ` Geert Uytterhoeven
2022-02-08 12:35 ` Wolfram Sang
2022-02-08 14:30 ` Geert Uytterhoeven
2022-02-08 14:43 ` Wolfram Sang
2022-02-08 14:50 ` Geert Uytterhoeven
2022-02-10 22:16 ` Wolfram Sang
2022-02-11 17:33 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.