All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort
Date: Fri, 11 Feb 2022 11:49:51 +0000	[thread overview]
Message-ID: <YgZNX4ZuSumZ/Yie@sirena.org.uk> (raw)
In-Reply-To: <20220211034344.4130-6-jon.lin@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On Fri, Feb 11, 2022 at 11:43:42AM +0800, Jon Lin wrote:

> After slave abort, all DMA should be stopped, or it will affect the
> next transmission:

Again, this is a fix and should be at the start of the series.

> 
> [   31.693877] Unable to handle kernel paging request at virtual address ffffff8105a2a7c0
> [   31.694643] Mem abort info:
> [   31.694898]   ESR = 0x96000045
> [   31.695179]   EC = 0x25: DABT (current EL), IL = 32 bits
> [   31.695653]   SET = 0, FnV = 0
> [   31.695931]   EA = 0, S1PTW = 0

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort
Date: Fri, 11 Feb 2022 11:49:51 +0000	[thread overview]
Message-ID: <YgZNX4ZuSumZ/Yie@sirena.org.uk> (raw)
In-Reply-To: <20220211034344.4130-6-jon.lin@rock-chips.com>


[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]

On Fri, Feb 11, 2022 at 11:43:42AM +0800, Jon Lin wrote:

> After slave abort, all DMA should be stopped, or it will affect the
> next transmission:

Again, this is a fix and should be at the start of the series.

> 
> [   31.693877] Unable to handle kernel paging request at virtual address ffffff8105a2a7c0
> [   31.694643] Mem abort info:
> [   31.694898]   ESR = 0x96000045
> [   31.695179]   EC = 0x25: DABT (current EL), IL = 32 bits
> [   31.695653]   SET = 0, FnV = 0
> [   31.695931]   EA = 0, S1PTW = 0

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort
Date: Fri, 11 Feb 2022 11:49:51 +0000	[thread overview]
Message-ID: <YgZNX4ZuSumZ/Yie@sirena.org.uk> (raw)
In-Reply-To: <20220211034344.4130-6-jon.lin@rock-chips.com>


[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]

On Fri, Feb 11, 2022 at 11:43:42AM +0800, Jon Lin wrote:

> After slave abort, all DMA should be stopped, or it will affect the
> next transmission:

Again, this is a fix and should be at the start of the series.

> 
> [   31.693877] Unable to handle kernel paging request at virtual address ffffff8105a2a7c0
> [   31.694643] Mem abort info:
> [   31.694898]   ESR = 0x96000045
> [   31.695179]   EC = 0x25: DABT (current EL), IL = 32 bits
> [   31.695653]   SET = 0, FnV = 0
> [   31.695931]   EA = 0, S1PTW = 0

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-11 11:50 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  3:43 [PATCH 1/6] spi: rockchip: Stop spi slave dma receiver when cs inactive Jon Lin
2022-02-11  3:43 ` Jon Lin
2022-02-11  3:43 ` Jon Lin
2022-02-11  3:43 ` [PATCH 2/6] spi: rockchip: Preset cs-high and clk polarity in setup progress Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11 11:24   ` Mark Brown
2022-02-11 11:24     ` Mark Brown
2022-02-11 11:24     ` Mark Brown
     [not found]     ` <4222ce7d-a1e3-1728-fec2-976946b06ba9@rock-chips.com>
2022-02-14 12:49       ` Mark Brown
2022-02-14 12:49         ` Mark Brown
2022-02-14 12:49         ` Mark Brown
     [not found]         ` <e0f0ca0d-40df-cf86-9471-9272bcc171f9@rock-chips.com>
2022-02-15 12:36           ` Mark Brown
2022-02-15 12:36             ` Mark Brown
2022-02-15 12:36             ` Mark Brown
2022-02-16  1:23             ` Jon Lin
2022-02-16  1:23               ` Jon Lin
2022-02-16  1:23               ` Jon Lin
2022-02-11  3:43 ` [PATCH 3/6] spi: rockchip: Fix error in getting num-cs property Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11 11:25   ` Mark Brown
2022-02-11 11:25     ` Mark Brown
2022-02-11 11:25     ` Mark Brown
2022-02-11  3:43 ` [PATCH 4/6] spi: rockchip: Suspend and resume the bus during NOIRQ_SYSTEM_SLEEP_PM ops Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43 ` [PATCH v10 5/6] spi: rockchip: Support cs-gpio Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11 11:48   ` Mark Brown
2022-02-11 11:48     ` Mark Brown
2022-02-11 11:48     ` Mark Brown
2022-02-11  3:43 ` [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11 11:49   ` Mark Brown [this message]
2022-02-11 11:49     ` Mark Brown
2022-02-11 11:49     ` Mark Brown
2022-02-11  3:43 ` [PATCH 6/6] spi: rockchip: clear interrupt status in error handler Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43 ` [PATCH v10 6/6] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2022-02-11  3:43   ` Jon Lin
2022-02-11  3:43   ` Jon Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgZNX4ZuSumZ/Yie@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=jon.lin@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.