All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names
Date: Fri, 11 Feb 2022 16:16:22 -0600	[thread overview]
Message-ID: <YgbgNrgEtG4PFxeB@heinlein> (raw)
In-Reply-To: <20220211014347.24841-4-potin.lai@quantatw.com>


[-- Attachment #1.1: Type: text/plain, Size: 4279 bytes --]

On Fri, Feb 11, 2022 at 09:43:40AM +0800, Potin Lai wrote:
> update gpio-line-names for gpio0 and all io expander

It would be good to describe what kind of update(s) you are doing.  I see mostly
pins being added.  Maybe a bullet-point of what ones you are adding?

> 
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
>  .../dts/aspeed-bmc-facebook-bletchley.dts     | 26 ++++++++++---------
>  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index ebd2430a3bdd..fc0690ccdb0a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -270,7 +270,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","",
> +		"led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","SLED1_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -333,7 +333,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","",
> +		"led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","SLED2_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -400,7 +400,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","",
> +		"led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","SLED3_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -463,7 +463,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","",
> +		"led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","SLED4_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -526,7 +526,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","",
> +		"led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","SLED5_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -589,7 +589,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","",
> +		"led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","SLED6_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -727,16 +727,17 @@
>  	/*D0-D7*/	"","","","","","","","",
>  	/*E0-E7*/	"","","","","","","","",
>  	/*F0-F7*/	"","","","","","","","",
> -	/*G0-G7*/	"","SWITCH_FRU_MUX","","","","","","",
> +	/*G0-G7*/	"BSM_FRU_WP","SWITCH_FRU_MUX","","",
> +			"PWRGD_P1V05_VDDCORE","PWRGD_P1V5_VDD","","",
>  	/*H0-H7*/	"presence-riser1","presence-riser2",
>  			"presence-sled1","presence-sled2",
>  			"presence-sled3","presence-sled4",
>  			"presence-sled5","presence-sled6",
>  	/*I0-I7*/	"REV_ID0","","REV_ID1","REV_ID2",
> -			"","","","",
> +			"","BSM_FLASH_WP_STATUS","BMC_TPM_PRES","",
>  	/*J0-J7*/	"","","","","","","","",
>  	/*K0-K7*/	"","","","","","","","",
> -	/*L0-L7*/	"","","","","","","","",
> +	/*L0-L7*/	"","","","","","BMC_RTC_INT","","",
>  	/*M0-M7*/	"ALERT_SLED1","ALERT_SLED2",
>  			"ALERT_SLED3","ALERT_SLED4",
>  			"ALERT_SLED5","ALERT_SLED6",
> @@ -744,19 +745,20 @@
>  	/*N0-N7*/	"","","","","","","","",
>  	/*O0-O7*/	"","","","",
>  			"","BOARD_ID0","BOARD_ID1","BOARD_ID2",
> -	/*P0-P7*/	"","","","","","","","",
> +	/*P0-P7*/	"","","","","","","","BMC_HEARTBEAT",
>  	/*Q0-Q7*/	"","","","","","","","",
>  	/*R0-R7*/	"","","","","","","","",
>  	/*S0-S7*/	"","","","BAT_DETECT",
>  			"BMC_BT_WP0","BMC_BT_WP1","","",
>  	/*T0-T7*/	"","","","","","","","",
>  	/*U0-U7*/	"","","","","","","","",
> -	/*V0-V7*/	"","RST_BMC_MVL","","",
> +	/*V0-V7*/	"PWRGD_CNS_PSU","RST_BMC_MVL","","PSU_PRSNT",
>  			"USB2_SEL0_A","USB2_SEL1_A",
>  			"USB2_SEL0_B","USB2_SEL1_B",
>  	/*W0-W7*/	"RST_FRONT_IOEXP","","","","","","","",
>  	/*X0-X7*/	"","","","","","","","",
> -	/*Y0-Y7*/	"","","BSM_FLASH_LATCH","","","","","",
> +	/*Y0-Y7*/	"BMC_SELF_HW_RST","BSM_PRSNT","BSM_FLASH_LATCH","",
> +			"","","","",
>  	/*Z0-Z7*/	"","","","","","","","";
>  };
>  
> -- 
> 2.17.1
> 

-- 
Patrick Williams

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Patrick Williams <patrick@stwcx.xyz>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names
Date: Fri, 11 Feb 2022 16:16:22 -0600	[thread overview]
Message-ID: <YgbgNrgEtG4PFxeB@heinlein> (raw)
In-Reply-To: <20220211014347.24841-4-potin.lai@quantatw.com>

[-- Attachment #1: Type: text/plain, Size: 4279 bytes --]

On Fri, Feb 11, 2022 at 09:43:40AM +0800, Potin Lai wrote:
> update gpio-line-names for gpio0 and all io expander

It would be good to describe what kind of update(s) you are doing.  I see mostly
pins being added.  Maybe a bullet-point of what ones you are adding?

> 
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
>  .../dts/aspeed-bmc-facebook-bletchley.dts     | 26 ++++++++++---------
>  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index ebd2430a3bdd..fc0690ccdb0a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -270,7 +270,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","",
> +		"led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","SLED1_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -333,7 +333,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","",
> +		"led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","SLED2_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -400,7 +400,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","",
> +		"led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","SLED3_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -463,7 +463,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","",
> +		"led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","SLED4_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -526,7 +526,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","",
> +		"led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","SLED5_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -589,7 +589,7 @@
>  		#gpio-cells = <2>;
>  
>  		gpio-line-names =
> -		"led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","",
> +		"led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","SLED6_MD_REF_PWM",
>  		"","","","",
>  		"","","","",
>  		"","","","";
> @@ -727,16 +727,17 @@
>  	/*D0-D7*/	"","","","","","","","",
>  	/*E0-E7*/	"","","","","","","","",
>  	/*F0-F7*/	"","","","","","","","",
> -	/*G0-G7*/	"","SWITCH_FRU_MUX","","","","","","",
> +	/*G0-G7*/	"BSM_FRU_WP","SWITCH_FRU_MUX","","",
> +			"PWRGD_P1V05_VDDCORE","PWRGD_P1V5_VDD","","",
>  	/*H0-H7*/	"presence-riser1","presence-riser2",
>  			"presence-sled1","presence-sled2",
>  			"presence-sled3","presence-sled4",
>  			"presence-sled5","presence-sled6",
>  	/*I0-I7*/	"REV_ID0","","REV_ID1","REV_ID2",
> -			"","","","",
> +			"","BSM_FLASH_WP_STATUS","BMC_TPM_PRES","",
>  	/*J0-J7*/	"","","","","","","","",
>  	/*K0-K7*/	"","","","","","","","",
> -	/*L0-L7*/	"","","","","","","","",
> +	/*L0-L7*/	"","","","","","BMC_RTC_INT","","",
>  	/*M0-M7*/	"ALERT_SLED1","ALERT_SLED2",
>  			"ALERT_SLED3","ALERT_SLED4",
>  			"ALERT_SLED5","ALERT_SLED6",
> @@ -744,19 +745,20 @@
>  	/*N0-N7*/	"","","","","","","","",
>  	/*O0-O7*/	"","","","",
>  			"","BOARD_ID0","BOARD_ID1","BOARD_ID2",
> -	/*P0-P7*/	"","","","","","","","",
> +	/*P0-P7*/	"","","","","","","","BMC_HEARTBEAT",
>  	/*Q0-Q7*/	"","","","","","","","",
>  	/*R0-R7*/	"","","","","","","","",
>  	/*S0-S7*/	"","","","BAT_DETECT",
>  			"BMC_BT_WP0","BMC_BT_WP1","","",
>  	/*T0-T7*/	"","","","","","","","",
>  	/*U0-U7*/	"","","","","","","","",
> -	/*V0-V7*/	"","RST_BMC_MVL","","",
> +	/*V0-V7*/	"PWRGD_CNS_PSU","RST_BMC_MVL","","PSU_PRSNT",
>  			"USB2_SEL0_A","USB2_SEL1_A",
>  			"USB2_SEL0_B","USB2_SEL1_B",
>  	/*W0-W7*/	"RST_FRONT_IOEXP","","","","","","","",
>  	/*X0-X7*/	"","","","","","","","",
> -	/*Y0-Y7*/	"","","BSM_FLASH_LATCH","","","","","",
> +	/*Y0-Y7*/	"BMC_SELF_HW_RST","BSM_PRSNT","BSM_FLASH_LATCH","",
> +			"","","","",
>  	/*Z0-Z7*/	"","","","","","","","";
>  };
>  
> -- 
> 2.17.1
> 

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-02-11 22:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  1:43 [PATCH 00/10] arch: arm: dts: update Facebook Bletchley BMC Potin Lai
2022-02-11  1:43 ` [PATCH 01/10] arch: arm: dts: bletchley: switch sled numbering to 1-based Potin Lai
2022-02-11  1:43 ` [PATCH 02/10] arch: arm: dts: bletchley: separate leds into multiple groups Potin Lai
2022-02-11  1:43 ` [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names Potin Lai
2022-02-11 22:16   ` Patrick Williams [this message]
2022-02-11 22:16     ` Patrick Williams
2022-02-11  1:43 ` [PATCH 04/10] arch: arm: dts: bletchley: update fmc configurations Potin Lai
2022-02-11  1:43 ` [PATCH 05/10] arch: arm: dts: bletchley: switch to spi-gpio for spi2 Potin Lai
2022-02-11  1:43 ` [PATCH 06/10] arch: arm: dts: bletchley: add interrupt support for sled io expander Potin Lai
2022-02-11  1:43 ` [PATCH 07/10] arch: arm: dts: bletchley: add shunt-resistor for ADM1278 Potin Lai
2022-02-11  1:43 ` [PATCH 08/10] arch: arm: dts: bletchley: add INA230 sensor on each sled Potin Lai
2022-02-11  1:43 ` [PATCH 09/10] arch: arm: dts: bletchley: enable mdio3 bus Potin Lai
2022-02-11  1:43 ` [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node Potin Lai
2022-02-11 22:19   ` Patrick Williams
2022-02-11 22:19     ` Patrick Williams
2022-02-11 22:20 ` [PATCH 00/10] arch: arm: dts: update Facebook Bletchley BMC Patrick Williams
2022-02-11 22:20   ` Patrick Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgbgNrgEtG4PFxeB@heinlein \
    --to=patrick@stwcx.xyz \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=potin.lai@quantatw.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.