All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: tomeu.vizoso@collabora.com, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, alyssa.rosenzweig@collabora.com
Subject: Re: [PATCH 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk
Date: Mon, 14 Feb 2022 12:11:30 -0500	[thread overview]
Message-ID: <YgqNQpjwkBtPOgls@maud> (raw)
In-Reply-To: <265e99b9-fbde-bdcf-d8e9-e5deba1d9564@arm.com>

> > TTRX_3485 requires the infamous "dummy job" workaround. I have this
> > workaround implemented in a local branch, but I have not yet hit a case
> > that requires it so I cannot test whether the implementation is correct.
> > In the mean time, add the quirk bit so we can document which platforms
> > may need it in the future.
> 
> This one is hideous ;) Although to me this isn't the 'infamous' one as
> it's not the earliest example of a dummy job.

Terrifying. I guess we narrowly avoided the 'replay' workaround which
was far worse than this one...

> However... I believe as Panfrost currently stands this is probably not
> very possible to hit. It requires a job to be stopped (soft or hard) at
> a critical point during submission - which at the moment Panfrost
> basically never does (the exception is if you close the fd immediately
> while a job is in progress). And of course the timing has to be 'just
> right' to hit the bug.

OK, that's good to know. Still "should" be fixed but that definitely
lowers the priority of it. Frankly the multithreading bugs we have on
the CPU side would hang the machine sooner...

  reply	other threads:[~2022-02-14 17:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 20:27 [PATCH 0/9] drm/panfrost: Initial Valhall support alyssa.rosenzweig
2022-02-11 20:27 ` [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible alyssa.rosenzweig
2022-02-11 20:27   ` alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 16:23     ` Steven Price
2022-02-14 16:58     ` Alyssa Rosenzweig
2022-02-14 16:58       ` Alyssa Rosenzweig
2022-02-14 17:38     ` Daniel Stone
2022-02-14 17:38       ` Daniel Stone
2022-02-15 12:17   ` Robin Murphy
2022-02-15 12:17     ` Robin Murphy
2022-02-15 15:22   ` Rob Herring
2022-02-15 15:22     ` Rob Herring
2022-02-11 20:27 ` [PATCH 2/9] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162 alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-11 20:27 ` [PATCH 3/9] drm/panfrost: Constify argument to has_hw_issue alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-11 20:27 ` [PATCH 4/9] drm/panfrost: Handle HW_ISSUE_TTRX_3076 alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 17:06     ` Alyssa Rosenzweig
2022-02-16 16:06       ` Steven Price
2022-02-11 20:27 ` [PATCH 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 17:11     ` Alyssa Rosenzweig [this message]
2022-02-11 20:27 ` [PATCH 6/9] drm/panfrost: Add "clean only safe" feature bit alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 17:01     ` Alyssa Rosenzweig
2022-02-16 16:06       ` Steven Price
2022-02-11 20:27 ` [PATCH 7/9] drm/panfrost: Don't set L2_MMU_CONFIG quirks alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-11 20:27 ` [PATCH 8/9] drm/panfrost: Add Mali-G57 "Natt" support alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 17:04     ` Alyssa Rosenzweig
2022-02-11 20:27 ` [PATCH 9/9] drm/panfrost: Handle arm,mali-valhall compatible alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgqNQpjwkBtPOgls@maud \
    --to=alyssa@collabora.com \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.