Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible

From: Daniel Stone <daniel@fooishbar.org>
To: Steven Price <steven.price@arm.com>
Cc: alyssa.rosenzweig@collabora.com, dri-devel@lists.freedesktop.org,
	airlied@linux.ie, tomeu.vizoso@collabora.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible
Date: Mon, 14 Feb 2022 17:38:43 +0000	[thread overview]
Message-ID: <CAPj87rNwh28GYv_CoQGB2UCqfP8A=ORiem5Z+Vev=u6WZ7YQRw@mail.gmail.com> (raw)
In-Reply-To: <5ca70986-d6a5-7c3e-b876-40e970805775@arm.com>

On Mon, 14 Feb 2022 at 16:23, Steven Price <steven.price@arm.com> wrote:
> On 11/02/2022 20:27, alyssa.rosenzweig@collabora.com wrote:
> > From the kernel's perspective, pre-CSF Valhall is more or less
> > compatible with Bifrost, although they differ to userspace. Add a
> > compatible for Valhall to the existing Bifrost bindings documentation.
> >
> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > index 63a08f3f321d..48aeabd2ed68 100644
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > @@ -23,6 +23,7 @@ properties:
> >            - rockchip,px30-mali
> >            - rockchip,rk3568-mali
> >        - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> > +      - const: arm,mali-valhall # Mali Valhall GPU model/revision is fully discoverable
>
> It might be worth spelling out here that this is *pre-CSF* Valhall. I'm
> pretty sure we're going to need different bindings for CSF GPUs.

Good point - maybe either make it arm,mali-valhall-jm then?

Cheers,
Daniel