cs4265: failed to add widget SPDIF dapm kcontrol

cs4265: failed to add widget SPDIF dapm kcontrol

[Fabio Estevam]

Hi Charles,

I have a custom board with a cs4265 codec and the audio plays fine.

During boot, the following error messages are seen:

asoc-simple-card sound: control 2:0:0:SPDIF Switch:0 is already present
cs4265 1-004f: ASoC: failed to add widget SPDIF dapm kcontrol SPDIF Switch: -16

SPDIF is not used on this board.

Would you have any recommendations for getting rid of such error messages?

Thanks,

Fabio Estevam

Re: cs4265: failed to add widget SPDIF dapm kcontrol

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Mon, Feb 14, 2022 at 08:13:02AM -0300, Fabio Estevam wrote:

> asoc-simple-card sound: control 2:0:0:SPDIF Switch:0 is already present
> cs4265 1-004f: ASoC: failed to add widget SPDIF dapm kcontrol SPDIF Switch: -16

> SPDIF is not used on this board.

> Would you have any recommendations for getting rid of such error messages?

The driver is just plain buggy, it defines both a regular SPIDF Switch
control and a SND_SOC_DAPM_SWITCH() called SPDIF both of which will
create an identically named control, it can never have loaded without
error.  One or both of those has to be renamed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: cs4265: failed to add widget SPDIF dapm kcontrol

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

On Mon, Feb 14, 2022 at 05:14:17PM +0000, Mark Brown wrote:
> On Mon, Feb 14, 2022 at 08:13:02AM -0300, Fabio Estevam wrote:
> 
> > asoc-simple-card sound: control 2:0:0:SPDIF Switch:0 is already present
> > cs4265 1-004f: ASoC: failed to add widget SPDIF dapm kcontrol SPDIF Switch: -16
> 
> > SPDIF is not used on this board.
> 
> > Would you have any recommendations for getting rid of such error messages?
> 
> The driver is just plain buggy, it defines both a regular SPIDF Switch
> control and a SND_SOC_DAPM_SWITCH() called SPDIF both of which will
> create an identically named control, it can never have loaded without
> error.  One or both of those has to be renamed.

...or they need to be merged into one thing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: cs4265: failed to add widget SPDIF dapm kcontrol

[Fabio Estevam]

Hi Mark,

On Mon, Feb 14, 2022 at 2:14 PM Mark Brown <broonie@kernel.org> wrote:

> The driver is just plain buggy, it defines both a regular SPIDF Switch
> control and a SND_SOC_DAPM_SWITCH() called SPDIF both of which will
> create an identically named control, it can never have loaded without
> error.  One or both of those has to be renamed.

Thanks. That did the trick. I have just sent a patch.

Thanks