* [LTP] [COMMITTED][PATCH 1/1] ustat: Add missing space in known-fail
@ 2022-02-16 9:08 Petr Vorel
2022-02-16 9:10 ` Petr Vorel
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2022-02-16 9:08 UTC (permalink / raw)
To: ltp
Although testinfo.pl in a7b6c94503 adds extra space for producing doc,
space was missing when printing after test run:
$ ./ustat01
...
HINT: You _MAY_ be hit by known kernel failures:
ustat() is known to fail with EINVAL on Btrfs, seehttps://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
We might just remove the space from docparse/testinfo.pl which is now
useless:
diff --git docparse/testinfo.pl docparse/testinfo.pl
index 67e435d794..fa77b53cc5 100755
--- docparse/testinfo.pl
+++ docparse/testinfo.pl
@@ -456,7 +456,7 @@ sub content_all_tests
# tag value value can be split into more lines if too long
# i.e. URL in known-fail
for (@$tag[2 .. $#$tag]) {
- $v .= " $_";
+ $v .= $_;
}
$content .= "\n|" . reference($k) . "\n|$v\n";
testcases/kernel/syscalls/ustat/ustat01.c | 2 +-
testcases/kernel/syscalls/ustat/ustat02.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/ustat/ustat01.c b/testcases/kernel/syscalls/ustat/ustat01.c
index 66dbc0b184..70a44adb46 100644
--- a/testcases/kernel/syscalls/ustat/ustat01.c
+++ b/testcases/kernel/syscalls/ustat/ustat01.c
@@ -45,7 +45,7 @@ static struct tst_test test = {
.test_all = run,
.setup = setup,
.tags = (const struct tst_tag[]) {
- {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
+ {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
"https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
},
{}
diff --git a/testcases/kernel/syscalls/ustat/ustat02.c b/testcases/kernel/syscalls/ustat/ustat02.c
index 55bdcaedf8..a5b0cc1b68 100644
--- a/testcases/kernel/syscalls/ustat/ustat02.c
+++ b/testcases/kernel/syscalls/ustat/ustat02.c
@@ -64,7 +64,7 @@ static struct tst_test test = {
.setup = setup,
.tcnt = ARRAY_SIZE(tc),
.tags = (const struct tst_tag[]) {
- {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
+ {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
"https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
},
{}
--
2.35.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [LTP] [COMMITTED][PATCH 1/1] ustat: Add missing space in known-fail
2022-02-16 9:08 [LTP] [COMMITTED][PATCH 1/1] ustat: Add missing space in known-fail Petr Vorel
@ 2022-02-16 9:10 ` Petr Vorel
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2022-02-16 9:10 UTC (permalink / raw)
To: ltp
Hi,
> Although testinfo.pl in a7b6c94503 adds extra space for producing doc,
> space was missing when printing after test run:
> $ ./ustat01
> ...
> HINT: You _MAY_ be hit by known kernel failures:
> ustat() is known to fail with EINVAL on Btrfs, seehttps://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> We might just remove the space from docparse/testinfo.pl which is now
> useless:
> diff --git docparse/testinfo.pl docparse/testinfo.pl
> index 67e435d794..fa77b53cc5 100755
> --- docparse/testinfo.pl
> +++ docparse/testinfo.pl
> @@ -456,7 +456,7 @@ sub content_all_tests
> # tag value value can be split into more lines if too long
> # i.e. URL in known-fail
> for (@$tag[2 .. $#$tag]) {
> - $v .= " $_";
> + $v .= $_;
> }
> $content .= "\n|" . reference($k) . "\n|$v\n";
Ah, I confused patchwork (patchwork bug?). The change in docparse/testinfo.pl
was just a suggestion (under first ---).
The real committed change starts below.
Kind regards,
Petr
> testcases/kernel/syscalls/ustat/ustat01.c | 2 +-
> testcases/kernel/syscalls/ustat/ustat02.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> diff --git a/testcases/kernel/syscalls/ustat/ustat01.c b/testcases/kernel/syscalls/ustat/ustat01.c
> index 66dbc0b184..70a44adb46 100644
> --- a/testcases/kernel/syscalls/ustat/ustat01.c
> +++ b/testcases/kernel/syscalls/ustat/ustat01.c
> @@ -45,7 +45,7 @@ static struct tst_test test = {
> .test_all = run,
> .setup = setup,
> .tags = (const struct tst_tag[]) {
> - {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
> + {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
> "https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
> },
> {}
> diff --git a/testcases/kernel/syscalls/ustat/ustat02.c b/testcases/kernel/syscalls/ustat/ustat02.c
> index 55bdcaedf8..a5b0cc1b68 100644
> --- a/testcases/kernel/syscalls/ustat/ustat02.c
> +++ b/testcases/kernel/syscalls/ustat/ustat02.c
> @@ -64,7 +64,7 @@ static struct tst_test test = {
> .setup = setup,
> .tcnt = ARRAY_SIZE(tc),
> .tags = (const struct tst_tag[]) {
> - {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
> + {"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
> "https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
> },
> {}
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-16 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 9:08 [LTP] [COMMITTED][PATCH 1/1] ustat: Add missing space in known-fail Petr Vorel
2022-02-16 9:10 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.