* [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable
@ 2022-02-16 9:07 Bogdan Lezhepekov
2022-02-16 9:26 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Bogdan Lezhepekov @ 2022-02-16 9:07 UTC (permalink / raw)
To: ltp
LTP_fs_open_block_device returned initialized local
variable, when device handler is occupied.
Signed-off-by: Bogdan Lezhepekov <blezhepekov@suse.de>
---
testcases/kernel/fs/scsi/ltpfs/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/fs/scsi/ltpfs/main.c b/testcases/kernel/fs/scsi/ltpfs/main.c
index dc3e8f30c..2c67c7a47 100644
--- a/testcases/kernel/fs/scsi/ltpfs/main.c
+++ b/testcases/kernel/fs/scsi/ltpfs/main.c
@@ -391,7 +391,7 @@ int LTP_fs_open_block_device()
{
dev_t devt;
struct stat statbuf;
- int rc;
+ int rc = 0;
if (ltp_block_dev_handle == 0) {
--
2.35.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable
2022-02-16 9:07 [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable Bogdan Lezhepekov
@ 2022-02-16 9:26 ` Petr Vorel
2022-02-16 9:36 ` blezhepekov
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2022-02-16 9:26 UTC (permalink / raw)
To: Bogdan Lezhepekov; +Cc: ltp
Hi Bogdan,
> LTP_fs_open_block_device returned initialized local
^ uninitialized ?
> variable, when device handler is occupied.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable
2022-02-16 9:26 ` Petr Vorel
@ 2022-02-16 9:36 ` blezhepekov
2022-02-16 12:24 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: blezhepekov @ 2022-02-16 9:36 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On 2022-02-16 11:26, Petr Vorel wrote:
> Hi Bogdan,
>
>> LTP_fs_open_block_device returned initialized local
> ^ uninitialized ?
>
>> variable, when device handler is occupied.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> LGTM.
>
> Kind regards,
> Petr
Oops, it's a typo. Obviously should be "uninitialized".
Want me to submit an update?
-Bogdan
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable
2022-02-16 9:36 ` blezhepekov
@ 2022-02-16 12:24 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2022-02-16 12:24 UTC (permalink / raw)
To: blezhepekov; +Cc: ltp
Hi Bogdan,
> > > LTP_fs_open_block_device returned initialized local
> > ^ uninitialized ?
> Oops, it's a typo. Obviously should be "uninitialized".
> Want me to submit an update?
No need, I fixed it before merge.
Merged as d66c51d92c.
Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-16 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 9:07 [LTP] [PATCH v1] ltpfs/main.c: Initialize return variable Bogdan Lezhepekov
2022-02-16 9:26 ` Petr Vorel
2022-02-16 9:36 ` blezhepekov
2022-02-16 12:24 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.