All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kyle Sanderson <kyle.leet@gmail.com>,
	Dave Chinner <david@fromorbit.com>,
	qat-linux@intel.com, Linux-Kernal <linux-kernel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs
Date: Thu, 3 Mar 2022 10:27:47 +1200	[thread overview]
Message-ID: <Yh/vY4t3xnuoCW3Q@gondor.apana.org.au> (raw)
In-Reply-To: <Yh+FpKuoyj3G16lK@kroah.com>

On Wed, Mar 02, 2022 at 03:56:36PM +0100, Greg KH wrote:
>
> > If not, then these are the patches that should be backported:
> >     7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags
> >     2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS
> >     fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY
> >     b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY
> >     cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
> > Herbert, correct me if I'm wrong here.
> 
> These need to be manually backported as they do not apply cleanly.  Can
> you provide such a set?  Or should I just disable a specific driver here
> instead which would be easier overall?

I think the safest thing is to disable qat in stable (possibly only
when DM_CRYPT is enabled/modular).  The patches in question while
good may have too wide an effect for the stable kernel series.

Giovanni, could you send Greg a Kconfig patch to do that?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
	Dave Chinner <david@fromorbit.com>,
	qat-linux@intel.com, Linux-Kernal <linux-kernel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	Kyle Sanderson <kyle.leet@gmail.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs
Date: Thu, 3 Mar 2022 10:27:47 +1200	[thread overview]
Message-ID: <Yh/vY4t3xnuoCW3Q@gondor.apana.org.au> (raw)
In-Reply-To: <Yh+FpKuoyj3G16lK@kroah.com>

On Wed, Mar 02, 2022 at 03:56:36PM +0100, Greg KH wrote:
>
> > If not, then these are the patches that should be backported:
> >     7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags
> >     2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS
> >     fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY
> >     b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY
> >     cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
> > Herbert, correct me if I'm wrong here.
> 
> These need to be manually backported as they do not apply cleanly.  Can
> you provide such a set?  Or should I just disable a specific driver here
> instead which would be easier overall?

I think the safest thing is to disable qat in stable (possibly only
when DM_CRYPT is enabled/modular).  The patches in question while
good may have too wide an effect for the stable kernel series.

Giovanni, could you send Greg a Kconfig patch to do that?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-03-02 22:28 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19  5:02 Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Kyle Sanderson
2022-02-19  5:02 ` [dm-devel] " Kyle Sanderson
2022-02-19 21:03 ` Dave Chinner
2022-02-19 21:03   ` [dm-devel] " Dave Chinner
2022-02-19 23:00   ` Kyle Sanderson
2022-02-19 23:00     ` [dm-devel] " Kyle Sanderson
2022-02-21 11:47     ` Giovanni Cabiddu
2022-02-21 11:47       ` [dm-devel] " Giovanni Cabiddu
2022-02-28  8:18       ` Kyle Sanderson
2022-02-28  8:18         ` [dm-devel] " Kyle Sanderson
2022-02-28 19:25         ` Linus Torvalds
2022-02-28 19:25           ` [dm-devel] " Linus Torvalds
2022-02-28 20:39           ` Giovanni Cabiddu
2022-02-28 20:39             ` [dm-devel] " Giovanni Cabiddu
2022-02-28 20:59             ` Greg KH
2022-02-28 20:59               ` [dm-devel] " Greg KH
2022-02-28 23:26             ` Herbert Xu
2022-02-28 23:26               ` [dm-devel] " Herbert Xu
2022-03-01  1:12               ` Linus Torvalds
2022-03-01  1:12                 ` [dm-devel] " Linus Torvalds
2022-03-01  4:11                 ` Herbert Xu
2022-03-01  4:11                   ` [dm-devel] " Herbert Xu
2022-03-02 10:29                   ` Greg KH
2022-03-02 10:29                     ` [dm-devel] " Greg KH
2022-03-02 11:49                     ` Giovanni Cabiddu
2022-03-02 11:49                       ` [dm-devel] " Giovanni Cabiddu
2022-03-02 14:56                       ` Greg KH
2022-03-02 14:56                         ` [dm-devel] " Greg KH
2022-03-02 22:27                         ` Herbert Xu [this message]
2022-03-02 22:27                           ` Herbert Xu
2022-03-02 22:42                           ` Giovanni Cabiddu
2022-03-02 22:42                             ` [dm-devel] " Giovanni Cabiddu
2022-03-02 22:45                             ` Herbert Xu
2022-03-02 22:45                               ` [dm-devel] " Herbert Xu
2022-03-03 13:49                               ` Giovanni Cabiddu
2022-03-03 13:49                                 ` [dm-devel] " Giovanni Cabiddu
2022-03-03 19:21                                 ` Eric Biggers
2022-03-03 19:21                                   ` [dm-devel] " Eric Biggers
2022-03-03 21:24                                   ` Giovanni Cabiddu
2022-03-03 21:24                                     ` [dm-devel] " Giovanni Cabiddu
2022-03-03 21:44                                     ` Eric Biggers
2022-03-03 21:44                                       ` [dm-devel] " Eric Biggers
2022-03-04 17:50                                       ` Giovanni Cabiddu
2022-03-16 21:38                                         ` Kyle Sanderson
2022-03-16 21:38                                           ` [dm-devel] " Kyle Sanderson
2022-03-16 22:13                                           ` Herbert Xu
2022-03-16 22:13                                             ` [dm-devel] " Herbert Xu
2022-02-28 21:13           ` Milan Broz
2022-02-28 21:13             ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yh/vY4t3xnuoCW3Q@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kyle.leet@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.