From: Mark Brown <broonie@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl: Fix error handling in pcm030_fabric_probe
Date: Wed, 2 Mar 2022 13:44:27 +0000 [thread overview]
Message-ID: <Yh90u+E3RTuGEDWU@sirena.org.uk> (raw)
In-Reply-To: <20220301075351.31691-1-linmq006@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
On Tue, Mar 01, 2022 at 07:53:48AM +0000, Miaoqian Lin wrote:
> This will call twice platform_device_put()
> if both platform_device_add() and snd_soc_register_card() fails.
> Fix it by using goto label to avoid duplicating the error code logic.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: fsl: Fix error handling in pcm030_fabric_probe
Date: Wed, 2 Mar 2022 13:44:27 +0000 [thread overview]
Message-ID: <Yh90u+E3RTuGEDWU@sirena.org.uk> (raw)
In-Reply-To: <20220301075351.31691-1-linmq006@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
On Tue, Mar 01, 2022 at 07:53:48AM +0000, Miaoqian Lin wrote:
> This will call twice platform_device_put()
> if both platform_device_add() and snd_soc_register_card() fails.
> Fix it by using goto label to avoid duplicating the error code logic.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-02 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 7:53 [PATCH] ASoC: fsl: Fix error handling in pcm030_fabric_probe Miaoqian Lin
2022-03-02 13:44 ` Mark Brown [this message]
2022-03-02 13:44 ` Mark Brown
2022-04-20 2:18 ` [PATCH v2] " Miaoqian Lin
2022-04-20 13:00 ` Mark Brown
2022-04-20 13:00 ` Mark Brown
2022-04-20 13:35 ` Miaoqian Lin
2022-04-20 13:35 ` Miaoqian Lin
2022-04-20 13:41 ` Mark Brown
2022-04-20 13:41 ` Mark Brown
2022-04-20 13:45 ` Miaoqian Lin
2022-04-20 13:45 ` Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh90u+E3RTuGEDWU@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.