* [PATCH v2 0/5] staging: r8188eu: odm cleanups
@ 2022-02-21 7:33 Michael Straube
2022-02-21 7:33 ` [PATCH v2 1/5] staging: r8188eu: remove ODM_CmnInfoHook() Michael Straube
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
This set removes two more functions from the unwanted hal/odm layer.
Tested on x86_64 with Inter-Tech DMG-02.
v2:
Fixed a typo in the commit message of patch 2/5.
unsed -> used
Michael Straube (5):
staging: r8188eu: remove ODM_CmnInfoHook()
staging: r8188eu: convert two u8 variables to bool
staging: r8188eu: remove enum odm_bw
staging: r8188eu: convert type of pBandWidth in odm_dm_struct
staging: r8188eu: remove ODM_CmnInfoUpdate()
drivers/staging/r8188eu/hal/odm.c | 56 +------------------
drivers/staging/r8188eu/hal/rtl8188e_dm.c | 19 ++++---
drivers/staging/r8188eu/include/odm.h | 29 +---------
drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +-
5 files changed, 16 insertions(+), 92 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/5] staging: r8188eu: remove ODM_CmnInfoHook()
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
@ 2022-02-21 7:33 ` Michael Straube
2022-02-21 7:33 ` [PATCH v2 2/5] staging: r8188eu: convert two u8 variables to bool Michael Straube
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Each case in ODM_CmnInfoHook() just sets a single variable. Set the
variables directly and remove ODM_CmnInfoHook().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2:
no changes
drivers/staging/r8188eu/hal/odm.c | 31 -----------------------
drivers/staging/r8188eu/hal/rtl8188e_dm.c | 13 +++++-----
drivers/staging/r8188eu/include/odm.h | 14 ----------
3 files changed, 7 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index e0824eefd83a..6f594ae33c6e 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -639,37 +639,6 @@ void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmn
pDM_Odm->BbSwingFlagOfdm = false;
}
-void ODM_CmnInfoHook(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def CmnInfo, void *pValue)
-{
- /* */
- /* Hook call by reference pointer. */
- /* */
- switch (CmnInfo) {
- /* Dynamic call by reference pointer. */
- case ODM_CMNINFO_WM_MODE:
- pDM_Odm->pWirelessMode = (u8 *)pValue;
- break;
- case ODM_CMNINFO_SEC_CHNL_OFFSET:
- pDM_Odm->pSecChOffset = (u8 *)pValue;
- break;
- case ODM_CMNINFO_BW:
- pDM_Odm->pBandWidth = (u8 *)pValue;
- break;
- case ODM_CMNINFO_CHNL:
- pDM_Odm->pChannel = (u8 *)pValue;
- break;
- case ODM_CMNINFO_SCAN:
- pDM_Odm->pbScanInProcess = (bool *)pValue;
- break;
- case ODM_CMNINFO_POWER_SAVING:
- pDM_Odm->pbPowerSaving = (bool *)pValue;
- break;
- default:
- /* do nothing */
- break;
- }
-}
-
/* Update Band/CHannel/.. The values are dynamic but non-per-packet. */
void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value)
{
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
index a05d8687c18d..09e78c4855f9 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
@@ -38,12 +38,13 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
ODM_CmnInfoUpdate(dm_odm, ODM_CMNINFO_ABILITY, pdmpriv->InitODMFlag);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_WM_MODE, &pmlmeext->cur_wireless_mode);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_SEC_CHNL_OFFSET, &hal_data->nCur40MhzPrimeSC);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_BW, &hal_data->CurrentChannelBW);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_CHNL, &hal_data->CurrentChannel);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_SCAN, &pmlmepriv->bScanInProcess);
- ODM_CmnInfoHook(dm_odm, ODM_CMNINFO_POWER_SAVING, &pwrctrlpriv->bpower_saving);
+ dm_odm->pWirelessMode = &pmlmeext->cur_wireless_mode;
+ dm_odm->pSecChOffset = &hal_data->nCur40MhzPrimeSC;
+ dm_odm->pBandWidth = (u8 *)&hal_data->CurrentChannelBW;
+ dm_odm->pChannel = &hal_data->CurrentChannel;
+ dm_odm->pbScanInProcess = (bool *)&pmlmepriv->bScanInProcess;
+ dm_odm->pbPowerSaving = (bool *)&pwrctrlpriv->bpower_saving;
+
ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_RF_ANTENNA_TYPE, hal_data->TRxAntDivType);
for (i = 0; i < NUM_STA; i++)
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index 9fb09e0a0df9..0e85bd88ab8a 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -126,17 +126,6 @@ enum odm_common_info_def {
ODM_CMNINFO_MP_TEST_CHIP,
/* HOOK BEFORE REG INIT----------- */
- /* Dynamic value: */
-/* POINTER REFERENCE----------- */
- ODM_CMNINFO_WM_MODE, /* ODM_WIRELESS_MODE_E */
- ODM_CMNINFO_SEC_CHNL_OFFSET, /* ODM_SEC_CHNL_OFFSET_E */
- ODM_CMNINFO_BW, /* ODM_BW_E */
- ODM_CMNINFO_CHNL,
-
- ODM_CMNINFO_SCAN,
- ODM_CMNINFO_POWER_SAVING,
-/* POINTER REFERENCE----------- */
-
/* CALL BY VALUE------------- */
ODM_CMNINFO_LINK,
ODM_CMNINFO_RSSI_MIN,
@@ -472,9 +461,6 @@ void ODM_DMWatchdog(struct odm_dm_struct *pDM_Odm);
void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm,
enum odm_common_info_def CmnInfo, u32 Value);
-void ODM_CmnInfoHook(struct odm_dm_struct *pDM_Odm,
- enum odm_common_info_def CmnInfo, void *pValue);
-
void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value);
#endif
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/5] staging: r8188eu: convert two u8 variables to bool
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
2022-02-21 7:33 ` [PATCH v2 1/5] staging: r8188eu: remove ODM_CmnInfoHook() Michael Straube
@ 2022-02-21 7:33 ` Michael Straube
2022-02-21 7:33 ` [PATCH v2 3/5] staging: r8188eu: remove enum odm_bw Michael Straube
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
The variables bScanInProcess in struct mlme_priv and bpower_saving in
struct pwrctrl_priv are both used to store only boolean values true
and false. Convert them from u8 to bool to avoid type casts in the
function Update_ODM_ComInfo_88E().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2:
Fixed a typo in the commit message.
unsed -> used
drivers/staging/r8188eu/hal/rtl8188e_dm.c | 4 ++--
drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
index 09e78c4855f9..082104c9b2e8 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
@@ -42,8 +42,8 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
dm_odm->pSecChOffset = &hal_data->nCur40MhzPrimeSC;
dm_odm->pBandWidth = (u8 *)&hal_data->CurrentChannelBW;
dm_odm->pChannel = &hal_data->CurrentChannel;
- dm_odm->pbScanInProcess = (bool *)&pmlmepriv->bScanInProcess;
- dm_odm->pbPowerSaving = (bool *)&pwrctrlpriv->bpower_saving;
+ dm_odm->pbScanInProcess = &pmlmepriv->bScanInProcess;
+ dm_odm->pbPowerSaving = &pwrctrlpriv->bpower_saving;
ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_RF_ANTENNA_TYPE, hal_data->TRxAntDivType);
diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h
index 1e16fa615b94..d418d57f99b6 100644
--- a/drivers/staging/r8188eu/include/rtw_mlme.h
+++ b/drivers/staging/r8188eu/include/rtw_mlme.h
@@ -310,7 +310,7 @@ struct qos_priv {
struct mlme_priv {
spinlock_t lock;
int fw_state; /* shall we protect this variable? maybe not necessarily... */
- u8 bScanInProcess;
+ bool bScanInProcess;
u8 to_join; /* flag */
u8 to_roaming; /* roaming trying times */
diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/staging/r8188eu/include/rtw_pwrctrl.h
index 2d5298373d74..7c3cb895c3cd 100644
--- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h
+++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h
@@ -49,7 +49,7 @@ struct pwrctrl_priv {
u32 alives;
struct work_struct cpwm_event;
- u8 bpower_saving;
+ bool bpower_saving;
u8 reg_rfoff;
u8 reg_pdnmode; /* powerdown mode */
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/5] staging: r8188eu: remove enum odm_bw
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
2022-02-21 7:33 ` [PATCH v2 1/5] staging: r8188eu: remove ODM_CmnInfoHook() Michael Straube
2022-02-21 7:33 ` [PATCH v2 2/5] staging: r8188eu: convert two u8 variables to bool Michael Straube
@ 2022-02-21 7:33 ` Michael Straube
2022-02-21 7:33 ` [PATCH v2 4/5] staging: r8188eu: convert type of pBandWidth in odm_dm_struct Michael Straube
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
The enums odm_bw and ht_channel_width are redundant. Keep
ht_channel_width and remove odm_bw.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2:
no changes
drivers/staging/r8188eu/hal/odm.c | 4 ++--
drivers/staging/r8188eu/include/odm.h | 6 ------
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index 6f594ae33c6e..5d2f934d78ae 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -266,7 +266,7 @@ static void odm_CommonInfoSelfUpdate(struct odm_dm_struct *pDM_Odm)
u8 i;
struct sta_info *pEntry;
- if (*pDM_Odm->pBandWidth == ODM_BW40M) {
+ if (*pDM_Odm->pBandWidth == HT_CHANNEL_WIDTH_40) {
if (*pDM_Odm->pSecChOffset == 1)
pDM_Odm->ControlChannel = *pDM_Odm->pChannel - 2;
else if (*pDM_Odm->pSecChOffset == 2)
@@ -766,7 +766,7 @@ u32 ODM_Get_Rate_Bitmap(struct odm_dm_struct *pDM_Odm, u32 macid, u32 ra_mask, u
} else if (rssi_level == DM_RATR_STA_MIDDLE) {
rate_bitmap = 0x000ff000;
} else {
- if (*pDM_Odm->pBandWidth == ODM_BW40M)
+ if (*pDM_Odm->pBandWidth == HT_CHANNEL_WIDTH_40)
rate_bitmap = 0x000ff015;
else
rate_bitmap = 0x000ff005;
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index 0e85bd88ab8a..fed12203c558 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -166,12 +166,6 @@ enum odm_wireless_mode {
ODM_WM_AUTO = BIT(5),
};
-/* ODM_CMNINFO_BW */
-enum odm_bw {
- ODM_BW20M = 0,
- ODM_BW40M = 1,
-};
-
struct odm_ra_info {
u8 RateID;
u32 RateMask;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 4/5] staging: r8188eu: convert type of pBandWidth in odm_dm_struct
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
` (2 preceding siblings ...)
2022-02-21 7:33 ` [PATCH v2 3/5] staging: r8188eu: remove enum odm_bw Michael Straube
@ 2022-02-21 7:33 ` Michael Straube
2022-02-21 7:33 ` [PATCH v2 5/5] staging: r8188eu: remove ODM_CmnInfoUpdate() Michael Straube
2022-02-21 17:13 ` [PATCH v2 0/5] staging: r8188eu: odm cleanups Greg KH
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
The variable pBandWidth in odm_dm_struct stores constants from enum
ht_channel_width. Change the type of pBandWidth from u8 pointer to
enum ht_channel_width pointer to get rid of a type cast in function
Update_ODM_ComInfo_88E().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2:
no changes
drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 +-
drivers/staging/r8188eu/include/odm.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
index 082104c9b2e8..df0b412c52eb 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
@@ -40,7 +40,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
dm_odm->pWirelessMode = &pmlmeext->cur_wireless_mode;
dm_odm->pSecChOffset = &hal_data->nCur40MhzPrimeSC;
- dm_odm->pBandWidth = (u8 *)&hal_data->CurrentChannelBW;
+ dm_odm->pBandWidth = &hal_data->CurrentChannelBW;
dm_odm->pChannel = &hal_data->CurrentChannel;
dm_odm->pbScanInProcess = &pmlmepriv->bScanInProcess;
dm_odm->pbPowerSaving = &pwrctrlpriv->bpower_saving;
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index fed12203c558..7a10f57b9bd3 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -324,7 +324,7 @@ struct odm_dm_struct {
/* Secondary channel offset don't_care/below/above = 0/1/2 */
u8 *pSecChOffset;
/* BW info 20M/40M/80M = 0/1/2 */
- u8 *pBandWidth;
+ enum ht_channel_width *pBandWidth;
/* Central channel location Ch1/Ch2/.... */
u8 *pChannel; /* central channel number */
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 5/5] staging: r8188eu: remove ODM_CmnInfoUpdate()
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
` (3 preceding siblings ...)
2022-02-21 7:33 ` [PATCH v2 4/5] staging: r8188eu: convert type of pBandWidth in odm_dm_struct Michael Straube
@ 2022-02-21 7:33 ` Michael Straube
2022-02-21 17:13 ` [PATCH v2 0/5] staging: r8188eu: odm cleanups Greg KH
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-02-21 7:33 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Each case in ODM_CmnInfoUpdate() just sets a single variable. Set the
variables directly and remove ODM_CmnInfoUpdate().
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v2:
no changes
drivers/staging/r8188eu/hal/odm.c | 21 +--------------------
drivers/staging/r8188eu/hal/rtl8188e_dm.c | 4 ++--
drivers/staging/r8188eu/include/odm.h | 7 -------
3 files changed, 3 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index 5d2f934d78ae..94f9b125d860 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -464,7 +464,7 @@ static void odm_RSSIMonitorCheck(struct odm_dm_struct *pDM_Odm)
pdmpriv->EntryMinUndecoratedSmoothedPWDB = 0;
FindMinimumRSSI(Adapter);
- ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_RSSI_MIN, pdmpriv->MinUndecoratedPWDBForDM);
+ pHalData->odmpriv.RSSI_Min = pdmpriv->MinUndecoratedPWDBForDM;
}
static void odm_TXPowerTrackingThermalMeterInit(struct odm_dm_struct *pDM_Odm)
@@ -639,25 +639,6 @@ void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmn
pDM_Odm->BbSwingFlagOfdm = false;
}
-/* Update Band/CHannel/.. The values are dynamic but non-per-packet. */
-void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value)
-{
- /* */
- /* This init variable may be changed in run time. */
- /* */
- switch (CmnInfo) {
- case ODM_CMNINFO_ABILITY:
- pDM_Odm->SupportAbility = (u32)Value;
- break;
- case ODM_CMNINFO_LINK:
- pDM_Odm->bLinked = (bool)Value;
- break;
- case ODM_CMNINFO_RSSI_MIN:
- pDM_Odm->RSSI_Min = (u8)Value;
- break;
- }
-}
-
void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)
{
struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
index df0b412c52eb..6d28e3dc0d26 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
@@ -36,7 +36,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
if (hal_data->AntDivCfg)
pdmpriv->InitODMFlag |= ODM_BB_ANT_DIV;
- ODM_CmnInfoUpdate(dm_odm, ODM_CMNINFO_ABILITY, pdmpriv->InitODMFlag);
+ dm_odm->SupportAbility = pdmpriv->InitODMFlag;
dm_odm->pWirelessMode = &pmlmeext->cur_wireless_mode;
dm_odm->pSecChOffset = &hal_data->nCur40MhzPrimeSC;
@@ -80,7 +80,7 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter)
bLinked = true;
}
- ODM_CmnInfoUpdate(&hal_data->odmpriv, ODM_CMNINFO_LINK, bLinked);
+ hal_data->odmpriv.bLinked = bLinked;
ODM_DMWatchdog(&hal_data->odmpriv);
}
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index 7a10f57b9bd3..b88b3f3d08ee 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -122,19 +122,14 @@ enum odm_common_info_def {
/* Fixed value: */
/* HOOK BEFORE REG INIT----------- */
- ODM_CMNINFO_ABILITY, /* ODM_ABILITY_E */
ODM_CMNINFO_MP_TEST_CHIP,
/* HOOK BEFORE REG INIT----------- */
/* CALL BY VALUE------------- */
- ODM_CMNINFO_LINK,
- ODM_CMNINFO_RSSI_MIN,
ODM_CMNINFO_RF_ANTENNA_TYPE, /* u8 */
/* CALL BY VALUE-------------*/
};
-/* 2011/10/20 MH Define ODM support ability. ODM_CMNINFO_ABILITY */
-
enum odm_ability_def {
/* BB ODM section BIT 0-15 */
ODM_BB_RSSI_MONITOR = BIT(4),
@@ -455,6 +450,4 @@ void ODM_DMWatchdog(struct odm_dm_struct *pDM_Odm);
void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm,
enum odm_common_info_def CmnInfo, u32 Value);
-void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value);
-
#endif
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/5] staging: r8188eu: odm cleanups
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
` (4 preceding siblings ...)
2022-02-21 7:33 ` [PATCH v2 5/5] staging: r8188eu: remove ODM_CmnInfoUpdate() Michael Straube
@ 2022-02-21 17:13 ` Greg KH
2022-02-21 18:48 ` Michael Straube
5 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2022-02-21 17:13 UTC (permalink / raw)
To: Michael Straube; +Cc: Larry.Finger, phil, linux-staging, linux-kernel
On Mon, Feb 21, 2022 at 08:33:01AM +0100, Michael Straube wrote:
> This set removes two more functions from the unwanted hal/odm layer.
> Tested on x86_64 with Inter-Tech DMG-02.
>
> v2:
> Fixed a typo in the commit message of patch 2/5.
> unsed -> used
>
> Michael Straube (5):
> staging: r8188eu: remove ODM_CmnInfoHook()
> staging: r8188eu: convert two u8 variables to bool
> staging: r8188eu: remove enum odm_bw
> staging: r8188eu: convert type of pBandWidth in odm_dm_struct
> staging: r8188eu: remove ODM_CmnInfoUpdate()
>
> drivers/staging/r8188eu/hal/odm.c | 56 +------------------
> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 19 ++++---
> drivers/staging/r8188eu/include/odm.h | 29 +---------
> drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
> drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +-
> 5 files changed, 16 insertions(+), 92 deletions(-)
>
> --
> 2.35.1
>
>
This patch series does not apply to my tree. Please rebase and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/5] staging: r8188eu: odm cleanups
2022-02-21 17:13 ` [PATCH v2 0/5] staging: r8188eu: odm cleanups Greg KH
@ 2022-02-21 18:48 ` Michael Straube
2022-02-21 18:53 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Michael Straube @ 2022-02-21 18:48 UTC (permalink / raw)
To: Greg KH; +Cc: Larry.Finger, phil, linux-staging, linux-kernel
On 2/21/22 18:13, Greg KH wrote:
> On Mon, Feb 21, 2022 at 08:33:01AM +0100, Michael Straube wrote:
>> This set removes two more functions from the unwanted hal/odm layer.
>> Tested on x86_64 with Inter-Tech DMG-02.
>>
>> v2:
>> Fixed a typo in the commit message of patch 2/5.
>> unsed -> used
>>
>> Michael Straube (5):
>> staging: r8188eu: remove ODM_CmnInfoHook()
>> staging: r8188eu: convert two u8 variables to bool
>> staging: r8188eu: remove enum odm_bw
>> staging: r8188eu: convert type of pBandWidth in odm_dm_struct
>> staging: r8188eu: remove ODM_CmnInfoUpdate()
>>
>> drivers/staging/r8188eu/hal/odm.c | 56 +------------------
>> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 19 ++++---
>> drivers/staging/r8188eu/include/odm.h | 29 +---------
>> drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
>> drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +-
>> 5 files changed, 16 insertions(+), 92 deletions(-)
>>
>> --
>> 2.35.1
>>
>>
>
> This patch series does not apply to my tree. Please rebase and resend.
>
Hi Greg,
looks like you already applied v1 of this series.
The only change in v2 was fixing a typo in a commit message..
regards,
Michael
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/5] staging: r8188eu: odm cleanups
2022-02-21 18:48 ` Michael Straube
@ 2022-02-21 18:53 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2022-02-21 18:53 UTC (permalink / raw)
To: Michael Straube; +Cc: Larry.Finger, phil, linux-staging, linux-kernel
On Mon, Feb 21, 2022 at 07:48:22PM +0100, Michael Straube wrote:
> On 2/21/22 18:13, Greg KH wrote:
> > On Mon, Feb 21, 2022 at 08:33:01AM +0100, Michael Straube wrote:
> > > This set removes two more functions from the unwanted hal/odm layer.
> > > Tested on x86_64 with Inter-Tech DMG-02.
> > >
> > > v2:
> > > Fixed a typo in the commit message of patch 2/5.
> > > unsed -> used
> > >
> > > Michael Straube (5):
> > > staging: r8188eu: remove ODM_CmnInfoHook()
> > > staging: r8188eu: convert two u8 variables to bool
> > > staging: r8188eu: remove enum odm_bw
> > > staging: r8188eu: convert type of pBandWidth in odm_dm_struct
> > > staging: r8188eu: remove ODM_CmnInfoUpdate()
> > >
> > > drivers/staging/r8188eu/hal/odm.c | 56 +------------------
> > > drivers/staging/r8188eu/hal/rtl8188e_dm.c | 19 ++++---
> > > drivers/staging/r8188eu/include/odm.h | 29 +---------
> > > drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
> > > drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 +-
> > > 5 files changed, 16 insertions(+), 92 deletions(-)
> > >
> > > --
> > > 2.35.1
> > >
> > >
> >
> > This patch series does not apply to my tree. Please rebase and resend.
> >
>
> Hi Greg,
>
> looks like you already applied v1 of this series.
> The only change in v2 was fixing a typo in a commit message..
Ah, that makes more sense, sorry I missed that, my fault. We can live
with the typo :)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-02-21 18:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 7:33 [PATCH v2 0/5] staging: r8188eu: odm cleanups Michael Straube
2022-02-21 7:33 ` [PATCH v2 1/5] staging: r8188eu: remove ODM_CmnInfoHook() Michael Straube
2022-02-21 7:33 ` [PATCH v2 2/5] staging: r8188eu: convert two u8 variables to bool Michael Straube
2022-02-21 7:33 ` [PATCH v2 3/5] staging: r8188eu: remove enum odm_bw Michael Straube
2022-02-21 7:33 ` [PATCH v2 4/5] staging: r8188eu: convert type of pBandWidth in odm_dm_struct Michael Straube
2022-02-21 7:33 ` [PATCH v2 5/5] staging: r8188eu: remove ODM_CmnInfoUpdate() Michael Straube
2022-02-21 17:13 ` [PATCH v2 0/5] staging: r8188eu: odm cleanups Greg KH
2022-02-21 18:48 ` Michael Straube
2022-02-21 18:53 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.