All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
@ 2022-02-24 10:13 kernel test robot
  2022-02-24 18:42   ` Liam Howlett
  0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2022-02-24 10:13 UTC (permalink / raw)
  To: Liam R. Howlett
  Cc: kbuild-all, Linux Memory Management List, Matthew Wilcox (Oracle)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
commit: 37f4270132af31dd08a209799d420f72bfddb49c [6791/7915] mm: Start tracking VMAs with maple tree
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220224/202202241817.MXoE0NcM-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=37f4270132af31dd08a209799d420f72bfddb49c
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 37f4270132af31dd08a209799d420f72bfddb49c
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/mips/kernel/mips-mt.c:50:6: warning: no previous prototype for 'mips_mt_regdump' [-Wmissing-prototypes]
      50 | void mips_mt_regdump(unsigned long mvpctl)
         |      ^~~~~~~~~~~~~~~
   arch/mips/kernel/mips-mt.c:159:6: warning: no previous prototype for 'mips_mt_set_cpuoptions' [-Wmissing-prototypes]
     159 | void mips_mt_set_cpuoptions(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~
>> arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
     233 | static int __init mt_init(void)
         |                   ^~~~~~~
   In file included from include/linux/mm_types.h:12,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/radix-tree.h:12,
                    from include/linux/idr.h:15,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/energy_model.h:7,
                    from include/linux/device.h:16,
                    from arch/mips/kernel/mips-mt.c:7:
   include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
     589 | static inline void mt_init(struct maple_tree *mt)
         |                    ^~~~~~~


vim +233 arch/mips/kernel/mips-mt.c

27a3bbaf4b1e23 Ralf Baechle 2007-02-07  232  
27a3bbaf4b1e23 Ralf Baechle 2007-02-07 @233  static int __init mt_init(void)
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  234  {
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  235  	struct class *mtc;
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  236  
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  237  	mtc = class_create(THIS_MODULE, "mt");
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  238  	if (IS_ERR(mtc))
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  239  		return PTR_ERR(mtc);
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  240  
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  241  	mt_class = mtc;
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  242  
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  243  	return 0;
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  244  }
27a3bbaf4b1e23 Ralf Baechle 2007-02-07  245  

:::::: The code at line 233 was first introduced by commit
:::::: 27a3bbaf4b1e23a3afbae4d9f72b51a36859f74a [MIPS] VPE: Sprinkle device model code into code to make udev happier.

:::::: TO: Ralf Baechle <ralf@linux-mips.org>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
  2022-02-24 10:13 [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)' kernel test robot
@ 2022-02-24 18:42   ` Liam Howlett
  0 siblings, 0 replies; 7+ messages in thread
From: Liam Howlett @ 2022-02-24 18:42 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, Linux Memory Management List, Matthew Wilcox (Oracle)

* kernel test robot <lkp@intel.com> [220224 05:14]:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: 37f4270132af31dd08a209799d420f72bfddb49c [6791/7915] mm: Start tracking VMAs with maple tree
> config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220224/202202241817.MXoE0NcM-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=37f4270132af31dd08a209799d420f72bfddb49c
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 37f4270132af31dd08a209799d420f72bfddb49c
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/mips/kernel/mips-mt.c:50:6: warning: no previous prototype for 'mips_mt_regdump' [-Wmissing-prototypes]
>       50 | void mips_mt_regdump(unsigned long mvpctl)
>          |      ^~~~~~~~~~~~~~~
>    arch/mips/kernel/mips-mt.c:159:6: warning: no previous prototype for 'mips_mt_set_cpuoptions' [-Wmissing-prototypes]
>      159 | void mips_mt_set_cpuoptions(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~
> >> arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
>      233 | static int __init mt_init(void)
>          |                   ^~~~~~~
>    In file included from include/linux/mm_types.h:12,
>                     from include/linux/mmzone.h:21,
>                     from include/linux/gfp.h:6,
>                     from include/linux/radix-tree.h:12,
>                     from include/linux/idr.h:15,
>                     from include/linux/kernfs.h:12,
>                     from include/linux/sysfs.h:16,
>                     from include/linux/kobject.h:20,
>                     from include/linux/energy_model.h:7,
>                     from include/linux/device.h:16,
>                     from arch/mips/kernel/mips-mt.c:7:
>    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
>      589 | static inline void mt_init(struct maple_tree *mt)
>          |                    ^~~~~~~
> 
> 
> vim +233 arch/mips/kernel/mips-mt.c


Naming is hard, all the good ones are taken.  I'll rename the maple tree
init.

> 
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  232  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07 @233  static int __init mt_init(void)
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  234  {
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  235  	struct class *mtc;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  236  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  237  	mtc = class_create(THIS_MODULE, "mt");
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  238  	if (IS_ERR(mtc))
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  239  		return PTR_ERR(mtc);
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  240  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  241  	mt_class = mtc;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  242  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  243  	return 0;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  244  }
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  245  
> 
> :::::: The code at line 233 was first introduced by commit
> :::::: 27a3bbaf4b1e23a3afbae4d9f72b51a36859f74a [MIPS] VPE: Sprinkle device model code into code to make udev happier.
> 
> :::::: TO: Ralf Baechle <ralf@linux-mips.org>
> :::::: CC: Ralf Baechle <ralf@linux-mips.org>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
@ 2022-02-24 18:42   ` Liam Howlett
  0 siblings, 0 replies; 7+ messages in thread
From: Liam Howlett @ 2022-02-24 18:42 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4192 bytes --]

* kernel test robot <lkp@intel.com> [220224 05:14]:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: 37f4270132af31dd08a209799d420f72bfddb49c [6791/7915] mm: Start tracking VMAs with maple tree
> config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220224/202202241817.MXoE0NcM-lkp(a)intel.com/config)
> compiler: mips-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=37f4270132af31dd08a209799d420f72bfddb49c
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 37f4270132af31dd08a209799d420f72bfddb49c
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/mips/kernel/mips-mt.c:50:6: warning: no previous prototype for 'mips_mt_regdump' [-Wmissing-prototypes]
>       50 | void mips_mt_regdump(unsigned long mvpctl)
>          |      ^~~~~~~~~~~~~~~
>    arch/mips/kernel/mips-mt.c:159:6: warning: no previous prototype for 'mips_mt_set_cpuoptions' [-Wmissing-prototypes]
>      159 | void mips_mt_set_cpuoptions(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~
> >> arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
>      233 | static int __init mt_init(void)
>          |                   ^~~~~~~
>    In file included from include/linux/mm_types.h:12,
>                     from include/linux/mmzone.h:21,
>                     from include/linux/gfp.h:6,
>                     from include/linux/radix-tree.h:12,
>                     from include/linux/idr.h:15,
>                     from include/linux/kernfs.h:12,
>                     from include/linux/sysfs.h:16,
>                     from include/linux/kobject.h:20,
>                     from include/linux/energy_model.h:7,
>                     from include/linux/device.h:16,
>                     from arch/mips/kernel/mips-mt.c:7:
>    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
>      589 | static inline void mt_init(struct maple_tree *mt)
>          |                    ^~~~~~~
> 
> 
> vim +233 arch/mips/kernel/mips-mt.c


Naming is hard, all the good ones are taken.  I'll rename the maple tree
init.

> 
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  232  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07 @233  static int __init mt_init(void)
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  234  {
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  235  	struct class *mtc;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  236  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  237  	mtc = class_create(THIS_MODULE, "mt");
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  238  	if (IS_ERR(mtc))
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  239  		return PTR_ERR(mtc);
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  240  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  241  	mt_class = mtc;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  242  
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  243  	return 0;
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  244  }
> 27a3bbaf4b1e23 Ralf Baechle 2007-02-07  245  
> 
> :::::: The code at line 233 was first introduced by commit
> :::::: 27a3bbaf4b1e23a3afbae4d9f72b51a36859f74a [MIPS] VPE: Sprinkle device model code into code to make udev happier.
> 
> :::::: TO: Ralf Baechle <ralf@linux-mips.org>
> :::::: CC: Ralf Baechle <ralf@linux-mips.org>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
  2022-02-24 18:42   ` Liam Howlett
@ 2022-02-24 19:36     ` Matthew Wilcox
  -1 siblings, 0 replies; 7+ messages in thread
From: Matthew Wilcox @ 2022-02-24 19:36 UTC (permalink / raw)
  To: Liam Howlett; +Cc: kernel test robot, kbuild-all, Linux Memory Management List

On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote:
> >    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
> >      589 | static inline void mt_init(struct maple_tree *mt)
> >          |                    ^~~~~~~
> > 
> > 
> > vim +233 arch/mips/kernel/mips-mt.c
> 
> 
> Naming is hard, all the good ones are taken.  I'll rename the maple tree
> init.

Actually, I think it's probably better to rename the existing one.
mips_mt_init() would be fine.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
@ 2022-02-24 19:36     ` Matthew Wilcox
  0 siblings, 0 replies; 7+ messages in thread
From: Matthew Wilcox @ 2022-02-24 19:36 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote:
> >    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
> >      589 | static inline void mt_init(struct maple_tree *mt)
> >          |                    ^~~~~~~
> > 
> > 
> > vim +233 arch/mips/kernel/mips-mt.c
> 
> 
> Naming is hard, all the good ones are taken.  I'll rename the maple tree
> init.

Actually, I think it's probably better to rename the existing one.
mips_mt_init() would be fine.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
  2022-02-24 19:36     ` Matthew Wilcox
@ 2022-02-25  1:44       ` Liam Howlett
  -1 siblings, 0 replies; 7+ messages in thread
From: Liam Howlett @ 2022-02-25  1:44 UTC (permalink / raw)
  To: Matthew Wilcox
  Cc: kernel test robot, kbuild-all, Linux Memory Management List

* Matthew Wilcox <willy@infradead.org> [220224 14:41]:
> On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote:
> > >    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
> > >      589 | static inline void mt_init(struct maple_tree *mt)
> > >          |                    ^~~~~~~
> > > 
> > > 
> > > vim +233 arch/mips/kernel/mips-mt.c
> > 
> > 
> > Naming is hard, all the good ones are taken.  I'll rename the maple tree
> > init.
> 
> Actually, I think it's probably better to rename the existing one.
> mips_mt_init() would be fine.
> 

Sounds good.  mips_mt_init() fits with the other function names in
mips-mt.c

Thanks,
Liam


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
@ 2022-02-25  1:44       ` Liam Howlett
  0 siblings, 0 replies; 7+ messages in thread
From: Liam Howlett @ 2022-02-25  1:44 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

* Matthew Wilcox <willy@infradead.org> [220224 14:41]:
> On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote:
> > >    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
> > >      589 | static inline void mt_init(struct maple_tree *mt)
> > >          |                    ^~~~~~~
> > > 
> > > 
> > > vim +233 arch/mips/kernel/mips-mt.c
> > 
> > 
> > Naming is hard, all the good ones are taken.  I'll rename the maple tree
> > init.
> 
> Actually, I think it's probably better to rename the existing one.
> mips_mt_init() would be fine.
> 

Sounds good.  mips_mt_init() fits with the other function names in
mips-mt.c

Thanks,
Liam

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-25  1:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 10:13 [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)' kernel test robot
2022-02-24 18:42 ` Liam Howlett
2022-02-24 18:42   ` Liam Howlett
2022-02-24 19:36   ` Matthew Wilcox
2022-02-24 19:36     ` Matthew Wilcox
2022-02-25  1:44     ` Liam Howlett
2022-02-25  1:44       ` Liam Howlett

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.