Re: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5

From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: huziji@marvell.com, ulf.hansson@linaro.org, robh+dt@kernel.org,
	davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org,
	catalin.marinas@arm.com, will@kernel.org,
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
	adrian.hunter@intel.com, thomas.petazzoni@bootlin.com,
	kostap@marvell.com, robert.marko@sartura.hr,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5
Date: Tue, 15 Mar 2022 01:07:46 +0100	[thread overview]
Message-ID: <Yi/Y0iynQbIOo8C0@lunn.ch> (raw)
In-Reply-To: <20220314213143.2404162-2-chris.packham@alliedtelesis.co.nz>

> +    properties:
> +      marvell,function:
> +        $ref: "/schemas/types.yaml#/definitions/string"
> +        description:
> +          Indicates the function to select.
> +        enum: [ gpio, i2c0, i2c1, nand, sdio, spi0, spi1, uart0, uart1, uart2, uart3 ]
> +
> +      marvell,pins:
> +        $ref: /schemas/types.yaml#/definitions/string-array
> +        description:
> +          Array of MPP pins to be used for the given function.
> +        minItems: 1

Now that i've looked at the .txt files, i'm wondering if this should
be split into a marvell,mvebu-pinctrl.yaml and
marvell,ac5-pinctrl.yaml?

I don't know yaml well enough to know if this is possible. All the
mvebu pinctrl drivers have marvell,function and marvell,pins. The enum
will differ, this ethernet switch SoC does not have sata, audio etc,
where as the general purpose Socs do. Can that be represented in yaml?

      Andrew