* [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare
@ 2022-03-07 11:07 Miaoqian Lin
2022-03-08 0:08 ` Linus Walleij
2022-03-14 2:53 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-03-07 11:07 UTC (permalink / raw)
To: Matt Mackall, Herbert Xu, Miaoqian Lin, Linus Walleij,
linux-crypto, linux-kernel
The corresponding API for clk_prepare_enable is clk_disable_unprepare,
other than clk_disable_unprepare.
Fix this by changing clk_disable to clk_disable_unprepare.
Fixes: beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/char/hw_random/nomadik-rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/nomadik-rng.c b/drivers/char/hw_random/nomadik-rng.c
index 67947a19aa22..e8f9621e7954 100644
--- a/drivers/char/hw_random/nomadik-rng.c
+++ b/drivers/char/hw_random/nomadik-rng.c
@@ -65,14 +65,14 @@ static int nmk_rng_probe(struct amba_device *dev, const struct amba_id *id)
out_release:
amba_release_regions(dev);
out_clk:
- clk_disable(rng_clk);
+ clk_disable_unprepare(rng_clk);
return ret;
}
static void nmk_rng_remove(struct amba_device *dev)
{
amba_release_regions(dev);
- clk_disable(rng_clk);
+ clk_disable_unprepare(rng_clk);
}
static const struct amba_id nmk_rng_ids[] = {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare
2022-03-07 11:07 [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare Miaoqian Lin
@ 2022-03-08 0:08 ` Linus Walleij
2022-03-14 2:53 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-03-08 0:08 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Matt Mackall, Herbert Xu, linux-crypto, linux-kernel
On Mon, Mar 7, 2022 at 12:07 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare,
> other than clk_disable_unprepare.
>
> Fix this by changing clk_disable to clk_disable_unprepare.
>
> Fixes: beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Thanks for fixing this!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare
2022-03-07 11:07 [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare Miaoqian Lin
2022-03-08 0:08 ` Linus Walleij
@ 2022-03-14 2:53 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-03-14 2:53 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Matt Mackall, Linus Walleij, linux-crypto, linux-kernel
On Mon, Mar 07, 2022 at 11:07:24AM +0000, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare,
> other than clk_disable_unprepare.
>
> Fix this by changing clk_disable to clk_disable_unprepare.
>
> Fixes: beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/char/hw_random/nomadik-rng.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-14 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 11:07 [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare Miaoqian Lin
2022-03-08 0:08 ` Linus Walleij
2022-03-14 2:53 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.